Small, random optimisations (#363)

* Remove useless player pointer copies

Signed-off-by: Thomas Rohloff <v10lator@myway.de>

* Fix target FPS

Signed-off-by: Thomas Rohloff <v10lator@myway.de>

* Add else

Signed-off-by: Thomas Rohloff <v10lator@myway.de>

* Remove useless addition

Signed-off-by: Thomas Rohloff <v10lator@myway.de>

* Simplify func_8001CA24(Player* player, f32 arg1)

Signed-off-by: Thomas Rohloff <v10lator@myway.de>

* Simplify a few more functions

Signed-off-by: Thomas Rohloff <v10lator@myway.de>

* Make 2 arrays static const

Signed-off-by: Thomas Rohloff <v10lator@myway.de>

---------

Signed-off-by: Thomas Rohloff <v10lator@myway.de>
Co-authored-by: MegaMech <MegaMech@users.noreply.github.com>
This commit is contained in:
V10lator
2025-07-09 20:06:08 +02:00
committed by GitHub
parent 98d660b825
commit d175f5ef24
13 changed files with 66 additions and 97 deletions
+4 -4
View File
@@ -2349,13 +2349,13 @@ void func_80078288(s32 objectIndex) {
break;
case 1:
if (gGamestate != 9) {
sp3A = ((gPlayerOneCopy->speed / 18) * 216) / 2;
sp3A = ((gPlayerOne->speed / 18) * 216) / 2;
sp3E = (random_int(0x000FU) - sp3A) + 0x2D;
sp3C = random_int(0x012CU) + 0x1E;
temp_t6 = camera1->rot[1] + ((s32) (random_int(0x3000U) - 0x1800) / (s16) ((sp3A / 15) + 1));
gObjectList[objectIndex].origin_pos[0] = gPlayerOneCopy->pos[0] + (sins(temp_t6) * sp3C);
gObjectList[objectIndex].origin_pos[1] = sp3E + gPlayerOneCopy->unk_074;
gObjectList[objectIndex].origin_pos[2] = gPlayerOneCopy->pos[2] + (coss(temp_t6) * sp3C);
gObjectList[objectIndex].origin_pos[0] = gPlayerOne->pos[0] + (sins(temp_t6) * sp3C);
gObjectList[objectIndex].origin_pos[1] = sp3E + gPlayerOne->unk_074;
gObjectList[objectIndex].origin_pos[2] = gPlayerOne->pos[2] + (coss(temp_t6) * sp3C);
gObjectList[objectIndex].unk_0C4 = random_int(0x0400U) + 0x100;
gObjectList[objectIndex].unk_01C[0] = (f32) (((f32) random_int(0x0064U) * 0.03) + 2.0);
gObjectList[objectIndex].velocity[1] = (f32) (-0.3 - (f64) (f32) (random_int(0x0032U) * 0.01));