ksys/act/AI: Take const ref for messages

src/Game/AI/AI/aiForkAI.cpp

@@ -101,7 +101,7 @@ bool ForkAI::isFlag4Set() const {
     return true;
 }
 
-bool ForkAI::handleMessage_(ksys::Message* message) {
+bool ForkAI::handleMessage_(const ksys::Message& message) {
     const int num_children = getNumChildren();
 
     bool ok = false;
@@ -115,7 +115,7 @@ bool ForkAI::handleMessage_(ksys::Message* message) {
     return true;
 }
 
-bool ForkAI::handleAck_(ksys::MessageAck* message) {
+bool ForkAI::handleAck_(const ksys::MessageAck& message) {
     const int num_children = getNumChildren();
 
     bool ok = false;

src/Game/AI/AI/aiForkAI.h

@@ -18,8 +18,8 @@ public:
     bool isFailed() const override;
     bool isFinished() const override;
     bool isFlag4Set() const override;
-    bool handleMessage_(ksys::Message* message) override;
-    bool handleAck_(ksys::MessageAck* message) override;
+    bool handleMessage_(const ksys::Message& message) override;
+    bool handleAck_(const ksys::MessageAck& message) override;
     void getCurrentName(sead::BufferedSafeString* name, ActionBase* last) const override;
     void getNames(sead::BufferedSafeString* out) const override;
 };

src/KingSystem/ActorSystem/actAiActionBase.cpp

@@ -225,7 +225,7 @@ Action* ActionBase::getCurrentAction() {
     }
 }
 
-bool ActionBase::handleMessage(Message* message) {
+bool ActionBase::handleMessage(const Message& message) {
     auto* action = this;
     while (!action->handleMessage_(message)) {
         action = action->getCurrentChild();
@@ -235,7 +235,7 @@ bool ActionBase::handleMessage(Message* message) {
     return true;
 }
 
-bool ActionBase::handleAck(MessageAck* message) {
+bool ActionBase::handleAck(const MessageAck& message) {
     auto* action = this;
     while (!action->handleAck_(message)) {
         action = action->getCurrentChild();

src/KingSystem/ActorSystem/actAiActionBase.h

@@ -70,8 +70,8 @@ public:
     bool oneShot(InlineParamPack* params);
 
     Action* getCurrentAction();
-    bool handleMessage(Message* message);
-    bool handleAck(MessageAck* message);
+    bool handleMessage(const Message& message);
+    bool handleAck(const MessageAck& message);
 
     Actor* getActor() const { return mActor; }
     s32 getDefinitionIdx() const { return mDefinitionIdx; }
@@ -94,8 +94,8 @@ protected:
     virtual bool reenter_(ActionBase* other, bool x);
     virtual void leave_() {}
     virtual void loadParams_() {}
-    virtual bool handleMessage_(Message* message) { return false; }
-    virtual bool handleAck_(MessageAck* message) { return false; }
+    virtual bool handleMessage_(const Message& message) { return false; }
+    virtual bool handleAck_(const MessageAck& message) { return false; }
 
 public:
     virtual bool updateForPreDelete() { return true; }

src/KingSystem/ActorSystem/actAiRoot.h

@@ -34,7 +34,7 @@ public:
     bool init_(sead::Heap* heap) override;
     void enter_(InlineParamPack* params) override;
     void leave_() override;
-    bool handleMessage_(Message* message) override;
+    bool handleMessage_(const Message& message) override;
     void calc() override;
 
     const ParamPack& getMapUnitParams() const { return mMapUnitParams; }

tools/ida_ai_rename_action_vfns.py

@@ -24,8 +24,8 @@ _vtable_fn_names = [
     "_ZN5uking6action{}8reenter_EPS2_b",
     "_ZN5uking6action{}6leave_Ev",
     "_ZN5uking6action{}11loadParams_Ev",
-    "_ZN5uking6action{}14handleMessage_EPN4ksys7MessageE",
-    "_ZN5uking6action{}10handleAck_EPN4ksys10MessageAckE",
+    "_ZN5uking6action{}14handleMessage_ERKN4ksys7MessageE",
+    "_ZN5uking6action{}10handleAck_ERKN4ksys10MessageAckE",
     "_ZN5uking6action{}18updateForPreDeleteEv",
     "_ZN5uking6action{}11onPreDeleteEv",
     "_ZN5uking6action{}4calcEv",

tools/ida_ai_rename_ai_vfns.py

@@ -24,8 +24,8 @@ _vtable_fn_names = [
     "_ZN5uking2ai{}8reenter_EPS2_b",
     "_ZN5uking2ai{}6leave_Ev",
     "_ZN5uking2ai{}11loadParams_Ev",
-    "_ZN5uking2ai{}14handleMessage_EPN4ksys7MessageE",
-    "_ZN5uking2ai{}10handleAck_EPN4ksys10MessageAckE",
+    "_ZN5uking2ai{}14handleMessage_ERKN4ksys7MessageE",
+    "_ZN5uking2ai{}10handleAck_ERKN4ksys10MessageAckE",
     "_ZN5uking2ai{}18updateForPreDeleteEv",
     "_ZN5uking2ai{}11onPreDeleteEv",
     "_ZN5uking2ai{}4calcEv",