ksys/map: Fix more matching or equivalency issues

src/KingSystem/Map/mapObject.cpp

@@ -420,7 +420,6 @@ bool Object::x_18() const {
     return !id->sub_7100D30DF8(info, temp);
 }
 
-// NON_MATCHING
 bool Object::setupTargetLinks(Object* src, ObjectLink* link, sead::Heap* heap) {
     if (mNumLinksPointingToMe == 0)
         return false;
@@ -431,11 +430,10 @@ bool Object::setupTargetLinks(Object* src, ObjectLink* link, sead::Heap* heap) {
             return false;
     }
 
-    if (mLinkData->mLinksToSelf.links.isBufferReady())
-        return mLinkData->sub_7100D4EC40(src, link, this);
-
-    if (!mLinkData->allocLinksToSelf(mNumLinksPointingToMe, heap))
-        return false;
+    if (!mLinkData->mLinksToSelf.links.isBufferReady()) {
+        if (!mLinkData->allocLinksToSelf(mNumLinksPointingToMe, heap))
+            return false;
+    }
 
     return mLinkData->sub_7100D4EC40(src, link, this);
 }

src/KingSystem/Map/mapPlacementActors.h

@@ -118,9 +118,10 @@ public:
     PlacementStruct1* mStruct1;
     u8 _e8[0x538 - 0xe8];
     sead::SafeArray<ActorData, 6000> mActorData;
-    // u8 _261b38[0x2a80d0 - 0x261b38];
+    u8 _261b38[0x2a8058 - 0x261b38];
     u32 mActorDataMapSize;
+    u8 _2a805c[0x2a80d0 - 0x2a805c];
 };
-// KSYS_CHECK_SIZE_NX150(PlacementActors, 0x2A80D0);
+KSYS_CHECK_SIZE_NX150(PlacementActors, 0x2A80D0);
 
 }  // namespace ksys::map

src/KingSystem/Map/mapPlacementMgr.cpp

@@ -94,7 +94,7 @@ void PlacementMgr::printDebugInfo() {
         mMassMemoryUsage / 1024, mClusteredMemoryUsage / 1024);
     // Dynamic heap remaining:%dk
     sead::FormatFixedSafeString<128> s4("動的ヒープ残り:%dk",
-                                        int(mDynamicHeap->getFreeSize()) / 1024);
+                                        u32(mDynamicHeap->getFreeSize() / 1024));
 }
 
 void PlacementMgr::incrementCounter() {

src/KingSystem/Map/mapPlacementMgr.h

@@ -77,7 +77,7 @@ public:
     u8 TEMP[0x108];
     sead::Delegate2<PlacementMgr, sead::Thread*, sead::MessageQueue::Element> mThreadParams;
     sead::DelegateThread* mThread;
-    u32 mTraverseResultIdx;
+    int mTraverseResultIdx;
     u16 mRequestedMsg = 0;
 
     sead::Vector3f mCameraPos{};
@@ -106,6 +106,8 @@ public:
     u8 TEMP2[0x70];
 
     u32 _278;
+    sead::Vector3f _27c;
+    u32 _288;
 
     u32 mPreActorNumDone;
     u32 mLoadActorNumTotal;
@@ -117,7 +119,7 @@ public:
     sead::CriticalSection mCS{};
 
     u64 mStartTick;
-    u8 TEMP3[0x5c];
+    u8 TEMP3[0x4c];
 
     sead::TypedBitFlag<MgrFlag, sead::Atomic<u32>> mFlags;
     bool mThreadStarted = false;
@@ -146,5 +148,6 @@ public:
     u8 TEMP5[0x10];
 };
 KSYS_CHECK_SIZE_NX150(PlacementMgr, 0x818);
+static_assert(offsetof(PlacementMgr, mThreadStarted) == 0x688);
 
 }  // namespace ksys::map

src/KingSystem/Map/mapPlacementTree.h

@@ -33,8 +33,8 @@ public:
     u32 _30{};
     f32 _34 = F32Limits::max();
     f32 _38 = F32Limits::max();
-    f32 _3c = F32Limits::max();
-    f32 _40 = F32Limits::max();
+    f32 _3c = F32Limits::lowest();
+    f32 _40 = F32Limits::lowest();
     sead::ReadWriteLock mLock{};
 };