Commit Graph

914 Commits

Author SHA1 Message Date
Léo Lam 9d4dbaf815 Remove dead symlink to diff.py wrapper 2021-08-07 02:36:16 +02:00
Léo Lam 90caa37360 Merge pull request #57 from MonsterDruide1/PlacementGlobal
ksys: Add SystemTimers
2021-08-06 15:16:55 +02:00
MonsterDruide1 6982047134 ksys: Add SystemTimers 2021-08-06 15:14:57 +02:00
Léo Lam 0f6a9d95b5 Remove old diff.py wrapper (superseded by botw-check) and update docs 2021-08-06 01:25:29 +02:00
Léo Lam e37272f14a tools: Add single function check mode
Similar to diff.py wrapper usage, except this will also automatically
update the function CSV with the actual match status.
2021-08-05 22:30:20 +02:00
Léo Lam 15f062a2fc tools: Refactor "check all functions" into its own function
In preparation for adding a single function checking mode.
2021-08-05 22:30:19 +02:00
Léo Lam d1032acc1c tools: Remove dead code 2021-08-05 22:30:19 +02:00
Léo Lam 8bcf98bcaa data: Remove false positives from function list 2021-08-05 16:42:37 +02:00
Léo Lam 40530f01ad ksys/act: Fix BaseProcJobHandlerT actor pointer type in ctor 2021-08-05 00:58:56 +02:00
Léo Lam af2207632e ksys/act: Implement BaseProcJobHandlerT 2021-08-05 00:44:41 +02:00
Léo Lam 6f7547e0db Merge pull request #55 from MonsterDruide1/MusicInfo
ksys/snd: Add MusicInfo and subclasses
2021-08-04 22:18:30 +02:00
MonsterDruide1 b3d32fb766 ksys/snd: Add MusicInfo and subclasses 2021-08-04 22:12:42 +02:00
Léo Lam 5367d0c85a tools: Print a note when a U function actually exists and matches
Also fixes the function call check not being as strict as it should be
and fixes several false positives in the function list
2021-08-04 17:37:12 +02:00
Léo Lam e3887d6835 tools: Add duplicate name checking 2021-08-04 17:28:50 +02:00
Léo Lam 8f8a48a1dc tools: Do not overwrite function names with j_ names either 2021-08-02 15:53:59 +02:00
Léo Lam e28ba16cc0 tools: Do not overwrite function names with nullsub_ and sub_ 2021-08-02 15:49:33 +02:00
Léo Lam 85000e3c7c Merge pull request #45 from MonsterDruide1/SupportBoneResource
Support bone resource
2021-08-02 01:16:59 +02:00
Léo Lam c64fb93fbd ksys/phys: Fix matching issues in SupportBone 2021-08-02 01:11:24 +02:00
MonsterDruide1 90c34d80fe ksys/phys: Add SupportBoneResource
[committer's note: rebased]
2021-08-02 01:11:23 +02:00
Léo Lam e9dfd1327c Merge pull request #54 from AlexApps99/rust
Added support for WIP function status
2021-08-01 12:10:23 +02:00
AlexApps99 3c0648e51f Added support for WIP function status
This brings functionality up to what diff.py uses
2021-08-01 14:19:29 +12:00
Léo Lam 2f5bb47689 data: Fix uking_functions.csv line endings 2021-07-31 22:18:09 +02:00
Léo Lam f571280fee Merge pull request #52 from AlexApps99/master
Ghidra function import script
2021-07-31 12:57:22 +02:00
Léo Lam f901792ea0 Merge pull request #53 from AlexApps99/fix-warn
Fix warning
2021-07-31 12:52:15 +02:00
AlexApps99 2d4a192394 Fix warning 2021-07-31 22:50:29 +12:00
Léo Lam 80bf9236a3 Remove old tools/check.py
RIP check.py 2020-2021
2021-07-31 12:42:14 +02:00
AlexApps99 ca31637da0 Ghidra function import script
Added .gitignore for Ghidra
2021-07-31 22:41:26 +12:00
Léo Lam 71fc0f35e8 Merge pull request #51 from leoetlino/optimized-checker
tools: Add a new, optimized check tool
2021-07-31 12:23:40 +02:00
Léo Lam 6e30bbea32 tools: Add a new, optimized check tool
Reimplements tools/check.py in a faster language (picked Rust to learn
and play with the language and because installing dependencies is way
easier than with C++)

On my machine, a full run takes ~160ms with this new implementation
and 49s (!) with check.py.

The main performance improvements come from not having to use
pyelftools and the Python bindings of Capstone (which are both insanely
slow and perhaps less efficient than they could be). Function checking
is now also performed in parallel rather than sequentially for yet
another significant performance boost.

Other tweaks include editing Capstone and the bindings to avoid
computing expensive things that we don't actually need and avoiding
dynamic memory allocations in hot paths as much as possible.

check.py will be removed after the setup instructions are updated.
2021-07-30 23:52:55 +02:00
Léo Lam 2204f46b0b Remove expected/
The intention was to catch functional regressions in non-matching
functions but this doesn't actually work well because referenced
code and data may have moved after a function was dumped, in which
case the reference checker is unable to verify that function calls
and data references are still correct.

Considering this increases the amount of complexity in the checker
and makes the workflow more complicated for contributors, let's just
drop this mechanism. It isn't worth it.

Putting binary files in the repo is also pretty meh.
2021-07-30 20:06:14 +02:00
Léo Lam ea030c356c Contributing: Mention that functions can be stubbed 2021-07-28 12:20:53 +02:00
Léo Lam 1d4c815fba Merge pull request #50 from AlexApps99/master
CSV formatting improvements
2021-07-27 12:12:56 +02:00
AlexApps99 a68c979491 CSV formatting improvements documentation 2021-07-27 12:58:48 +12:00
AlexApps99 3c336794a4 CSV formatting improvements 2021-07-27 12:44:10 +12:00
Léo Lam d7b2e846b9 Merge pull request #49 from AlexApps99/master
Add #ifdef declarations for NON_MATCHING code
2021-07-26 13:07:34 +02:00
AlexApps99 42807160cf Add #ifdef declarations for NON_MATCHING code 2021-07-26 23:05:19 +12:00
Léo Lam 5bd0cde8bb Merge pull request #48 from AlexApps99/master
Removed invalid functions inside PauseMenuDataMgr::isOverCategoryLimit
2021-07-26 11:55:27 +02:00
AlexApps99 88bcc9eec1 Removed invalid functions inside PauseMenuDataMgr::isOverCategoryLimit 2021-07-26 19:35:51 +12:00
Léo Lam b4f312d14f Fix perf.data entries in .gitignore 2021-07-25 14:35:43 +02:00
Léo Lam 6a87b27ad2 Merge pull request #47 from AlexApps99/master
Improved .gitignore
2021-07-25 11:55:06 +02:00
AlexApps99 b68b1df6f1 Improved .gitignore 2021-07-25 21:34:20 +12:00
Léo Lam 206d7781e5 tools: Use bundled copy of objdump to simplify setup 2021-07-23 18:05:23 +02:00
Léo Lam 0ebf0dac9b Contributing: Add a link to the cheatsheet 2021-07-23 13:00:19 +02:00
Léo Lam 8f8308787d Contributing: Mention Trello board 2021-07-23 12:57:49 +02:00
Léo Lam 3fc83fd051 Streamline project setup by automating NSO conversion (if needed) 2021-07-23 12:40:49 +02:00
Léo Lam fc04f184c8 readme: Add note about cloning the repo in WSL 2021-07-23 00:10:54 +02:00
Léo Lam bc5593aa44 setup: Use subprocess.check_call instead of os.system 2021-07-22 22:07:25 +02:00
Léo Lam d37951ab72 build: Fix local toolchain path 2021-07-22 11:20:55 +02:00
Léo Lam d74354c480 Merge pull request #46 from leoetlino/build-cleanup
Clean up build toolchain (and use musl for libc) and simplify setup
2021-07-22 02:57:32 +02:00
Léo Lam 5d7fa0aede Simplify build setup by adding a setup script 2021-07-22 02:45:01 +02:00