fix aggelos

CMakeModules/find/Findlz4.cmake

@@ -24,7 +24,7 @@ else()
 endif()
 
 if (lz4_FOUND AND NOT TARGET lz4::lz4)
-    if (TARGET LZ4::lz4_shared AND NOT YUZU_STATIC_BUILD)
+    if (TARGET LZ4::lz4_shared)
         add_library(lz4::lz4 ALIAS LZ4::lz4_shared)
     elseif (TARGET LZ4::lz4_static)
         add_library(lz4::lz4 ALIAS LZ4::lz4_static)

src/input_common/drivers/joycon.cpp

@@ -83,20 +83,21 @@ void Joycons::ScanThread(std::stop_token stop_token) {
     constexpr u16 nintendo_vendor_id = 0x057e;
     Common::SetCurrentThreadName("JoyconScanThread");
 
+    auto last_ret = 0u;
     do {
-        SDL_hid_device_info* devs = SDL_hid_enumerate(nintendo_vendor_id, 0x0);
-        SDL_hid_device_info* cur_dev = devs;
-
-        while (cur_dev) {
-            if (IsDeviceNew(cur_dev)) {
-                LOG_DEBUG(Input, "Device Found,type : {:04X} {:04X}", cur_dev->vendor_id,
-                          cur_dev->product_id);
-                RegisterNewDevice(cur_dev);
+        auto ret = SDL_hid_device_change_count();
+        if (last_ret == 0u || last_ret != ret) {
+            last_ret = ret;
+            SDL_hid_device_info* devs = SDL_hid_enumerate(nintendo_vendor_id, 0x0);
+            for (auto* cur_dev = devs; cur_dev; cur_dev = cur_dev->next) {
+                if (IsDeviceNew(cur_dev)) {
+                    LOG_DEBUG(Input, "Device Found,type : {:04X} {:04X}", cur_dev->vendor_id, cur_dev->product_id);
+                    RegisterNewDevice(cur_dev);
+                }
+                cur_dev = cur_dev->next;
             }
-            cur_dev = cur_dev->next;
+            SDL_hid_free_enumeration(devs);
         }
-
-        SDL_hid_free_enumeration(devs);
     } while (Common::StoppableTimedWait(stop_token, std::chrono::seconds{5}));
 }
 

src/shader_recompiler/frontend/ir/breadth_first_search.h

@@ -1,12 +1,8 @@
-// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
-// SPDX-License-Identifier: GPL-3.0-or-later
-
 // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
 // SPDX-License-Identifier: GPL-2.0-or-later
 
 #pragma once
 
-#include <functional>
 #include <optional>
 #include <type_traits>
 #include <queue>
@@ -17,10 +13,9 @@
 
 namespace Shader::IR {
 
-template <typename Pred, typename Resolve = std::identity>
-auto BreadthFirstSearch(Value value, Pred&& pred, Resolve&& resolve = {})
+template <typename Pred>
+auto BreadthFirstSearch(const Value& value, Pred&& pred)
     -> std::invoke_result_t<Pred, const Inst*> {
-    value = resolve(value);
     if (value.IsImmediate()) {
         // Nothing to do with immediates
         return std::nullopt;
@@ -41,7 +36,7 @@ auto BreadthFirstSearch(Value value, Pred&& pred, Resolve&& resolve = {})
         }
         // Visit the right most arguments first
         for (size_t arg = inst->NumArgs(); arg--;) {
-            const Value arg_value{resolve(inst->Arg(arg))};
+            const Value arg_value{inst->Arg(arg)};
             if (arg_value.IsImmediate()) {
                 continue;
             }

src/shader_recompiler/ir_opt/texture_pass.cpp

@@ -31,60 +31,6 @@ struct TextureInst {
 
 using TextureInstVector = boost::container::small_vector<TextureInst, 24>;
 
-const IR::Block* ConditionalHeader(const IR::Block* body) {
-    const auto predecessors{body->ImmPredecessors()};
-    const auto successors{body->ImmSuccessors()};
-    if (predecessors.size() != 1 || successors.size() != 1) return nullptr;
-    const IR::Block* const header{predecessors[0]};
-    const auto targets{header->ImmSuccessors()};
-    if (targets.size() != 2 || targets[0] != body || targets[1] != successors[0] ||
-        targets[1]->ImmPredecessors().size() != 2 || header->empty() ||
-        header->back().GetOpcode() != IR::Opcode::ConditionRef) {
-        return nullptr;
-    }
-    return header;
-}
-
-std::pair<IR::Value, bool> Condition(IR::Value value) {
-    bool negated{};
-    while (const IR::Inst* inst = value.TryInstRecursive()) {
-        if (inst->GetOpcode() == IR::Opcode::LogicalNot) negated = !negated;
-        else if (inst->GetOpcode() != IR::Opcode::ConditionRef) break;
-        value = inst->Arg(0);
-    }
-    return {value.Resolve(), negated};
-}
-
-IR::Value ResolveConditionalPhi(IR::Value value, const IR::Block* block) {
-    if (!value.Resolve().IsPhi() || !(block = ConditionalHeader(block))) return value;
-    const auto [condition, negated]{Condition(block->back().Arg(0))};
-    boost::container::small_vector<const IR::Block*, 16> visited;
-    while (value.Resolve().IsPhi() && std::ranges::find(visited, block) == visited.end()) {
-        visited.push_back(block);
-        const IR::Inst* const phi{value.InstRecursive()};
-        const auto predecessors{block->ImmPredecessors()};
-        if (predecessors.size() == 1) {
-            block = predecessors[0];
-            continue;
-        }
-        if (predecessors.size() != 2 || phi->NumArgs() != 2) break;
-        const IR::Block* body{predecessors[0]};
-        const IR::Block* header{ConditionalHeader(body)};
-        if (header != predecessors[1]) {
-            body = predecessors[1];
-            header = ConditionalHeader(body);
-            if (header != predecessors[0]) break;
-        }
-        const auto [other_condition, other_negated]{Condition(header->back().Arg(0))};
-        if (condition == other_condition && (phi->PhiBlock(0) == header || phi->PhiBlock(0) == body)) {
-            const IR::Block* const incoming{negated == other_negated ? body : header};
-            value = phi->Arg(phi->PhiBlock(0) == incoming ? 0 : 1);
-        }
-        block = header;
-    }
-    return value;
-}
-
 constexpr u32 DESCRIPTOR_SIZE = 8;
 constexpr u32 DESCRIPTOR_SIZE_SHIFT = u32(std::countr_zero(DESCRIPTOR_SIZE));
 constexpr u32 DESCRIPTOR_MAX_COUNT = 1024;
@@ -353,23 +299,23 @@ static inline bool IsTexturePixelFormatIntegerCached(Environment& env,
 }
 
 
-std::optional<ConstBufferAddr> Track(const IR::Value& value, Environment& env, const HostTranslateInfo& host_info, const IR::Block* block);
-static inline std::optional<ConstBufferAddr> TrackCached(const IR::Value& v, Environment& env, const HostTranslateInfo& host_info, const IR::Block* block) {
-    if (const IR::Inst* key = v.TryInstRecursive()) {
+std::optional<ConstBufferAddr> Track(const IR::Value& value, Environment& env, const HostTranslateInfo& host_info);
+static inline std::optional<ConstBufferAddr> TrackCached(const IR::Value& v, Environment& env, const HostTranslateInfo& host_info) {
+    if (const IR::Inst* key = v.InstRecursive()) {
         if (auto it = env.track_cache.find(key); it != env.track_cache.end()) return it->second;
-        auto found = Track(v, env, host_info, block);
+        auto found = Track(v, env, host_info);
         if (found) env.track_cache.emplace(key, *found);
         return found;
     }
-    return Track(v, env, host_info, block);
+    return Track(v, env, host_info);
 }
 
-std::optional<ConstBufferAddr> TryGetConstBuffer(const IR::Inst* inst, Environment& env, const HostTranslateInfo& host_info, const IR::Block* block);
+std::optional<ConstBufferAddr> TryGetConstBuffer(const IR::Inst* inst, Environment& env, const HostTranslateInfo& host_info);
 
-std::optional<ConstBufferAddr> Track(const IR::Value& value, Environment& env, const HostTranslateInfo& host_info, const IR::Block* block) {
-    return IR::BreadthFirstSearch(value, [&env, &host_info, block](const IR::Inst* inst) {
-        return TryGetConstBuffer(inst, env, host_info, block);
-    }, [&](IR::Value operand) { return ResolveConditionalPhi(operand, block); });
+std::optional<ConstBufferAddr> Track(const IR::Value& value, Environment& env, const HostTranslateInfo& host_info) {
+    return IR::BreadthFirstSearch(value, [&env, &host_info](const IR::Inst* inst) {
+        return TryGetConstBuffer(inst, env, host_info);
+    });
 }
 
 std::optional<u32> TryGetConstant(IR::Value& value, Environment& env) {
@@ -393,13 +339,13 @@ std::optional<u32> TryGetConstant(IR::Value& value, Environment& env) {
     return ReadCbufCached(env, index_number, offset_number);
 }
 
-std::optional<ConstBufferAddr> TryGetConstBuffer(const IR::Inst* inst, Environment& env, const HostTranslateInfo& host_info, const IR::Block* block) {
+std::optional<ConstBufferAddr> TryGetConstBuffer(const IR::Inst* inst, Environment& env, const HostTranslateInfo& host_info) {
     switch (inst->GetOpcode()) {
     default:
         return std::nullopt;
     case IR::Opcode::BitwiseOr32: {
-        std::optional lhs{TrackCached(inst->Arg(0), env, host_info, block)};
-        std::optional rhs{TrackCached(inst->Arg(1), env, host_info, block)};
+        std::optional lhs{TrackCached(inst->Arg(0), env, host_info)};
+        std::optional rhs{TrackCached(inst->Arg(1), env, host_info)};
         if (!lhs || !rhs) {
             return std::nullopt;
         }
@@ -429,7 +375,7 @@ std::optional<ConstBufferAddr> TryGetConstBuffer(const IR::Inst* inst, Environme
         if (!shift.IsImmediate()) {
             return std::nullopt;
         }
-        std::optional lhs{TrackCached(inst->Arg(0), env, host_info, block)};
+        std::optional lhs{TrackCached(inst->Arg(0), env, host_info)};
         if (lhs) {
             lhs->shift_left = shift.U32();
         }
@@ -457,7 +403,7 @@ std::optional<ConstBufferAddr> TryGetConstBuffer(const IR::Inst* inst, Environme
                 return std::nullopt;
             } while (false);
         }
-        std::optional lhs{TrackCached(op1, env, host_info, block)};
+        std::optional lhs{TrackCached(op1, env, host_info)};
         if (lhs) {
             lhs->shift_left = static_cast<u32>(std::countr_zero(op2.U32()));
         }
@@ -523,7 +469,7 @@ std::optional<ConstBufferAddr> TryGetConstBuffer(const IR::Inst* inst, Environme
 TextureInst MakeInst(Environment& env, IR::Block* block, IR::Inst& inst, const HostTranslateInfo& host_info) {
     ConstBufferAddr addr;
     if (IsBindless(inst)) {
-        const std::optional<ConstBufferAddr> track_addr{TrackCached(inst.Arg(0), env, host_info, block)};
+        const std::optional<ConstBufferAddr> track_addr{TrackCached(inst.Arg(0), env, host_info)};
 
         if (!track_addr) {
             throw NotImplementedException("Failed to track bindless texture constant buffer");
@@ -725,7 +671,6 @@ void TexturePass(Environment& env, IR::Program& program, const HostTranslateInfo
     env.track_cache.clear();
     TextureInstVector to_replace;
     for (IR::Block* const block : program.post_order_blocks) {
-        env.track_cache.clear();
         for (IR::Inst& inst : block->Instructions()) {
             if (!IsTextureInstruction(inst)) {
                 continue;

src/video_core/renderer_vulkan/vk_rasterizer.cpp

@@ -82,7 +82,12 @@ VkViewport GetViewportState(const Device& device, const Maxwell& regs, size_t in
 
     if (lower_left) {
         // Flip by surface clip height
-        y += conv(static_cast<f32>(regs.surface_clip.height));
+        const float clip_height = conv(static_cast<f32>(regs.surface_clip.height));
+        if (src.scale_y < 0.0f && y >= clip_height) {
+            y = clip_height - y;
+        } else {
+            y += clip_height;
+        }
         height = -height;
     }