decomp: target-part (#688)

* decomp: finish decompiling `target-part` waiting on label issue

Hitting exception at data_decompile.cppL182

* fixed pointer labels, but blocked by :inline fields from static data

* decomp: finish `target-part`

* address feedback

.vscode/settings.json

@@ -46,6 +46,16 @@
         }
       ]
     },
+    "( \\d+\\(sp\\))": {
+      "filterFileRegex": ".*ir2\\.asm",
+      "decorations": [
+        {
+          "overviewRulerColor": "transparent",
+          "color": "#00ff08",
+          "fontWeight": "bold"
+        }
+      ]
+    },
     "(at op \\d+)": {
       "filterFileRegex": ".*ir2\\.asm",
       "decorations": [

decompiler/config/all-types.gc

@@ -16399,7 +16399,7 @@
 
 ;;(define-extern *particles-flag* object) ;; unknown type
 (define-extern *sp-particle-system-2d* sparticle-system)
-(define-extern *sp-particle-system-3d* sparticle-system) ;; unknown type
+(define-extern *sp-particle-system-3d* sparticle-system)
 
 
 ;; ----------------------
@@ -18914,7 +18914,7 @@
 ;; - Functions
 
 (define-extern line-in-view-frustum? function)
-(define-extern process-drawable-random-point! function)
+(define-extern process-drawable-random-point! (function process-drawable vector vector))
 (define-extern process-drawable-from-entity! (function process-drawable res-lump none))
 (define-extern cam-launcher-long-joystick function)
 (define-extern hide-hud-quick (function none))
@@ -19104,12 +19104,12 @@
 
 ;; - Functions
 
-(define-extern birth-func-copy-target-y-rot function)
-(define-extern birth-func-ground-orient function)
-(define-extern birth-func-target-orient function)
-(define-extern birth-func-vector-orient function)
-(define-extern part-tracker-track-target-joint function)
-(define-extern process-drawable-burn-effect function)
+(define-extern birth-func-copy-target-y-rot (function int sparticle-cpuinfo sparticle-launchinfo none))
+(define-extern birth-func-ground-orient (function int sparticle-cpuinfo sparticle-launchinfo none))
+(define-extern birth-func-target-orient (function int sparticle-cpuinfo sparticle-launchinfo none))
+(define-extern birth-func-vector-orient (function int sparticle-cpuinfo sparticle-launchinfo none))
+(define-extern part-tracker-track-target-joint (function int sparticle-cpuinfo sparticle-launchinfo none)) ;; 3rd arg could also be a vector
+(define-extern process-drawable-burn-effect (function int rgbaf :behavior target))
 
 
 ;; ----------------------

decompiler/config/jak1_ntsc_black_label/label_types.jsonc

@@ -443,6 +443,15 @@
     ["L71", "vector"]
   ],
 
+  "target-part": [
+    ["L336", "float", true],
+    ["L337", "float", true],
+    ["L338", "float", true],
+    ["L339", "float", true],
+    ["L340", "float", true],
+    ["L341", "uint64", true]
+  ],
+
   // please do not add things after this entry! git is dumb.
   "object-file-that-doesnt-actually-exist-and-i-just-put-this-here-to-prevent-merge-conflicts-with-this-file": []
 }

decompiler/config/jak1_ntsc_black_label/stack_structures.jsonc

@@ -1445,5 +1445,40 @@
     [16, "vector"]
   ],
 
+  "birth-func-copy-target-y-rot": [
+    [16, "matrix"]
+  ],
+
+  "birth-func-ground-orient": [
+    [16, "vector"],
+    [32, "bone"],
+    [128, "vector"],
+    [144, "quaternion"],
+    [160, "quaternion"]
+  ],
+
+  "birth-func-target-orient": [
+    [32, "vector"],
+    [48, "vector"], // unused
+    [64, "quaternion"],
+    [80, "quaternion"]
+  ],
+
+  "birth-func-vector-orient": [
+    [16, "vector"],
+    [32, "vector"], // unused
+    [48, "quaternion"]
+  ],
+
+  "part-tracker-track-target-joint": [
+    [16, "vector"]
+  ],
+
+  "process-drawable-burn-effect": [
+    [16, "rgbaf"],
+    [32, "rgbaf"],
+    [48, "vector"]
+  ],
+
   "placeholder-do-not-add-below!": []
 }

decompiler/config/jak1_ntsc_black_label/type_casts.jsonc

@@ -2529,6 +2529,21 @@
   "cam-master-effect": [
     [[0, 999], "s6", "camera-master"]
   ],
+  
+  "birth-func-vector-orient": [
+    [[7, 24], "s3", "sprite-vec-data-2d"]
+  ],
+
+  "process-drawable-burn-effect": [
+    [28, "a0", "process-drawable"],
+    [105, "v1", "process-drawable"],
+    [49, "a0", "process-drawable"],
+    [64, "a0", "process-drawable"]
+  ],
+
+  "process-drawable-random-point!": [
+    [[28, 40], "s4", "collide-shape"]
+  ],
 
   "(anon-function 0 dark-eco-pool)": [
     [2, "v1", "state"]

goal_src/engine/game/generic-obs.gc

@@ -22,3 +22,5 @@
 (define-extern manipy-init (function trsqv vector entity skeleton-group none)) ;; TODO - not confirmed yet
 ;; TODO - for projectiles | dark-eco-pool
 (define-extern part-tracker-init (function sparticle-launch-group int basic basic basic vector none)) ;; TODO - not confirmed
+;; TODO - for target-part
+(define-extern process-drawable-random-point! (function process-drawable vector vector))