mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-09-10 04:22:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

goalc: allow symbol re-definitions if the flag is enabled

Browse Source
This commit is contained in:
Tyler Wilding
2024-06-02 12:53:51 -04:00
parent ae27ef11e4
commit 690d7016bf
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goalc/compiler/compilation/Define.cpp
+12 -5
View File
@@ -66,15 +66,22 @@ Val* Compiler::compile_define(const goos::Object& form, const goos::Object& rest
throw_compiler_error(form, "Cannot define {} because it cannot be set.", sym_val->print());
}
auto explicit_no_typecheck = false;
if (args.has_named("no-typecheck")) {
explicit_no_typecheck = get_true_or_false(form, args.named.at("no-typecheck"));
}
auto existing_type = m_symbol_types.lookup(sym.as_symbol());
if (!existing_type) {
m_symbol_types.set(sym.as_symbol(), in_gpr->type());
} else {
bool do_typecheck = true;
if (args.has_named("no-typecheck")) {
do_typecheck = !get_true_or_false(form, args.named.at("no-typecheck"));
}
if (do_typecheck) {
if (!explicit_no_typecheck && m_repl->repl_config.permissive_redefinitions) {
// Permissive redefinitions are allowed
if (in_gpr->type() != *existing_type) {
lg::warn("Redefining {}", sym.as_symbol().name_ptr);
}
m_symbol_types.set(sym.as_symbol(), in_gpr->type());
} else if (!explicit_no_typecheck) {
// Type check is required
typecheck(form, *existing_type, in_gpr->type(),
fmt::format("define on existing symbol {}", sym.as_symbol().name_ptr));
}