mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-07-07 14:13:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

decomp/lsp: Differentiate warnings from likely/definite errors (#1725)

Browse Source 
* decomp: differentiate potential false positive warnings from likely/certain failures

* lsp: handle IR2 errors

* decomp: downgrade an expr building warning as often expressions build fine

* tests: update reference tests since comments aren't ignored

* decomp: simplify warnings interface

* tests: update ref tests
This commit is contained in:
Tyler Wilding
2022-08-06 11:52:36 -04:00
committed by GitHub
parent f1e2cee91d
commit b3e77c673f
270 changed files with 1608 additions and 1615 deletions
Download Patch File Download Diff File Expand all files Collapse all files
decompiler/IR2/FormStack.cpp
+1 -1
View File
@@ -397,7 +397,7 @@ std::optional<RegisterAccess> rewrite_to_get_var(std::vector<FormElement*>& defa
auto cast = last_op_as_set->required_cast(env);
if (cast && cast == TypeSpec("none")) {
env.func->warnings.general_warning(
env.func->warnings.warning(
"rewrite_to_get_var got a none typed variable. Is there unreachable code? [OP: {}]",
last_op_as_set->dst().idx());
cast = std::nullopt;