mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-08-21 23:00:45 -04:00
Code Issues Packages Projects Releases Wiki Activity

decomp/lsp: Differentiate warnings from likely/definite errors (#1725)

Browse Source 
* decomp: differentiate potential false positive warnings from likely/certain failures

* lsp: handle IR2 errors

* decomp: downgrade an expr building warning as often expressions build fine

* tests: update reference tests since comments aren't ignored

* decomp: simplify warnings interface

* tests: update ref tests
This commit is contained in:
Tyler Wilding
2022-08-06 11:52:36 -04:00
committed by GitHub
parent f1e2cee91d
commit b3e77c673f
270 changed files with 1608 additions and 1615 deletions
Download Patch File Download Diff File Expand all files Collapse all files
decompiler/analysis/expression_build.cpp
+2 -2
View File
@@ -158,13 +158,13 @@ bool convert_to_expressions(
"Function {} has a return type of none, but the expression builder found a return "
"statement.",
f.name());
f.warnings.expression_build_warning(warn);
f.warnings.warning(warn);
lg::warn(warn);
}
}
} catch (std::exception& e) {
f.warnings.expression_build_warning("In {}: {}", f.name(), e.what());
f.warnings.error("Expression building failed: In {}: {}", f.name(), e.what());
lg::warn("In {}: {}", f.name(), e.what());
return false;
}