mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-07-08 06:30:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

[decompiler] Fix stores of constant enum/bitfield (#1011)

Browse Source 
This fixes an issue where storing a constant integer in a location with
a type that is both an enum/bitfield and a child of signed integer. The
logic for dropping casts for signed integer constants was accidentally
being applied to any child of `integer`.
This commit is contained in:
water111
2021-12-13 19:38:21 -05:00
committed by GitHub
parent 698d99df13
commit c28c47b4c8
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
decompiler/IR2/AtomicOpForm.cpp
+4 -3
View File
@@ -180,9 +180,10 @@ std::optional<TypeSpec> get_typecast_for_atom(const SimpleAtom& atom,
} break;
case SimpleAtom::Kind::INTEGER_CONSTANT: {
std::optional<TypeSpec> cast_for_set, cast_for_define;
bool sym_int_or_uint = env.dts->ts.tc(TypeSpec("integer"), expected_type);
bool sym_uint = env.dts->ts.tc(TypeSpec("uinteger"), expected_type);
bool sym_int = sym_int_or_uint && !sym_uint;
const auto& type_name = expected_type.base_type();
bool sym_int = (type_name == "int8") || (type_name == "int16") || (type_name == "int32") ||
(type_name == "int64") || (type_name == "int") || (type_name == "integer") ||
(type_name == "seconds");
if (sym_int) {
// do nothing for set.