mirror/jak-project
1
0
Fork 0
mirror of https://github.com/open-goal/jak-project synced 2026-07-11 15:28:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

lsp: revert unnamed variable labelling (#3381)

Browse Source 
This didn't really pan out as I hoped since files can have thousands of
these and there is a limit to how many diagnostics are shown (starting
from the top of the file). This also may have caused the recent
instability in the LSP, disabling this i wasn't able to reproduce an LSP
crash cycling through 50-100 files.
This commit is contained in:
Tyler Wilding
2024-02-19 21:17:20 -05:00
committed by GitHub
parent c4d3027d04
commit ee2880b985
1 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lsp/state/workspace.cpp
-20
View File
@@ -408,8 +408,6 @@ void WorkspaceIRFile::find_function_symbol(const uint32_t line_num_zero_based,
void WorkspaceIRFile::identify_diagnostics(const uint32_t line_num_zero_based,
const std::string& line,
const bool in_opengoal_block) {
std::regex unnamed_variables_regex(
"(?:(?:arg\\d+)|(?:f\\d+|at|v[0-1]|a[0-3]|t[0-9]|s[0-7]|k[0-1]|gp|sp|sv|fp|ra)\\-\\d+)");
std::regex info_regex(";; INFO: (.*)");
std::regex warn_regex(";; WARN: (.*)");
std::regex error_regex(";; ERROR: (.*)");
@@ -417,24 +415,6 @@ void WorkspaceIRFile::identify_diagnostics(const uint32_t line_num_zero_based,
std::smatch warn_matches;
std::smatch error_matches;
if (in_opengoal_block) {
for (auto regex_iterator =
std::sregex_iterator(line.begin(), line.end(), unnamed_variables_regex);
regex_iterator != std::sregex_iterator(); ++regex_iterator) {
std::smatch match = *regex_iterator;
LSPSpec::Diagnostic new_diag;
new_diag.m_severity = LSPSpec::DiagnosticSeverity::Warning;
new_diag.m_message = fmt::format("{} - Unnamed variable", match.str());
LSPSpec::Range diag_range;
diag_range.m_start = {line_num_zero_based, (u32)match.position(0)};
diag_range.m_end = {line_num_zero_based,
diag_range.m_start.m_character + (u32)match.length()};
new_diag.m_range = diag_range;
new_diag.m_source = "OpenGOAL LSP";
m_diagnostics.push_back(new_diag);
}
}
LSPSpec::Range diag_range;
diag_range.m_start = {line_num_zero_based, 0};
diag_range.m_end = {line_num_zero_based, (uint32_t)line.length() - 1};