mirror of
https://github.com/open-goal/jak-project
synced 2026-09-12 20:56:09 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
54 lines
2.0 KiB
Markdown
Vendored
Generated
54 lines
2.0 KiB
Markdown
Vendored
Generated
<!--
|
|
Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
|
|
SPDX-License-Identifier: curl
|
|
-->
|
|
|
|
# Keeping Time
|
|
|
|
Transfers need the current time to handle timeouts and keep a record of
|
|
events. The current time function is `curlx_now()` and it uses a **monotonic**
|
|
clock on most platforms. This ensures that time only ever increases (the
|
|
timestamps it gives are however not the "real" world clock).
|
|
|
|
## Initial Approach (now historic)
|
|
|
|
The loop processing functions called `curlx_now()` at the beginning and then
|
|
passed a pointer to the `struct curltime now` to functions to save them the
|
|
calls. Passing this pointer down to all functions possibly involved was not
|
|
done as this pollutes the internal APIs.
|
|
|
|
Some functions continued to call `curlx_now()` on their own while others used
|
|
the passed pointer *to a timestamp in the past*. This led to a transfer
|
|
experiencing *jumps* in time, reversing cause and effect. On fast systems,
|
|
this was mostly not noticeable. On slow machines or in CI, this led to rare
|
|
and annoying test failures.
|
|
|
|
(Especially when we added assertions that the reported "timeline" of a
|
|
transfer was in the correct order: *queue -> nameloopup -> connect ->
|
|
appconnect ->...*.)
|
|
|
|
## Revised Approach
|
|
|
|
The strategy of handling transfer's time is now:
|
|
|
|
* Keep a "now" timestamp in the multi handle. Keep a fallback "now" timestamp
|
|
in the easy handle.
|
|
* Always use `Curl_pgrs_now(data)` to get the current time of a transfer.
|
|
* Do not use `curlx_now()` directly for transfer handling (exceptions apply
|
|
for loops).
|
|
|
|
This has the following advantages:
|
|
|
|
* No need to pass a `struct curltime` around or pass a pointer to an outdated
|
|
timestamp to other functions.
|
|
* No need to calculate the exact `now` until it is really used.
|
|
* Passing a `const` pointer is better than struct passing. Updating and
|
|
passing a pointer to the same memory location for all transfers is even
|
|
better.
|
|
|
|
Caveats:
|
|
|
|
* do not store the pointer returned by `Curl_pgrs_now(data)` anywhere that
|
|
outlives the current code invocation.
|