mirror of
https://github.com/open-goal/jak-project
synced 2026-09-10 12:25:21 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
66 lines
1.9 KiB
Markdown
Vendored
Generated
66 lines
1.9 KiB
Markdown
Vendored
Generated
---
|
|
c: Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
SPDX-License-Identifier: curl
|
|
Title: libcurl-share
|
|
Section: 3
|
|
Source: libcurl
|
|
See-also:
|
|
- curl_share_cleanup (3)
|
|
- curl_share_init (3)
|
|
- curl_share_setopt (3)
|
|
- libcurl-easy (3)
|
|
- libcurl-errors (3)
|
|
- libcurl-multi (3)
|
|
Protocol:
|
|
- All
|
|
Added-in: n/a
|
|
---
|
|
|
|
# NAME
|
|
|
|
libcurl-share - how to use the share interface
|
|
|
|
# DESCRIPTION
|
|
|
|
This is an overview on how to use the libcurl share interface in your C
|
|
programs. There are specific man pages for each function mentioned in
|
|
here.
|
|
|
|
All functions in the share interface are prefixed with curl_share.
|
|
|
|
# OBJECTIVES
|
|
|
|
The share interface was added to enable sharing of data between curl handles.
|
|
|
|
# ONE SET OF DATA - MANY TRANSFERS
|
|
|
|
You can have multiple easy handles share data between them. Have them update
|
|
and use the **same** cookie database, DNS cache, TLS session cache and/or
|
|
connection cache. This way, each single transfer takes advantage from data
|
|
updates made by the other transfer(s).
|
|
|
|
# SHARE OBJECT
|
|
|
|
You create a shared object with curl_share_init(3). It returns a handle
|
|
for a newly created one.
|
|
|
|
You tell the shared object what data you want it to share by using
|
|
curl_share_setopt(3).
|
|
|
|
Since you can use this share from multiple threads, and libcurl has no
|
|
internal thread synchronization, you must provide mutex callbacks if you are
|
|
using this multi-threaded. You set lock and unlock functions with
|
|
curl_share_setopt(3) too.
|
|
|
|
Then, you make an easy handle to use this share, you set the
|
|
CURLOPT_SHARE(3) option with curl_easy_setopt(3), and pass in
|
|
share handle. You can make any number of easy handles share the same share
|
|
handle.
|
|
|
|
To make an easy handle stop using that particular share, you set
|
|
CURLOPT_SHARE(3) to NULL for that easy handle. To make a handle stop
|
|
sharing a particular data, you can CURLSHOPT_UNSHARE(3) it.
|
|
|
|
When you are done using the share, make sure that no easy handle is still using
|
|
it, and call curl_share_cleanup(3) on the handle.
|