mirror of
https://github.com/open-goal/jak-project
synced 2026-09-02 18:12:50 -04:00
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
152 lines
4.2 KiB
Markdown
Vendored
Generated
152 lines
4.2 KiB
Markdown
Vendored
Generated
<!--
|
|
Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
|
|
SPDX-License-Identifier: curl
|
|
-->
|
|
|
|
# `hash`
|
|
|
|
#include "hash.h"
|
|
|
|
This is the internal module for doing hash tables. A hash table uses a hash
|
|
function to compute an index. On each index there is a separate linked list of
|
|
entries.
|
|
|
|
Create a hash table. Add items. Retrieve items. Remove items. Destroy table.
|
|
|
|
## `Curl_hash_init`
|
|
|
|
~~~c
|
|
void Curl_hash_init(struct Curl_hash *h,
|
|
size_t slots,
|
|
hash_function hfunc,
|
|
comp_function comparator,
|
|
Curl_hash_dtor dtor);
|
|
~~~
|
|
|
|
The call initializes a `struct Curl_hash`.
|
|
|
|
- `slots` is the number of entries to create in the hash table. Larger is
|
|
better (faster lookups) but also uses more memory.
|
|
- `hfunc` is a function pointer to a function that returns a `size_t` value as
|
|
a checksum for an entry in this hash table. Ideally, it returns a unique
|
|
value for every entry ever added to the hash table, but hash collisions are
|
|
handled.
|
|
- `comparator` is a function pointer to a function that compares two hash
|
|
table entries. It should return non-zero if the compared items are
|
|
identical.
|
|
- `dtor` is a function pointer to a destructor called when an entry is removed
|
|
from the table
|
|
|
|
## `Curl_hash_add`
|
|
|
|
~~~c
|
|
void *
|
|
Curl_hash_add(struct Curl_hash *h, void *key, size_t key_len, void *p)
|
|
~~~
|
|
|
|
This call adds an entry to the hash. `key` points to the hash key and
|
|
`key_len` is the length of the hash key. `p` is a custom pointer.
|
|
|
|
If there already was a match in the hash, that data is replaced with this new
|
|
entry.
|
|
|
|
This function also lazily allocates the table if needed, as it is not done in
|
|
the `Curl_hash_init` function.
|
|
|
|
Returns NULL on error, otherwise it returns a pointer to `p`.
|
|
|
|
## `Curl_hash_add2`
|
|
|
|
~~~c
|
|
void *Curl_hash_add2(struct Curl_hash *h, void *key, size_t key_len, void *p,
|
|
Curl_hash_elem_dtor dtor)
|
|
~~~
|
|
|
|
This works like `Curl_hash_add` but has an extra argument: `dtor`, which is a
|
|
destructor call for this specific entry. When this entry is removed, this
|
|
function is called instead of the function stored for the whole hash table.
|
|
|
|
## `Curl_hash_delete`
|
|
|
|
~~~c
|
|
int Curl_hash_delete(struct Curl_hash *h, void *key, size_t key_len);
|
|
~~~
|
|
|
|
This function removes an entry from the hash table. If successful, it returns
|
|
zero. If the entry was not found, it returns 1.
|
|
|
|
## `Curl_hash_pick`
|
|
|
|
~~~c
|
|
void *Curl_hash_pick(struct Curl_hash *h, void *key, size_t key_len);
|
|
~~~
|
|
|
|
If there is an entry in the hash that matches the given `key` with size of
|
|
`key_len`, that its custom pointer is returned. The pointer that was called
|
|
`p` when the entry was added.
|
|
|
|
It returns NULL if there is no matching entry in the hash.
|
|
|
|
## `Curl_hash_destroy`
|
|
|
|
~~~c
|
|
void Curl_hash_destroy(struct Curl_hash *h);
|
|
~~~
|
|
|
|
This function destroys a hash and cleanups up all its related data. Calling it
|
|
multiple times is fine.
|
|
|
|
## `Curl_hash_clean`
|
|
|
|
~~~c
|
|
void Curl_hash_clean(struct Curl_hash *h);
|
|
~~~
|
|
|
|
This function removes all the entries in the given hash.
|
|
|
|
## `Curl_hash_clean_with_criterium`
|
|
|
|
~~~c
|
|
void
|
|
Curl_hash_clean_with_criterium(struct Curl_hash *h, void *user,
|
|
int (*comp)(void *, void *))
|
|
~~~
|
|
|
|
This function removes all the entries in the given hash that matches the
|
|
criterion. The provided `comp` function determines if the criteria is met by
|
|
returning non-zero.
|
|
|
|
## `Curl_hash_count`
|
|
|
|
~~~c
|
|
size_t Curl_hash_count(struct Curl_hash *h)
|
|
~~~
|
|
|
|
Returns the number of entries stored in the hash.
|
|
|
|
## `Curl_hash_start_iterate`
|
|
|
|
~~~c
|
|
void Curl_hash_start_iterate(struct Curl_hash *hash,
|
|
struct Curl_hash_iterator *iter):
|
|
~~~
|
|
|
|
This function initializes a `struct Curl_hash_iterator` that `iter` points to.
|
|
It can then be used to iterate over all the entries in the hash.
|
|
|
|
## `Curl_hash_next_element`
|
|
|
|
~~~c
|
|
struct Curl_hash_element *
|
|
Curl_hash_next_element(struct Curl_hash_iterator *iter);
|
|
~~~
|
|
|
|
Given the iterator `iter`, this function returns a pointer to the next hash
|
|
entry if there is one, or NULL if there is no more entries.
|
|
|
|
Called repeatedly, it iterates over all the entries in the hash table.
|
|
|
|
Note: it only guarantees functionality if the hash table remains untouched
|
|
during its iteration.
|