mirror of
https://github.com/open-goal/jak-project
synced 2026-09-01 01:52:03 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
126 lines
3.5 KiB
Markdown
Vendored
Generated
126 lines
3.5 KiB
Markdown
Vendored
Generated
---
|
|
c: Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
SPDX-License-Identifier: curl
|
|
Title: mk-ca-bundle
|
|
Section: 1
|
|
Source: mk-ca-bundle
|
|
See-also:
|
|
- curl (1)
|
|
Added-in: n/a
|
|
---
|
|
|
|
# NAME
|
|
|
|
mk-ca-bundle - convert Mozilla's certificate bundle to PEM format
|
|
|
|
# SYNOPSIS
|
|
|
|
mk-ca-bundle [options] [output]
|
|
|
|
# DESCRIPTION
|
|
|
|
This tool downloads the *certdata.txt* file from Mozilla's source tree over
|
|
HTTPS, then parses it and extracts the included certificates into PEM format.
|
|
By default, only CA root certificates trusted to issue SSL server
|
|
authentication certificates are extracted. These are then processed with the
|
|
OpenSSL command line tool to produce the final ca-bundle output file.
|
|
|
|
The default *output* name is **ca-bundle.crt**. By setting it to '-' (a single
|
|
dash) you get the output sent to STDOUT instead of a file.
|
|
|
|
The PEM format this scripts uses for output makes the result readily available
|
|
for use by OpenSSL or GnuTLS powered applications, such as curl and others.
|
|
|
|
# OPTIONS
|
|
|
|
The following options are supported:
|
|
|
|
## -b
|
|
|
|
backup an existing version of *output*
|
|
|
|
## -d [name]
|
|
|
|
specify which Mozilla tree to pull *certdata.txt* from (or a custom URL).
|
|
Valid names are: **aurora**, **beta**, **central**, **Mozilla**, **nss**,
|
|
**release** (default). They are shortcuts for which source tree to get the
|
|
certificate data from.
|
|
|
|
## -f
|
|
|
|
force rebuild even if *certdata.txt* is current (Added in version 1.17)
|
|
|
|
## -i
|
|
|
|
print version info about used modules
|
|
|
|
## -k
|
|
|
|
Allow insecure data transfer. By default (since 1.27) this command fails if
|
|
the HTTPS transfer fails. This overrides that decision (and opens for
|
|
man-in-the-middle attacks).
|
|
|
|
## -l
|
|
|
|
print license info about *certdata.txt*
|
|
|
|
## -m
|
|
|
|
(Added in 1.26) Include meta data comments in the output. The meta data is
|
|
specific information about each certificate that is stored in the original
|
|
file as comments and using this option makes those comments get passed on to
|
|
the output file. The meta data is not parsed in any way by mk-ca-bundle.
|
|
|
|
## -n
|
|
|
|
Do not download *certdata.txt* - use the existing.
|
|
|
|
## -p [purposes]:[levels]
|
|
|
|
list of Mozilla trust purposes and levels for certificates to include in
|
|
output. Takes the form of a comma separated list of purposes, a colon, and a
|
|
comma separated list of levels. The default is to include all certificates
|
|
trusted to issue SSL Server certificates (*SERVER_AUTH:TRUSTED_DELEGATOR*).
|
|
|
|
Valid purposes are: **ALL**, **DIGITAL_SIGNATURE**, **NON_REPUDIATION**,
|
|
**KEY_ENCIPHERMENT**, **DATA_ENCIPHERMENT**, **KEY_AGREEMENT**,
|
|
**KEY_CERT_SIGN**, **CRL_SIGN**, **SERVER_AUTH** (default), **CLIENT_AUTH**,
|
|
**CODE_SIGNING**, **EMAIL_PROTECTION**, **IPSEC_END_SYSTEM**,
|
|
**IPSEC_TUNNEL**, **IPSEC_USER**, **TIME_STAMPING**, **STEP_UP_APPROVED**
|
|
|
|
Valid trust levels are: **ALL**, **TRUSTED_DELEGATOR** (default), **NOT_TRUSTED**,
|
|
**MUST_VERIFY_TRUST**, **TRUSTED**
|
|
|
|
## -q
|
|
|
|
be really quiet (no progress output at all)
|
|
|
|
## -t
|
|
|
|
include plain text listing of certificates
|
|
|
|
## -s [algorithms]
|
|
|
|
A comma separated list of signature algorithms with which to hash/fingerprint
|
|
each certificate and output when run in plain text mode.
|
|
|
|
Valid algorithms are:
|
|
ALL, NONE, MD5 (default), SHA1, SHA256, SHA384, SHA512
|
|
|
|
## -u
|
|
|
|
unlink (remove) *certdata.txt* after processing
|
|
|
|
## -v
|
|
|
|
be verbose and print out processed certificate authorities
|
|
|
|
# EXIT STATUS
|
|
|
|
Returns 0 on success. Returns 1 if it fails to download data.
|
|
|
|
# FILE FORMAT
|
|
|
|
The file format used by Mozilla for this trust information is [documented
|
|
here](https://p11-glue.github.io/p11-glue/doc/storing-trust-policy/storing-trust-existing.html).
|