mirror of
https://github.com/open-goal/jak-project
synced 2026-09-02 02:02:51 -04:00
Alexander J. Semenuk
5d5e35fb9b
## Problem Windows builds break with a current local toolchain (Scoop LLVM 22.1.8, CMake 4.4.0, VS 2026), in two independent ways: 1. The build stops at curl's deliberate guard: `#error "no non-blocking method was found/used/set"` in `third-party/curl/lib/nonblock.c`. 2. From the second configure onward, `cmake --build` re-runs CMake in an endless loop (observed 42 consecutive reconfigure cycles in a single build). Likely the same mechanism behind the "endlessly building" VS 2026 note in `docs/setup/dev/vs.md`. ## Root cause 1. `third-party/curl/CMake/CurlTests.c` passes `int *` to `ioctlsocket()`, whose third parameter is `u_long *`. Clang 22 promotes `-Wincompatible-pointer-types` to a hard error in C, so the `HAVE_IOCTLSOCKET_FIONBIO` try_compile silently fails and `curl_config.h` never defines it. Upstream CI does not see this because the windows-2022 runner image ships an older LLVM. GCC 14 promotes the same warning to a hard error, which is very likely the `CurlTests.c.obj` failure reported from MSYS2 in open-goal/jak-project#3551. Upstream curl hit the identical problem with GCC 14 and fixed the probe in curl 8.8.0 (curl/curl#13578). 2. The root CMakeLists copies the build tree's `compile_commands.json` into `<src>/build/` for clangd using `configure_file()`, which registers its input as a configure dependency. CMake rewrites `compile_commands.json` late in every generation, after `CTestTestfile.cmake` and `cmake_install.cmake` (outputs of the same Ninja regen rule), so once the dependency is registered the rule is deterministically dirty and every `ninja` invocation re-runs CMake. A pristine first configure is safe (the file does not exist yet, so the `if(EXISTS ...)` guard skips the copy), which is why the loop looks machine- or IDE-specific. ## Fix 1. Per review, re-vendor `third-party/curl` at the `curl-8_21_0` tag (previously `curl-8_3_0`), which carries the upstream probe fix plus two years of upstream development; `vendor.yaml` updated to match. Adjustments the version jump forced: - curl 8.15 removed the native macOS Secure Transport backend (`CURL_USE_SECTRANSP`), so macOS now builds curl against OpenSSL like Linux. The two macOS workflows install Homebrew `openssl@3` and export `OPENSSL_ROOT_DIR` (keg-only), and the macOS setup docs gained the same two lines. - `CURL_BROTLI` / `CURL_ZSTD` switched to AUTO-detection in curl 8.10; pinned OFF to keep the previous no-compression behavior and avoid silently linking whatever the CI images happen to have. - curl's new top-level `BUILD_EXAMPLES` cache option (default ON) leaked into discord-rpc's identically named option and broke configure at a nonexistent `examples/send-presence` directory; pinned OFF ahead of the third-party subdirectories. The diff is dominated by the mechanical tag-tree swap under `third-party/curl` (linguist-vendored, collapsed in review). The hand-written changes are `CMakeLists.txt`, the two macOS workflows, `docs/setup/system/macos.md`, and `vendor.yaml`. 2. Swap `configure_file()` for `file(COPY ...)`: the same clangd copy with no configure dependency registered. (`file(COPY_FILE ... ONLY_IF_DIFFERENT)` would be cleaner still but requires CMake 3.21, above the declared `cmake_minimum_required(VERSION 3.10)`.) ## Test plan - [x] Fresh `cmake --preset Release-windows-clang` (LLVM 22, no cache seeding) completes and logs `Enabled SSL backends: Schannel`; the FIONBIO probe passes without the previous `#error` - [x] Full Windows Release build from scratch in the branch worktree (all 1422 targets) - [x] goalc-test suite: 1509 passed, 0 failed - [x] Second consecutive configure with `compile_commands.json` present: the regen rule in `build.ninja` has no `compile_commands.json` input; `<src>/build/compile_commands.json` is still refreshed for clangd - [x] Repeated `ninja` invocations after a full build no longer re-run CMake - [x] macOS Intel and ARM CI green (first exercise of the OpenSSL backend switch) --- I work off a self-hosted forge, so this GitHub account is quiet; the configure logs and ninja dirty-node traces from the investigation are available if anyone wants the raw data. (AI-assisted)
139 lines
4.0 KiB
Markdown
Vendored
Generated
139 lines
4.0 KiB
Markdown
Vendored
Generated
---
|
|
c: Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
SPDX-License-Identifier: curl
|
|
Title: testcurl.pl
|
|
Section: 1
|
|
Source: testcurl
|
|
See-also:
|
|
- runtests.pl
|
|
Added-in: 7.11.2
|
|
---
|
|
|
|
# NAME
|
|
|
|
testcurl.pl - (automatically) test curl
|
|
|
|
# SYNOPSIS
|
|
|
|
**testcurl.pl [options] [dir] \> output**
|
|
|
|
# DESCRIPTION
|
|
|
|
*testcurl* is the master script to use for automatic distributed testing of
|
|
curl from git or daily snapshots. It is written for the purpose of being run
|
|
from a crontab job or similar at a regular interval. The output is suitable to
|
|
be mailed to **curl-autocompile@haxx.se** to be dealt with automatically (make
|
|
sure the subject includes the word "autobuild" as the mail gets silently
|
|
discarded otherwise). The most current build status (with a reasonable
|
|
backlog) is published on the curl site, at https://curl.se/dev/builds.html
|
|
|
|
*options* may be omitted. See *--setup* for what happens then.
|
|
|
|
*dir* is a curl source directory, possibly a daily snapshot one. Using this
|
|
makes *testcurl* skip the *autoreconf* stage and thus it removes the
|
|
dependency on automake, autoconf, libtool, GNU m4 and possibly a few other
|
|
things.
|
|
|
|
*testcurl* runs `autoreconf` (or similar), configure, builds curl and libcurl
|
|
in a separate build directory and then runs `make test` to test the fresh
|
|
build.
|
|
|
|
# OPTIONS
|
|
|
|
## `--configure=[options]`
|
|
|
|
Configure options passed to configure.
|
|
|
|
## `--crosscompile`
|
|
|
|
This is a cross-compile. Makes *testcurl* skip a few things.
|
|
|
|
## `--desc=[desc]`
|
|
|
|
Description of your test system. Displayed on the build summary page on the
|
|
website.
|
|
|
|
## `--email=[email]`
|
|
|
|
Set email address to report as. Displayed in the build logs on the site.
|
|
|
|
## `--mktarball=[command]`
|
|
|
|
Generic command to run after completed test.
|
|
|
|
## `--name=[name]`
|
|
|
|
Set name to report as. Displayed in the build summary on the site.
|
|
|
|
## `--nobuildconf`
|
|
|
|
Do not run autoreconf. Useful when many builds use the same source tree, as
|
|
then only one need to do this. Also, if multiple processes run tests
|
|
simultaneously on the same source tree (like several hosts on a NFS mounted
|
|
directory), simultaneous autoreconf invokes may cause problems. (Added in
|
|
7.14.1)
|
|
|
|
## `--nogitpull`
|
|
|
|
Do not update from git even though it is a git tree. Useful to still be able
|
|
to test even though your network is down, or similar.
|
|
|
|
## `--runtestopts=[options]`
|
|
|
|
Options that is passed to the runtests script. Useful for disabling valgrind
|
|
by force, and similar.
|
|
|
|
## `--setup=[filename]`
|
|
|
|
filename to read setup from (deprecated). The old style of providing info. If
|
|
info is missing when *testcurl* is started, it prompts you and then stores the
|
|
info in a 'setup' file, which it looks for on each invoke. Use *--name*,
|
|
*--email*, *--configure* and *--desc* instead.
|
|
|
|
## `--target=[your os]`
|
|
|
|
Specify your target environment. Recognized strings include `vc`, `mingw32`,
|
|
and `borland`.
|
|
|
|
# INITIAL SETUP
|
|
|
|
First, make a checkout from git (or you write a script that downloads daily
|
|
snapshots automatically):
|
|
|
|
$ mkdir curl-testing
|
|
$ cd curl-testing
|
|
$ git clone https://github.com/curl/curl
|
|
|
|
With the curl sources checked out, or downloaded, you can start testing right
|
|
away. If you want to use *testcurl* without command line arguments and to have
|
|
it store and remember the config in its 'setup' file, then start it manually
|
|
now and fill in the answers to the questions it prompts you for:
|
|
|
|
$ ./curl/tests/testcurl
|
|
|
|
Now you are ready to go. If you let the script run, it performs a full cycle
|
|
and spit out lots of output. Mail us that output as described above.
|
|
|
|
# CRONTAB EXAMPLE
|
|
|
|
The crontab could include something like this:
|
|
|
|
# autobuild curl:
|
|
0 4 * * * cd curl-testing && ./testit.sh
|
|
|
|
Where `testit.sh` is a shell script that could look similar to this:
|
|
|
|
mail="mail -s autobuild curl-autocompile@haxx.se"
|
|
name="--name=whoami"
|
|
email="--email=iamme@nowhere"
|
|
desc='"--desc=supermachine Turbo 2000"'
|
|
testprog="perl ./curl/tests/testcurl.pl $name $email $desc"
|
|
opts1="--configure=--enable-debug"
|
|
opts2="--configure=--enable-ipv6"
|
|
|
|
# run first test
|
|
$testprog $opts1 | $mail
|
|
|
|
# run second test
|
|
$testprog $opts2 | $mail
|