mirror of
https://github.com/open-goal/jak-project
synced 2026-08-05 01:30:22 -04:00
Tyler Wilding
02e9579fb5
Fixes another long-standing subtitle translation bug. There is a `merge` flag on each subtitle line, the idea being that we would merge in the text from the base game if this was set. However in jak 2 and beyond: - The subtitles for english (base) are not predefined for the cutscenes, only the hints. The rest are in the game files and we do not simultaneously load both languages when the game is running so there is no trivial fallback path. - However, every subtitle language by default inherits the base games metadata, where all `merge` flags are set to `true` This means that all custom cutscene translations were being ignored unless this flag was set to false in the metadata file for each line. This is what finnish does since it changes the number of lines and their timings, and is why it works fine. This flag can probably be completely removed, as per the above, it serves no actual purpose. All it does in our code is if it's set, we skip the line when writing out the subtitle file. But for now i simply just iterate through and flip these flags automatically if the language overrode the cutscene. Tested on english/finnish/pt-BR <img width="648" height="467" alt="image" src="https://github.com/user-attachments/assets/292e3dfe-df66-4d23-942a-b41f2b157bf8" />