staging: comedi: s526: fix if() check in s526_gpct_winsn()
This if() check was flipped from a test for valid data params
to a test for invalid params.
As pointed out by Dan Carpenter, the orignal test was:
if ((data[1] > data[0]) && (data[0] > 0)) {
the flipped test should be:
if (data[1] <= data[0]) ...
Add the missing '='.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
54a2a02ea5
commit
67f2021fb1
@@ -376,7 +376,7 @@ static int s526_gpct_winsn(struct comedi_device *dev,
|
||||
The above periods must be expressed as a multiple of the
|
||||
pulse frequency on the selected source
|
||||
*/
|
||||
if ((data[1] < data[0]) || !data[0])
|
||||
if ((data[1] <= data[0]) || !data[0])
|
||||
return -EINVAL;
|
||||
|
||||
/* Fall thru to write the PULSE_WIDTH */
|
||||
|
||||
Reference in New Issue
Block a user