mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

staging: comedi: adv_pci1723: cleanup card reset

Browse Source 
Only one 'reset' of the card is required in the attach. Remove the
one before setting up the subdevices and leave the one before
exiting the attach function.

The 'valid' variable in the private data is not needed. This variable
is used in the detach to determine if it's ok to call the 'reset'
function. Checking if dev->iobase is valid works just as well.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten
2012-08-17 18:18:40 -07:00
committed by Greg Kroah-Hartman
parent 5222687a7f
commit edf5147213
1 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/staging/comedi/drivers/adv_pci1723.c
View File

@@ -107,12 +107,8 @@ TODO:
#define PCI1723_SELECT_CALIBRATION 0x28 /* Select the calibration Ref_V */
/* This structure is for data unique to this hardware driver. */
struct pci1723_private {
int valid; /* card is usable; */
unsigned char da_range[8]; /* D/A output range for each channel */
short ao_data[8]; /* data output buffer */
};
@@ -262,8 +258,6 @@ static int pci1723_attach_pci(struct comedi_device *dev,
if (ret)
return ret;
pci1723_reset(dev);
s = dev->subdevices + 0;
dev->write_subdev = s;
s->type = COMEDI_SUBD_AO;
@@ -303,8 +297,6 @@ static int pci1723_attach_pci(struct comedi_device *dev,
/* read DIO port state */
s->state = inw(dev->iobase + PCI1723_READ_DIGITAL_INPUT_DATA);
devpriv->valid = 1;
pci1723_reset(dev);
dev_info(dev->class_dev, "%s attached\n", dev->board_name);
@@ -315,15 +307,12 @@ static int pci1723_attach_pci(struct comedi_device *dev,
static void pci1723_detach(struct comedi_device *dev)
{
struct pci_dev *pcidev = comedi_to_pci_dev(dev);
struct pci1723_private *devpriv = dev->private;
if (devpriv) {
if (devpriv->valid)
pci1723_reset(dev);
}
if (pcidev) {
if (dev->iobase)
if (dev->iobase) {
pci1723_reset(dev);
comedi_pci_disable(pcidev);
}
}
}