Bill Pemberton
7e052d98f2
Staging: hv: check return value of osd_PageAlloc()
...
The return value of osd_PageAlloc() was checked using an ASSERT().
Change that to more useful behaviour.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Cc: Hank Janssen <hjanssen@microsoft.com >
Cc: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Bill Pemberton
75910f236a
Staging: hv: remove ASSERT()s in ChannelMgt.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Cc: Hank Janssen <hjanssen@microsoft.com >
Cc: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Bill Pemberton
1e19c05443
Staging: hv: Remove check for NULL before calling kfree()
...
kfree() knows how to deal with NULL, so there's no reason to check for
NULL before passing something to it.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu >
Cc: Hank Janssen <hjanssen@microsoft.com >
Cc: Haiyang Zhang <haiyangz@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Greg Kroah-Hartman
2342df0e63
Staging: dt3155v4l: fix some sparse warnings
...
Mostly some __iomem markings and some static functions as well.
Cc: Marin Mitov <mitov@issp.bas.bg
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Marin Mitov
7ec21181d2
Staging: dt3155v4l: Adding the missing linux/delay.h
...
The prototypes of udelay() and msleep() are in linux/delay.h,
so include it.
Reported-by: Randy Dunlap <randy.dunlap@oracle.com >
Signed-off-by: Marin Mitov <mitov@issp.bas.bg >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Andres More
6e1b4e24e6
Staging: vt6656: code cleanup, resolved sparse finding
...
Cleared sparse warning 'Using plain integer as NULL pointer'
Signed-off-by: Andres More <more.andres@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Andres More
6f8c13c7db
Staging: vt6656: code cleanup, removed OUT definition
...
Remoted empty OUT define in ttype.h and its usage across the code.
Signed-off-by: Andres More <more.andres@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Andres More
fa10b25f8d
Staging: vt6656: removed SUCCESS define as it is not used
...
Signed-off-by: Andres More <more.andres@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Prashant P. Shah
d16e1834af
Staging: arlan: fixed unnecessary whitespace style issue in arlan-main.c
...
This is a patch to the arlan-main.c file that fixes the unnecessary whitespace
issues found by the checkpatch.pl tool.
Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:12 -07:00
Peter Hüwe
40447df803
Staging: cxt1e1: fix up one remaining THIS_MODULE usage
...
Copied from original Patch by Randy Dunlap
Signed-off-by: Peter Huewe <peterhuewe@gmx.de >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
wzt.wzt@gmail.com
dde27e03cc
Staging: rtl8192u: Check kmalloc return value before use the buffer in ieee80211_softmac.c
...
Check kmalloc return value before use the buffer.
Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
318a5b2a50
Staging: comedi: cb_pcidas64: fix up build warnings
...
Now that the 8255.h file is being included properly, we were
using the incorrect function prototypes, which causes a build
warning now. This fixes it up and preserves the __iomem markings that
sparse wants to see.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
c5efe58b83
Staging: comedi: 8255: fix up previous static markings.
...
Ian pointed out that exported symbols should not be marked as static :)
Fixed this up by properly including the 8255.h file, and fixing
the function prototypes there, as the CONFIG variables were not getting
set so users of the header file were seeing the incorrect function
prototypes.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
1e18c0d5b4
Staging: line6: driver: fix up sparse warnings
...
minor stuff.
Cc: Markus Grabner <grabner@icg.tugraz.at >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
74112d3f3a
Staging: iio: industrialio-trigger.c: minor fixups
...
We needed to include a header file that declared the functions that are
being exported in this file.
Also fix up an indentation problem, and some sparse warnings.
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
19ca92e0bc
Staging: iio: ring_sw.c: fix up sparse warnings
...
NULL usage, static stuff, etc.
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
0deebb4fc4
Staging: iio: industrialio-ring.c: fix up sparse warnings
...
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
7cfce527a2
Staging: iio: accel: fix up some sparse warnings.
...
Minor stuff (static, NULL, etc.)
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:11 -07:00
Greg Kroah-Hartman
d1d8abdb05
Staging: iio: trigger: fix up some global variables
...
These should be static.
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Greg Kroah-Hartman
341713f265
Staging: iio: light: tsl2563: fix static sparse warning
...
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Greg Kroah-Hartman
acbbfe236e
Staging: iio: adc: max1363_ring.c: fix up sparse warnings
...
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Greg Kroah-Hartman
f03de82b3f
Staging: iio: max1363_core: fix bug in kzalloc call
...
The operands were switched around :(
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Greg Kroah-Hartman
1b183e4b93
Staging: iio: adc: max1363_core: fix up some sparse warnings
...
Also fix a minor coding style issue.
Cc: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Jonathan Cameron
cb6405b15f
Staging: iio: light trivial whitespace fix
...
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Jonathan Cameron
26de720828
Staging: iio: accelerometers trivial checkpatch related fixes
...
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Jonathan Cameron
5f87404dfc
Staging: iio: Trivial - remove pointless semi colon (checkpatch found)
...
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Stephen Hemminger
f82f4ad7bf
Staging: hv: add basic ethtool support
...
Ethtool allows querying device information and controlling parameters.
For now just add ability to turn on/off scatter/gather.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com >
Acked-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Stephen Hemminger
b220f5f925
Staging: hv: add transmit flow control
...
Keep track of the number of pages sent over transmit and stop
before going over.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com >
Acked-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:10 -07:00
Stephen Hemminger
6048718d71
Staging: hv: transmit scatter gather support
...
The transmit management of pages was confusing for handling
fragmented SKB's. (But since NETIF_F_SG was never set, the code was never hit).
The parameter AdditionalRequestPageBufferCount is always one,
(and leads to ugly code), so just inline and add comments.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com >
Acked-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Stephen Hemminger
9f8bd8bacf
Staging: hv: use existing Ethernet header size
...
Use ETH_ALEN to indicate that MAC address is Ethernet.
Also use Linux printk format for mac addresses.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com >
Acked-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Stephen Hemminger
450d7a4b7a
Staging: hv: ring parameter
...
The ring size parameter should be number of pages (not bytes).
Add module parameter information as well.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com >
Acked-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Stephen Hemminger
7880fc54c9
Staging: hv: cleanup network driver
...
Minor stuff:
* Add module description
* Remove variable set but never used.
* Move variable inside conditional
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com >
Acked-by: Hank Janssen <hjanssen@microsoft.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Greg Kroah-Hartman
4e4b592cb5
Staging: comedi: hwdrv_apci3xxx.c: loads of sparse cleanups
...
__iomem pointer fixes, and static cleanups.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Greg Kroah-Hartman
a6dc6d0df2
Staging: comedi: hwdrv_apci3501.h: make a variable static.
...
Cleans up the sparse warning.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Greg Kroah-Hartman
882980133d
Staging: comedi: hwdrv_apci2032.c: static sparse fix
...
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Greg Kroah-Hartman
0b437fc493
Staging: comedi: hwdrv_apci1564.c: static sparse cleanups.
...
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Greg Kroah-Hartman
a943532652
Staging: comedi: hwdrv_apci1500.c: sparse static cleanups
...
Mark a bunch of variables and functions as static.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:09 -07:00
Greg Kroah-Hartman
2179b4c8b5
Staging: comedi: hwdrv_apci1032.c: sparse warning fixups
...
Mark a variable as static.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
1a538dfd16
Staging: comedi: hwdrv_apci035.h: fix sparse warnings
...
This let us delete two variables and mark one as static.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
08b93e7bda
Staging: comedi: hwdrv_apci035.c: fix sparse warnings
...
Some variables should be static.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
525d1b1395
Staging: comedi: adl_pci9111.c: fix sparse warnings
...
divisor and other problems fixed.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
5f35f3f19f
Staging: comedi: adl_pci9118.c: fix unsigned problem with divisors
...
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
a8cb9ad9ad
Staging: comedi: adv_pci1710.c: fix unsigned problem with divisors
...
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
a7f22a84ba
Staging: comedi: amplc_dio200.c: fix NULL sparse warnings
...
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
f31d0008ce
Staging: comedi: cb_pcidas64.c: fix sparse warnings
...
This fixes a bunch of iomem and other sparse warnings.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
d18c5906d0
Staging: comedi: das1800.c: fix a locking error on the error path.
...
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:08 -07:00
Greg Kroah-Hartman
b74a967085
Staging: comedi: plx9080.h: properly mark iomem variables
...
It's a __iomem *, so mark it as such.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:07 -07:00
Greg Kroah-Hartman
e3752a1dfd
Staging: comedi: quatech_daqp_cs.c: fix up the irq
...
The irq needs to return the correct type. Also fix up some other
sparse warnings that were found.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:07 -07:00
Greg Kroah-Hartman
ad2d4714a5
Staging: comedi: addi_amcc_s5933.h: sparse cleanup
...
Mark a variable static that does not need to be global.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:07 -07:00
Greg Kroah-Hartman
2f78c64255
Staging: comedi: addi_common.c: sparse cleanups
...
Now that we are properly marking the variable as __iomem, don't
cast it.
Also fix up some other sparse warnings.
Cc: Ian Abbott <abbotti@mev.co.uk >
Cc: Frank Mori Hess <fmhess@users.sourceforge.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2010-05-11 11:36:07 -07:00