mirror/mk64
1
0
Fork 0
mirror of https://github.com/n64decomp/mk64 synced 2026-08-09 10:32:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add notes from a couple bugs (#778)

Browse Source 
* Update render_player.c

* Document broken shell firing condition in actors_extended.c

Add comment explaining broken shell firing condition.
This commit is contained in:
MegaMech
2026-08-01 14:41:03 -06:00
committed by GitHub
parent 230fe2ec1e
commit 6ae9cf9482
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/racing/actors_extended.c
+6
View File
@@ -427,6 +427,12 @@ void update_actor_triple_shell(TripleShellParent* parent, s16 shellType) {
if (parent->unk_08 > 0.0f) {
if (parent->shellIndices[0] > 0.0f) {
shell = (struct ShellActor*) &gActorList[(s16) parent->shellIndices[0]];
/**
* This condition is broken and always evaluates to true.
* If you fix the condition, when you fire a shell it continues being held by the player
* until the shell is in-front of the player. This allows the shell to always shoot in a foward direction instead of straying sideways.
* when fired at the wrong time
*/
if ((shell->rotAngle < DEGREES(5)) || (shell->rotAngle > -DEGREES(5))) {
someVelocity[0] = 0;
someVelocity[1] = 0;
src/render_player.c
+2
View File
@@ -1155,6 +1155,8 @@ void render_light_environment_on_player(Player* player, s8 playerIndex) {
((gNearestPathPointByPlayerId[playerIndex] >= 0x216) && (gNearestPathPointByPlayerId[playerIndex] < 0x21D)) ||
((gNearestPathPointByPlayerId[playerIndex] >= 0x230) && (gNearestPathPointByPlayerId[playerIndex] < 0x23A)) ||
((gNearestPathPointByPlayerId[playerIndex] >= 0x24C) && (gNearestPathPointByPlayerId[playerIndex] < 0x256)) ||
// This is the second last lamp. This condition is bugged and it does not glow on the player.
// The value 0x228 was probably meant to be 0x25F.
((gNearestPathPointByPlayerId[playerIndex] >= 0x288) && (gNearestPathPointByPlayerId[playerIndex] < 0x269)) ||
((gNearestPathPointByPlayerId[playerIndex] >= 0x274) &&
(gNearestPathPointByPlayerId[playerIndex] < 0x27E))) { // under a lamp