Global __osGetId (OSPfs *pfs)

loads of magic constants..

remove magic constant

Global __osPfsReleasePages (OSPfs *pfs, __OSInode *inode, u8 start_page, u16 *sum, u8 bank, __OSInodeUnit *last_page, int flag)

magic number

Global __osPfsRWInode (OSPfs *pfs, __OSInode *inode, u8 flag, u8 bank)

don't like this =/ //maybe &inode->inode_table[j*PFS_ONE_PAGE].ipage or something

Global __osPiDevMgr

In libreultra this is in an include

Global __osRepairPackId (OSPfs *pfs, __OSPackId *badid, __OSPackId *newid)

remove magic constant

fix magic number

Global BAD_RETURN (cmd)

put this define in types.h or similar. Certain functions are marked as having return values, but do not actually return a value. This causes undefined behavior, which we'd rather avoid on modern GCC. This only impacts -O2 and can matter for both the function itself and functions that call it.

Global clear_framebuffer (s32)

Why did void* work for matching

Global D_02007BB8 []

Place all these vertices in a single array

Global D_0D004C68 []

What is this?

Global D_800E43B0 []

unused?

Global D_8018D9B0

Move gGfxPool out of main.h

Global D_8018E7FA

Unknown type

Global D_8018E800

Unknown type

Global D_8018E81A

Unknown type

Global D_8018E820

these are likely arrays.

Global D_8018E822

This may not be the right file for them.

Global debug_switch_character_ceremony_cutscene (void)

confirm this.

Class du

is it possible to remove them somehow?

Global fill [2]

file boundary?

Global fill2

0x00000000800f624c fill2

Global func_800100F0 (s32)

Confirm this comment

Global func_80028864 (Player *, Camera *, s8, s8)

make a proper match

Global func_80046030 (u8 *tlut, u8 *texture, Vtx *arg2, s32 width, s32 arg4, s32 height)

tlut/texture unconfirmed. This could be texture1 and texture2

Global func_8004B7DC (s32 x, s32 y, s32 width, s32 height, s32 arg4, s32 arg5, s32 arg6)

Update to F3DEX. Uses OLD definition for gspTextureRectangle.

Global func_8004C268 (u32 arg0, u32 arg1, u8 *texture, u32 width, u32 arg4, u32 height, s32 arg6)

fakematch?

Global func_800745C8 (s32, s32)

arg1 should likely be a u8 *

Global func_80091FA4 (void)

These sizes need to be sizeof() for shiftability if possible

Global func_800CBC24 (void)

clenanup, something's weird with the variables. D_800EA4A4 is probably EuAudioCmd bc of the + 0x100

Global func_80282D90 (struct CinematicCamera *, struct struct_80286A04 *, struct struct_80286A04 *, s32)

Cast to normal Camera? Or from CinematicCamera?

Global func_8028336C (UNUSED struct CinematicCamera *arg0, UNUSED Camera *camera)

Does this match as a return of s8?

Global func_802846E4 (struct CinematicCamera *)

What does this even do?

Global func_8028F970 (void)

increasing players past four would require increase this loop iterator.

Global gen_random_item (s16, s16)

Cleanup this function to use array access and struct if possible.

Global gPlayerWinningIndex

gPlayerWinningIndex (D_800DC5E8) accessed as word, D_800DC5EB as u8

Global gTLUTLakituCheckeredFlag []

Generate tlut based on the actual texture. The textures these tluts are for are not in common_textures.inc.c This applies to gTLUTLakituCheckeredFlag, gTLUTLakituSecondLap, gTLUTLakituFinalLap, gTLUTLakituReverse, gTLUTLakituFishing Appears to be animation textures.

Global gTorchSpawns []