mirror of
https://github.com/zeldaret/mm.git
synced 2026-05-23 06:54:14 -04:00
CLOSE_DISPS fixes and avoid early return (#1621)
* fix en_osn close_disps position * rework en_mnk draw face to avoid returns * use goto in effect draw to avoid returns * feedback
This commit is contained in:
@@ -658,6 +658,7 @@ void EffectBlure_DrawSmooth(EffectBlure* this2, GraphicsContext* gfxCtx) {
|
||||
OPEN_DISPS(gfxCtx);
|
||||
|
||||
if (this->numElements < 2) {
|
||||
//! @bug Skips CLOSE_DISPS
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -678,6 +679,7 @@ void EffectBlure_DrawSmooth(EffectBlure* this2, GraphicsContext* gfxCtx) {
|
||||
|
||||
mtx = SkinMatrix_MtxFToNewMtx(gfxCtx, &sp5C);
|
||||
if (mtx == NULL) {
|
||||
//! @bug Skips CLOSE_DISPS
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
@@ -2203,17 +2203,17 @@ void EnMnk_Monkey_DrawFace(EnMnk* this, PlayState* play) {
|
||||
} else {
|
||||
gSPSegment(POLY_OPA_DISP++, 0x08, Lib_SegmentedToVirtual(sMonkeyFaceTextures[this->blinkFrame]));
|
||||
}
|
||||
return;
|
||||
break;
|
||||
|
||||
case 2:
|
||||
case 3:
|
||||
gSPSegment(POLY_OPA_DISP++, 0x08, Lib_SegmentedToVirtual(sMonkeyFaceTextures[this->unk_3E0]));
|
||||
return;
|
||||
break;
|
||||
|
||||
default:
|
||||
gSPSegment(POLY_OPA_DISP++, 0x08, Lib_SegmentedToVirtual(sMonkeyFaceTextures[this->blinkFrame]));
|
||||
break;
|
||||
}
|
||||
gSPSegment(POLY_OPA_DISP++, 0x08, Lib_SegmentedToVirtual(sMonkeyFaceTextures[this->blinkFrame]));
|
||||
|
||||
CLOSE_DISPS(play->state.gfxCtx);
|
||||
}
|
||||
|
||||
@@ -1064,7 +1064,7 @@ void EnOsn_Draw(Actor* thisx, PlayState* play) {
|
||||
POLY_XLU_DISP =
|
||||
SkelAnime_DrawFlex(play, this->skelAnime.skeleton, this->skelAnime.jointTable, this->skelAnime.dListCount,
|
||||
EnOsn_OverrideLimbDraw, EnOsn_PostLimbDraw, &this->actor, POLY_XLU_DISP);
|
||||
|
||||
CLOSE_DISPS(play->state.gfxCtx);
|
||||
}
|
||||
|
||||
CLOSE_DISPS(play->state.gfxCtx);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user