* [n64-jp-1.1] build OK
* [n64-jp-1.1] flg_set OK
* [n64-jp-1.1] game OK
* [n64-jp-1.1] graph OK (except bss)
* [n64-jp-1.1] main OK
* [n64-jp-1.1] padmgr OK
* [n64-jp-1.1] cmpdma OK
* [n64-jp-1.1] sys_freeze OK
* [n64-jp-1.1] sys_initial_check OK
* [n64-jp-1.1] sys_slowly OK
* [n64-jp-1.1] title_setup OK
* [n64-jp-1.1 z_DLF OK]
* [n64-jp-1.1] actor OK
* [n64-jp-1.1] bgcheck OK
* [n64-jp-1.1] collision btltbls OK
* [n64-jp-1.1] collision check OK
* [n64-jp-1.1] common_data OK
* [n64-jp-1.1] debug mode OK
* [n64-jp-1.1] demo OK
* [n64-jp-1.1] effect_soft_sprite OK
* Review suggestions
* Fixed Dockerfile.
Dockerfile updated per the file on https://practicerom.com/public/packages/debian/howto.txt
and Debian/Ubuntu's apt-key command being deprecated.
* Update dockerfile as per new download instructions.
* Modify Dockerfile.
* Remove sudo from Dockerfile.
* [assets] Add TlutOffset to CI textures: misc, gkeeps, `object_[ab]*`
* [assets] Add TlutOffset to CI textures: `object_[c-i]*`
* remove extra space before TlutOffset
* [assets] Add TlutOffset to CI textures: `object_[j-n]*`
* [assets] Add TlutOffset to CI textures: `object_[o-z]*`
---------
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
* Migrate CI to Github Actions (#1884)
Changes the CI system from Jenkins to Github Actions (GHA) like we did for OoT
This is an adaptation of the Jenkinsfile we have and the solution made by @Dragorn421 for OoT
Relevant OoT PRs:
- https://github.com/zeldaret/oot/pull/2740
- https://github.com/zeldaret/oot/pull/2742
- https://github.com/zeldaret/oot/pull/2754
New features include:
- Not needing to selfhost a runner
- Required private stuff for building is hosted on a private repo
- Building multiple versions in parallel
- Our old jenkinsfile wasn't building `n64-jp-1.1`. Even if it doesn't match right now, I think it is important checking a PR doesn't completely break it.
- Run bss fixer in CI
- Upload mapfiles as build artifacts
This specific approach to handle GHA for decomp projects was adapted from the one used by the GC/Wii community. It is documented here https://github.com/encounter/dtk-template/blob/main/docs/github_actions.md There's a writeup about this adaptation for N64 projects [here](https://github.com/AngheloAlf/drmario64/pull/19).
* Remove duplicated step id
* Wire up compiler_archives machinery
* Remove extra quote
* Select bash as the default shell
* Fix asset extraction for WIP versions
* Properly fix the assets step this time
* fix assets building for jp
* Prevent running CI on forks
Incorporates the changes from https://github.com/zeldaret/oot/pull/2788
* Incorporate fix_bss tiebreaking algorithm from https://github.com/zeldaret/oot/pull/2779
* Pr2: some docs, first struct pass
* Pr2: Most functions named
* Pr2: more docs
* Pr2: object documented
* Pr2: object documented
* Pr2: format
* Pr2: more docs, format
* Pr2: requested changes
* Pr2: requested changes
* Pr2: forgot prz used the object too
* Pr2: more skelton limb enum changes
* Pr2: removed old comment
Due to the layout of the pitch_frequencies lookup table, note values
computed in extraction were reflected around middle C (midi note
number 60). This didn't matter for matching, values would successfully
roundtrip. However when using samples in external programs or
converting soundfonts to standard formats the note values would lead
to incorrect playback of sounds. This change corrects the note values
so that external programs correctly infer the pitch of the sound when
played at a particular MIDI key.
odd chunk sizes
* Read WAV SMPL chunks for note info when INST chunks are not available
* Populate the SMPL chunk on conversion to wav
* Properly handle unaligned (odd) WAV chunk sizes
Derek Hensley