Due to the layout of the pitch_frequencies lookup table, note values
computed in extraction were reflected around middle C (midi note
number 60). This didn't matter for matching, values would successfully
roundtrip. However when using samples in external programs or
converting soundfonts to standard formats the note values would lead
to incorrect playback of sounds. This change corrects the note values
so that external programs correctly infer the pitch of the sound when
played at a particular MIDI key.
odd chunk sizes
* Read WAV SMPL chunks for note info when INST chunks are not available
* Populate the SMPL chunk on conversion to wav
* Properly handle unaligned (odd) WAV chunk sizes
* Allow atblgen to process `sequence_order.in` with empty lines in between other lines
* Fix memory leak issues and missing flags in makefile
* FIx warning that apparently only appeared because optimization flags are now enabled
* Skip empty lines at the beginning of the file
* [Audio 8/?] Check-in handwritten sequences, build sequences, automate various sfx arrays
* Fix whitespace in aseq.h
* Suggested changes, adjust some MML syntax and add more instruction descriptions
* Special case progress script (#9)
* Hack progress script
* Small adjustment to text fileSectionFixer
* Add the dir of the input .seq file to the list of includes to sequence assembling so that assembler-level includes like .include or .incbin work intuitively
* Remove old comment that was missed before
* aseq.h tweaks
* Review suggestions, aseq.h adjustments
---------
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com>
* [Audio 6/?] Build Soundfonts and the Soundfont Table
* Fix bss
* Maybe fix warnings
* Improve lots of error messages
* Suggested changes from OoT PR
* Suggested changes
* Make soundfont_table.h generation depend on the samplebank xmls since they are read, report from which soundfont the invalid pointer indirect warning originates from
* [Audio 5/?] Build the Samplebank Table
* OoT suggested changes
* Fix format specifier
* Moved linker_scripts files used in final linker to linker_scripts/final
* Populate OTHER_DIRS with linker_scripts subdirs
* Unhide the partial link command
* [Audio 4/?] Build Samplebanks, match Audiotable
* Add missing scope in MARK chunk handling
* Add comment to generate asm file when buffer bug data is emitted, remove duplicate CC4 definition
* Adjust comment
* SBCFLAGS
* Remove unnecessary comments on notes_lut
* Split build directories creation command into several to avoid it becoming too long
* objcopy -j -> --only-section
* Try fix mkdir from clean
* Try fix 2
* [Audio 2/?] Extract audio samples to wav
Co-authored-by: zelda2774 <69368340+zelda2774@users.noreply.github.com>
* How
* Hopefully fix warning I don't get locally
* [OoT Review] Pad default sample filenames, comment on the vadpcm frame encoder functions, other suggested changes
* Small tweaks to above
* Remove some obsolete code
---------
Co-authored-by: zelda2774 <69368340+zelda2774@users.noreply.github.com>
* [Audio 1/?] Extract Samplebanks and Soundfonts to XML
* Remove config.py in view of using config yamls for addresses in the future, implement suggested changes from OoT review
* Remove some commented out dead code, adjust setup-audio in makefile
* Move audio extraction from setup to assets in makefile
Tharo