mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot synced 2026-07-07 05:55:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Document SysCfb_GetFbPtr bug (#2586)

Browse Source 
* Document SysCfb_GetFbPtr bug

* cleaner comment

* fixes

* change wording again
This commit is contained in:
mzxrules
2026-02-17 04:31:54 -05:00
committed by GitHub
parent 834b443bbb
commit 95495d221f
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/code/graph.c
+7
View File
@@ -141,6 +141,13 @@ void Graph_InitTHGA(GraphicsContext* gfxCtx) {
gfxCtx->overlayBuffer = pool->overlayBuffer;
gfxCtx->workBuffer = pool->workBuffer;
//! @bug fbIdx is a signed integer that can overflow into the negatives. When compiled with a C99+ compiler or IDO,
//! the remainder operator will yield -1 for odd negative values of fbIdx.
//! This causes SysCfb_GetFbPtr to read beyond the bounds of an array when retrieving the framebuffer pointer, which
//! will likely crash the game.
//!
//! This isn't an issue in practice. In the worst case scenario with the game operating at a consistent 60 FPS,
//! it would take approximately 414.25 days of continuous operation for fbIdx to overflow.
gfxCtx->curFrameBuffer = SysCfb_GetFbPtr(gfxCtx->fbIdx % 2);
gfxCtx->unk_014 = 0;
}