compile_overlays: name the no-walk-root skip message so its test cannot drift

Validated on a clean rebased integration branch: tools/test_compile_overlays_static_split.py passes (10 tests).
This commit is contained in:
Matt Stanley
2026-09-19 14:10:39 -05:00
committed by GitHub
2 changed files with 16 additions and 3 deletions
+11 -2
View File
@@ -3255,6 +3255,15 @@ def current_variant_func_id_coverage(func_ids: list, data: bytes,
# contract/header change (which bumps the hash -> fresh dir -> fresh memo)
# re-attempts everything (e.g. the psx_rfe_mark_escape contract fix).
# So a memoized skip only ever elides a build that is deterministically doomed.
# Printed when a capture contributes no walk-root seed. The wording is
# deliberate: the region is NOT declared data-only -- its executed dispatch
# demands are still served by the isolated-fragment pass, which runs
# separately. Named so the two emit sites and the test cannot drift apart.
# They did: 4683e923 reworded both prints and left
# test_compile_overlays_static_split asserting the old string.
NO_SHARED_WALK_ROOT_SEEDS_SKIP = (
'SKIP: no shared walk-root seeds; checking fragments separately')
INTERIOR_FAIL_MEMO = 'interior_fail_memo.txt'
@@ -5818,7 +5827,7 @@ def _static_capture_job(cap, args, toml, forced_interiors, static_out, result):
seed.split()[0].startswith('0x'))
]
if not root_seeds:
print(' SKIP: no shared walk-root seeds; checking fragments separately\n')
print(f' {NO_SHARED_WALK_ROOT_SEEDS_SKIP}\n')
result['outcome'] = 'skip'
return
@@ -6366,7 +6375,7 @@ def main():
seed.split()[0].startswith('0x'))
]
if not root_seeds:
print(' SKIP: no shared walk-root seeds; checking fragments separately\n')
print(f' {NO_SHARED_WALK_ROOT_SEEDS_SKIP}\n')
stats.add_skip()
return
+5 -1
View File
@@ -227,7 +227,11 @@ class StaticWorkerContractTests(unittest.TestCase):
'overlays_static.c')
self.assertEqual(res['outcome'], 'skip')
self.assertIsNone(res['part'])
self.assertIn('SKIP: no walk-root seeds', res['log'])
# Assert the constant, not a copy of its text: this line asserted a
# stale literal from 4683e923 until 2026-09-18 and the test was red
# on master the whole time.
self.assertIn(compile_overlays.NO_SHARED_WALK_ROOT_SEEDS_SKIP,
res['log'])
self.assertEqual(res['requested_entries'], set())