mirror/psxrecomp
1
0
Fork 0
mirror of https://github.com/RetroPortingToolKit/psxrecomp synced 2026-10-28 10:59:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

gl: clear the native-wide surface's depth buffer, per frame and on allocation

Browse Source 
The wide mirror carries its own depth attachment, but depth was cleared in
exactly one place in this file -- hr_begin, which only ever touches the hr FBO.
So with PGXP depth on, the wide surface tested against depth written before its
allocation and never cleared since: margins accumulate depth forever and
progressively reject their own geometry, which is the same failure mode as the
s_frame_count bug and just as invisible to a single-frame A/B.

Cleared at allocation alongside colour and stencil, and again per frame in
wide_target_begin, armed at Swap exactly like the hr clear.

Latent rather than observed: the widescreen mod is off in the harness used for
the depth measurements, so g_wide_cur is 0 and the mirror pass never runs there.
It would bite any widescreen player the moment depth was enabled.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
tetrisgm
2026-08-17 19:07:25 -07:00
parent a29bb7cddb
commit b0feee09cc
1 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/src/gpu_gl_renderer.c
+20 -1
View File
@@ -432,6 +432,7 @@ static float s_zc_min = 1e30f, s_zc_max = 0.0f;
static double s_zc_sum = 0.0;
static uint64_t s_zc_n = 0, s_zc_hist[ZC_BUCKETS];
static int s_depth_needs_clear = 1; /* armed at Swap; see hr_begin */
static int s_wide_depth_clear = 1; /* same, for the native-wide mirror */
/* Near plane in GTE Z units for the reciprocal depth map.
*
* MUST sit at or below the smallest Z the scene produces, because the map
@@ -1932,6 +1933,17 @@ static void wide_target_begin(int dx, GLint uXoff, GLint uXhalf) {
if (s_ws_ablate != 3) /* ablate 3: no FBO rebind (draws land in hr — perf probe) */
p_glBindFramebuffer(PSXGL_FRAMEBUFFER, g_wide_cur);
glViewport(0, 0, g_wide_w * s_scale, VRAM_H * s_scale);
/* Per-frame depth clear for THIS surface. The allocation-time clear only
* covers the first frame, and hr_begin clears the hr FBO only -- so with
* PGXP depth on, the wide margins would accumulate depth forever and
* progressively reject their own geometry. Armed at Swap, like hr_begin. */
if (s_pgxp_depth && s_wide_depth_clear) {
s_wide_depth_clear = 0;
glDisable(GL_SCISSOR_TEST);
glDepthMask(GL_TRUE);
glClearDepth(1.0);
glClear(GL_DEPTH_BUFFER_BIT);
}
glEnable(GL_SCISSOR_TEST);
{
int sy = s_area_y1, sh = s_area_y2 - s_area_y1 + 1;
@@ -4167,7 +4179,13 @@ static GLuint wide_fbo_for(int base_x) {
glClearColor(0, 0, 0, 0);
glClearStencil(0);
glStencilMask(0xFF);
glClear(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT);
glClearDepth(1.0);
glDepthMask(GL_TRUE);
/* Depth as well as colour and stencil. This surface carries its own
* depth attachment, and hr_begin only ever clears the hr FBO -- so with
* PGXP depth on, the wide margins would test against depth written
* before this allocation and never cleared again. */
glClear(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
p_glBindFramebuffer(PSXGL_FRAMEBUFFER, 0);
s_wide_base[i] = base_x;
return s_wide_fbo[i];
@@ -4962,6 +4980,7 @@ static void gl_swap_with_osd(void) {
* buffer. Set here rather than inferred from a counter another
* translation unit owns -- see hr_begin. */
s_depth_needs_clear = 1;
s_wide_depth_clear = 1;
if (s_present_prog && s_ctx) {
int ww = 0, wh = 0;
SDL_GL_GetDrawableSize(s_win, &ww, &wh);