mirror/psxrecomp
1
0
Fork 0
mirror of https://github.com/RetroPortingToolKit/psxrecomp synced 2026-10-27 02:32:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

docs: isolation resolves it — perspective textures ship, geometry correction does not

Browse Source 
Three runs on Ape Escape, same scene: off/off clean (the control, which also
clears the 92-commit framework and 64-commit UI jumps), geometry-only lines,
perspective-only clean.

perspective_texturing never moves a vertex — it only changes UV interpolation
inside a polygon with fully proven provenance — so neighbours cannot disagree
about a shared edge and nothing cracks. It is safe to ship.

geometry_correction moves vertices at ~5% coverage, so corrected and
uncorrected triangles meet along shared edges. The seams trace polygon
boundaries, confirming G1.4 and retiring G1.7's misread of the artifact as
scene-spanning lines. Not tunable; needs the full PGXP dataflow.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matthew Stanley
2026-08-05 16:18:30 -07:00
parent 60cc4657f5
commit c595c40f08
1 changed files with 29 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ENHANCEMENTS.md
+29
View File
@@ -709,3 +709,32 @@ precise_consumed() only on the GPU path — the `!s_raster_ok` software-fallback
branch returns EARLY without clearing s_pc_valid, so an override could be
applied to a primitive it was never computed for. That would displace a vertex
arbitrarily and produce exactly these long stretched lines.
### G1.8 — RESOLVED by isolation: perspective textures SHIP, geometry correction DOES NOT
The control run and the two isolation runs were finally done, on Ape Escape,
OpenGL, supersampling 2, same scene each time:
| geometry_correction | perspective_texturing | result |
|---|---|---|
| off | off | **clean** (the control — establishes the framework/UI jumps are NOT the cause) |
| **on** | off | **lines** |
| off | **on** | **clean** |
**`perspective_texturing` is good and should ship.** It is unaffected by the
coverage problem: it only alters UV interpolation inside a polygon whose
provenance is fully proven, so a polygon either gets perspective UVs or keeps
the PS1's affine ones. Neither outcome moves a vertex, so adjacent polygons
cannot disagree about a shared edge and nothing can crack.
**`geometry_correction` must not be offered.** It moves vertices, and at ~5%
coverage a corrected triangle meets an uncorrected neighbour along a shared
edge — the seams in the isolation run trace polygon boundaries, confirming
G1.4's mechanism (and retiring the "long scene-spanning lines" reading in G1.7,
which misjudged the artifact). It cannot be fixed by tuning: it needs the full
PGXP dataflow of G1.2/G1.3 to reach coverage where meshes move as one.
**Recommended disposition:** keep the `perspective_texturing` setting and its
launcher row; withdraw the `geometry_correction` row until value propagation
lands (leave the setting readable from game.toml/settings.toml so the work
stays testable, but do not present it to players).