mirror/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea synced 2026-10-25 14:01:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(ghidra): accept stock language IDs with LEBE endianness or a slash (#7070)

Browse Source 
REA_GHIDRA_LANGUAGE_ID only allowed LE or BE as the endian field and no '/' in the processor, so it rejected four language IDs that ship with Ghidra: ARM:LEBE:32:v7LEInstruction and v8LEInstruction (ARM BE8) and M16C/60:LE:16:default and M16C/80:LE:16:default. The syntax check now allows LEBE and a slash between processor name parts; the installed .ldefs catalog check is unchanged.
This commit is contained in:
Adolanium
2026-10-25 07:45:11 +02:00
committed by GitHub
parent 8e6a957886
commit 60ab148afa
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/config/ghidraLanguageOverride.ts
+3 -1
View File
@@ -13,10 +13,12 @@ export interface GhidraLanguageOverride {
// Ghidra language IDs are four colon-separated fields; variants may contain
// spaces ("x86:LE:16:Real Mode") but never leading or trailing whitespace.
// Stock .ldefs also use "/" in processors ("M16C/60") and LEBE for ARM BE8
// (big-endian data, little-endian instructions).
export const ghidraLanguageIdSchema = z
.string()
.regex(
/^[A-Za-z0-9_.+-]+:(?:LE|BE):[1-9]\d*:[A-Za-z0-9_.+-](?:[A-Za-z0-9_.+ -]*[A-Za-z0-9_.+-])?$/u,
/^[A-Za-z0-9_.+-]+(?:\/[A-Za-z0-9_.+-]+)*:(?:LE|BE|LEBE):[1-9]\d*:[A-Za-z0-9_.+-](?:[A-Za-z0-9_.+ -]*[A-Za-z0-9_.+-])?$/u,
"must be a Ghidra language ID such as x86:LE:32:default",
);
src/ghidra/GhidraLanguageOverride.test.ts
+19
View File
@@ -156,6 +156,25 @@ describe("Ghidra language override configuration", () => {
});
});
it.each([
"ARM:LEBE:32:v8LEInstruction",
"ARM:LEBE:32:v7LEInstruction",
"M16C/60:LE:16:default",
"M16C/80:LE:16:default",
])("accepts the stock Ghidra language ID %s", (languageId) => {
const parsed = parseConfig({ REA_GHIDRA_LANGUAGE_ID: languageId });
if (!parsed.ok) throw parsed.error;
expect(parsed.value.ghidraLanguageOverride).toEqual({ languageId });
});
it.each(["ARM:BELE:32:v8", "/x86:LE:32:default", "x86:LE:32:default "])(
"still refuses the malformed language ID %j",
(languageId) => {
const parsed = parseConfig({ REA_GHIDRA_LANGUAGE_ID: languageId });
expect(parsed.ok).toBe(false);
},
);
it("requires a language for a compiler spec, as analyzeHeadless does", () => {
const parsed = parseConfig({ REA_GHIDRA_COMPILER_SPEC_ID: "borlandcpp" });
if (parsed.ok) throw new Error("Expected a configuration error");