Decompile overlay 24 (Part 2) (#66)

* remove scratch links

* UnkAdventureModeSystem1 OK

* UnkStruct_ov024_020d8694_024 OK

* UnkTitleCardSystem1_024 99%

* UnkTitleCardSystem1_024 OK

* fix regressions

* title card vfunc_08 oddity

* tools: make build.ninja deterministic and delink when objdiff rebuild-on-change

* clean up link node mess

* UnkStruct_020d8698_024 24%

* UnkStruct_020d8698_024 49%

* UnkStruct_020d8698_024 65%

* fix build issues

* UnkStruct_020d8698_024 92%

* UnkStruct_020d8698_024 OK

* delink data_ov024_020d8694 symbol

* tools: revert previous objdiff change and reduce ds-rom logs on objdiff

include/Message/BMG.hpp

@@ -12,6 +12,7 @@
     ((u32) (pGroups)->entries[(flags) >> 0x10].pDAT1 + (BMG_GET_MSG_OFFSET((pGroups), (flags)) & ~1))
 
 #define BMG_ID(group, infIndex) (((group) << 16) | (infIndex))
+#define BMG_ID_NONE 0
 
 enum BMGGroup_ {
     BMGGroup_regular       = 0x00,
@@ -89,8 +90,8 @@ struct EntryINF1 {
     /* 00 */ u32 offset; // relative to the end of the DAT1 header
     /* 04 */ u8 mUnk_04; // flags/attributes? (+0x04 to +0x06)
     /* 05 */ u8 mUnk_05;
-    /* 06 */ u8 mUnk_06;
-    /* 07 */ u8 mUnk_07;
+    /* 06 */ u8 fontIndex; // see FontIndex enum
+    /* 07 */ s8 mUnk_07;
     /* 08 */
 };
 

include/Message/BMGEnums.hpp

@@ -188,6 +188,38 @@ enum MsgIndex_ {
     MsgIndex_ValleySanctuary,
     MsgIndex_DuneSanctuary,
     MsgIndex_BridgeWorkersHouse,
+
+#if IS_JP
+    //! TODO: add the indices from the other files so we can improve this
+    // BMGGroup_dungeon
+    MsgIndex_BossStagnox = 0x90,
+    MsgIndex_BossFraaz,
+    MsgIndex_BossCactops,
+    MsgIndex_BossVulcano,
+    MsgIndex_BossCapbone,
+
+    // BMGGroup_train_extra
+    MsgIndex_BossGhostTrain = 0x1A,
+
+    // BMGGroup_dungeon
+    MsgIndex_BossStaven = 0x95,
+    MsgIndex_BossMalladus1,
+    MsgIndex_BossMalladus2,
+
+    MsgIndex_GoronTargetRange = 0xB2,
+    MsgIndex_SnowdriftStation,
+    MsgIndex_LostAtSeaStation,
+    MsgIndex_DisorientationStation,
+    MsgIndex_EndsOfTheEarthStation,
+    MsgIndex_DarkOreMine,
+    MsgIndex_RabbitHaven,
+    MsgIndex_SlipperyStation,
+    MsgIndex_ThreeQuestionMarks,
+    MsgIndex_Floor1,
+    MsgIndex_Floor2,
+    MsgIndex_Floor3,
+    MsgIndex_ZeldaPhantomTooFar,
+#else
     MsgIndex_BossStagnox,
     MsgIndex_BossFraaz,
     MsgIndex_BossCactops,
@@ -202,7 +234,7 @@ enum MsgIndex_ {
     MsgIndex_LostAtSeaStation,
     MsgIndex_DisorientationStation,
     MsgIndex_EndsOfTheEarthStation,
-    MsgIndex_DarOreMine,
+    MsgIndex_DarkOreMine,
     MsgIndex_RabbitHaven,
     MsgIndex_SlipperyStation,
     MsgIndex_ThreeQuestionMarks,
@@ -210,4 +242,5 @@ enum MsgIndex_ {
     MsgIndex_Floor2,
     MsgIndex_Floor3,
     MsgIndex_ZeldaPhantomTooFar,
+#endif
 };