Merge branch 'main' into show12

Resolves conflicts in packages/superdough/sampler.mjs (merged imports and
getSampleInfo/getDuration additions from main) and website/src/settings.mjs
(non-overlapping additions auto-merged).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01559pA7fMAMyY9H91PaewXz

.forgejo/workflows/deploy-hot.yml

@@ -13,12 +13,16 @@ jobs:
   build:
     if: ${{ github.event.label.name == 'serve-hot' }}
     runs-on: docker
-    container: node:22-bookworm
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.sha }}
+          ref: ${{ github.event.pull_request.head.sha }}      
       - uses: pnpm/action-setup@v4
+        with:
+          version: 9.12.2
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
 
       - name: Install Dependencies
         run: pnpm install
@@ -37,4 +41,4 @@ jobs:
           ssh-keyscan matrix.toplap.org > ~/.ssh/known_hosts
           rsync -atv --delete --delete-after --progress \
             ./website/dist/ \
-            strudel@matrix.toplap.org:/home/strudel/deploy/pr-${{ github.event.pull_request.number }}.hot.strudel.cc
+            strudel@matrix.toplap.org:/home/strudel/deploy/pr-${{ github.event.pull_request.number }}.hot.strudel.cc

.forgejo/workflows/deploy-warm-beta.yml

@@ -13,13 +13,17 @@ concurrency:
 jobs:
   build:
     runs-on: docker
-    container: node:22-bookworm
     env:
       SSH_PRIVATE_KEY: ${{ secrets.SSH_PRIVATE_KEY }}
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4
-
+        with:
+          version: 9.12.2
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          # cache: "pnpm"
       - name: Install Dependencies
         run: pnpm install
 
@@ -33,4 +37,4 @@ jobs:
           apt update && apt install -y rsync
           mkdir ~/.ssh
           ssh-keyscan matrix.toplap.org  > ~/.ssh/known_hosts
-          rsync -atv --delete --delete-after --progress ./website/dist/ strudel@matrix.toplap.org:/home/strudel/deploy/strudel.cc
+          rsync -atv --delete --delete-after --progress ./website/dist/ strudel@matrix.toplap.org:/home/strudel/deploy/strudel.cc

.forgejo/workflows/deploy.yml

@@ -10,13 +10,17 @@ concurrency:
 jobs:
   build:
     runs-on: docker
-    container: node:22-bookworm
     env:
       SSH_PRIVATE_KEY: ${{ secrets.SSH_PRIVATE_KEY }}
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v4
-
+        with:
+          version: 9.12.2
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          # cache: "pnpm"
       - name: Install Dependencies
         run: pnpm install
 
@@ -30,4 +34,4 @@ jobs:
           apt update && apt install -y rsync
           mkdir ~/.ssh
           ssh-keyscan matrix.toplap.org  > ~/.ssh/known_hosts
-          rsync -atv --delete --delete-after --progress ./website/dist/ strudel@matrix.toplap.org:/home/strudel/deploy/cold.strudel.cc
+          rsync -atv --delete --delete-after --progress ./website/dist/ strudel@matrix.toplap.org:/home/strudel/deploy/cold.strudel.cc

.forgejo/workflows/test.yml

@@ -5,11 +5,21 @@ on: [push, pull_request]
 jobs:
   build:
     runs-on: docker
-    container: node:22-bookworm
+    strategy:
+      matrix:
+        node-version: [20]
 
     steps:
       - uses: actions/checkout@v4
+      - name: apt install ztd
+        run: apt update && apt install -y zstd
       - uses: pnpm/action-setup@v4
+        with:
+          version: 9.12.2
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: "pnpm"
       - run: pnpm install
       - run: pnpm run format-check
       - run: pnpm run lint

examples/codemirror-repl/main.js

@@ -16,7 +16,7 @@ const drawContext = canvas.getContext('2d');
 const drawTime = [-2, 2]; // time window of drawn haps
 
 const editor = new StrudelMirror({
-  onSchedule: webaudioOutput,
+  defaultOutput: webaudioOutput,
   getTime: () => getAudioContext().currentTime,
   transpiler,
   root: document.getElementById('editor'),

examples/minimal-repl/main.js

@@ -12,7 +12,7 @@ registerSynthSounds();
 evalScope(import('@strudel/core'), import('@strudel/mini'), import('@strudel/webaudio'), import('@strudel/tonal'));
 
 const { evaluate } = repl({
-  onSchedule: webaudioOutput,
+  defaultOutput: webaudioOutput,
   getTime: () => ctx.currentTime,
   transpiler,
 });

package.json

@@ -3,7 +3,6 @@
   "version": "0.5.0",
   "private": true,
   "description": "Port of tidalcycles to javascript",
-  "packageManager": "pnpm@10.15.0",
   "scripts": {
     "setup": "pnpm i",
     "pretest": "npm run jsdoc-json",

packages/codemirror/basicSetup.mjs

@@ -2,13 +2,23 @@ import {
   keymap,
   highlightSpecialChars,
   drawSelection,
+  highlightActiveLine,
   dropCursor,
   rectangularSelection,
   crosshairCursor,
+  lineNumbers,
+  highlightActiveLineGutter,
 } from '@codemirror/view';
-import { defaultHighlightStyle, syntaxHighlighting } from '@codemirror/language';
+import {
+  defaultHighlightStyle,
+  syntaxHighlighting,
+  bracketMatching,
+  foldGutter,
+  foldKeymap,
+} from '@codemirror/language';
 import { defaultKeymap, history, historyKeymap } from '@codemirror/commands';
-import { closeBracketsKeymap } from '@codemirror/autocomplete';
+import { searchKeymap, highlightSelectionMatches } from '@codemirror/search';
+import { completionKeymap, closeBracketsKeymap } from '@codemirror/autocomplete';
 
 // Taken + slightly modified from https://github.com/codemirror/basic-setup/blob/main/src/codemirror.ts
 

packages/codemirror/codemirror.mjs

@@ -11,6 +11,7 @@ import {
   keymap,
   lineNumbers,
 } from '@codemirror/view';
+import {repeatCharKeymap} from './repeatcharacter.mjs';
 import { persistentAtom } from '@nanostores/persistent';
 import { logger, registerControl, repl } from '@strudel/core';
 import { cleanupDraw, cleanupDrawContext, Drawer } from '@strudel/draw';
@@ -20,11 +21,16 @@ import { evalBlock } from './block_utilities.mjs';
 import { flash, isFlashEnabled } from './flash.mjs';
 import { highlightMiniLocations, isPatternHighlightingEnabled, updateMiniLocations } from './highlight.mjs';
 import { keybindings } from './keybindings.mjs';
-import { jumpToCharacter } from './labelJump.mjs';
 import { getSliderWidgets, sliderPlugin, updateSliderWidgets } from './slider.mjs';
 import { activateTheme, initTheme, theme } from './themes.mjs';
 import { isTooltipEnabled } from './tooltip.mjs';
 import { getActiveWidgets, updateWidgets, widgetPlugin } from './widget.mjs';
+import {
+  deleteAllInlineBeforeCharacter,
+  InsertCharBeforeChar,
+  jumpToCharacter,
+  jumpToNextCharacter,
+} from './labelJump.mjs';
 
 export { toggleBlockComment, toggleBlockCommentByLine, toggleComment, toggleLineComment } from '@codemirror/commands';
 
@@ -44,9 +50,9 @@ export const extensions = {
   isMultiCursorEnabled: (on) =>
     on
       ? [
-          EditorState.allowMultipleSelections.of(true),
-          EditorView.clickAddsSelectionRange.of((ev) => ev.metaKey || ev.ctrlKey),
-        ]
+        EditorState.allowMultipleSelections.of(true),
+        EditorView.clickAddsSelectionRange.of((ev) => ev.metaKey || ev.ctrlKey),
+      ]
       : [],
 };
 export const compartments = Object.fromEntries(Object.keys(extensions).map((key) => [key, new Compartment()]));
@@ -75,6 +81,10 @@ export const codemirrorSettings = persistentAtom('codemirror-settings', defaultS
   decode: JSON.parse,
 });
 
+const ANON_LABEL = '$';
+const SOLO_LABEL = 'S';
+const MUTE_LABEL = '_';
+
 // https://codemirror.net/docs/guide/
 export function initEditor({ initialCode = '', onChange, onEvaluate, onStop, root, mondo, strudelMirror }) {
   const settings = codemirrorSettings.get();
@@ -102,6 +112,7 @@ export function initEditor({ initialCode = '', onChange, onEvaluate, onStop, roo
       syntaxHighlighting(defaultHighlightStyle),
       EditorView.updateListener.of((v) => onChange(v)),
       drawSelection({ cursorBlinkRate: 0 }),
+      repeatCharKeymap,
       Prec.highest(
         keymap.of([
           {
@@ -138,12 +149,74 @@ export function initEditor({ initialCode = '', onChange, onEvaluate, onStop, roo
           },
           {
             key: 'Alt-w',
-            run: (view) => jumpToCharacter(view, '$', 1),
+            run: (view) => jumpToNextCharacter(view, ANON_LABEL, 1),
           },
           {
             key: 'Alt-q',
-            run: (view) => jumpToCharacter(view, '$', -1),
+            run: (view) => {
+              return jumpToNextCharacter(view, ANON_LABEL, -1);
+            },
           },
+          // clear all muted
+          {
+            key: `Alt-Ctrl-0`,
+            run: (view) => {
+              return deleteAllInlineBeforeCharacter(view, MUTE_LABEL + ANON_LABEL);
+            },
+          },
+          // clear all solod
+          {
+            key: `Alt-Shift-0`,
+            run: (view) => {
+              return deleteAllInlineBeforeCharacter(view, SOLO_LABEL + ANON_LABEL);
+            },
+          },
+          // clear all solo and mute
+          {
+            key: `Ctrl-Shift-0`,
+            run: (view) => {
+              return deleteAllInlineBeforeCharacter(view, ANON_LABEL);
+            },
+          },
+          ...Array.from({ length: 9 }).map((_, i) => {
+            let num = i + 1;
+            return {
+              key: `Alt-${num}`,
+              run: (view) => {
+                return jumpToCharacter(view, ANON_LABEL, i);
+              },
+            };
+          }),
+          // handle solo toggles 1-9
+          ...Array.from({ length: 9 }).map((_, i) => {
+            let num = i + 1;
+            return {
+              key: `Alt-Shift-${num}`,
+              run: (view) => {
+                return InsertCharBeforeChar(view, ANON_LABEL, SOLO_LABEL, i);
+              },
+            };
+          }),
+          // handle mute toggles 1-9
+          ...Array.from({ length: 9 }).map((_, i) => {
+            let num = i + 1;
+            return {
+              key: `Alt-Ctrl-${num}`,
+              run: (view) => {
+                return InsertCharBeforeChar(view, ANON_LABEL, MUTE_LABEL, i);
+              },
+            };
+          }),
+          // Handle clearing mutes and solos 1-9
+          ...Array.from({ length: 9 }).map((_, i) => {
+            let num = i + 1;
+            return {
+              key: `Ctrl-Shift-${num}`,
+              run: (view) => {
+                return InsertCharBeforeChar(view, ANON_LABEL, '', i);
+              },
+            };
+          }),
           /* {
             key: 'Ctrl-Shift-.',
             run: () => (onPanic ? onPanic() : onStop?.()),

packages/codemirror/labelJump.mjs

@@ -1,18 +1,54 @@
 import { EditorSelection } from '@codemirror/state';
 import { SearchCursor } from '@codemirror/search';
+import { EditorView } from '@codemirror/view';
+import { syntaxTree } from '@codemirror/language';
 
-export function jumpToCharacter(view, character, direction = 1) {
+/**
+ * gets all of the positions of a character in a document, excluding commented out lines
+ * @param { EditorState} state 
+ * @param {String} character 
+ * @returns {number[]}
+ */
+function getCharacterPositions(state, character) {
+  const cursor = new SearchCursor(state.doc, character);
+ 
+  const characterPositions = [];
+  while (!cursor.next().done) {
+
+    const linestartpos = state.doc.lineAt(cursor.value.to).from
+    if (!isLineCommentedOut(state, linestartpos)) {
+
+      characterPositions.push(cursor.value.to);
+    }
+  }
+  return characterPositions;
+}
+
+function isLineCommentedOut(state, pos) {
+
+  const line = state.doc.lineAt(pos);
+  // remove white space
+  pos = line.from + line.text.search(/\S/)
+
+  const tree = syntaxTree(state);
+  const node = tree.resolveInner(pos, 1)
+  return node.name.includes("Comment")
+}
+
+/**
+ * jump to the next character in a document
+ * @param {EditorView} view 
+ * @param {String} character 
+ * @param {number} direction 0 or 1
+ * @returns {boolean}
+ */
+export function jumpToNextCharacter(view, character, direction = 1) {
   const { state, dispatch } = view;
   const pos = state.selection.main.head;
-  const cursor = new SearchCursor(state.doc, character);
-
-  let characterPositions = [];
   let jumpPos;
-  while (!cursor.next().done) {
-    characterPositions.push(cursor.value.to);
-  }
+  const characterPositions = getCharacterPositions(state, character);
   if (!characterPositions.length) {
-    return false;
+    return true;
   }
   if (direction > 0) {
     jumpPos = characterPositions.find((x) => x > pos + 1) ?? characterPositions.at(0); // Loop back around for convenience
@@ -21,11 +57,97 @@ export function jumpToCharacter(view, character, direction = 1) {
   }
 
   if (jumpPos == null) {
-    return false;
+    return true;
   }
+  const selection = EditorSelection.cursor(jumpPos - 1);
   dispatch({
-    selection: EditorSelection.cursor(jumpPos - 1),
-    scrollIntoView: true,
+    selection,
+    effects: EditorView.scrollIntoView(
+      selection.head,
+      { y: "start" }
+    )
   });
   return true;
 }
+/**
+ * 
+ * @param {EditorView} view 
+ * @param {String} character 
+ * @param {number} index the instance of the character  
+ * @returns {true}
+ */
+export function jumpToCharacter(view, character, index) {
+  const { state, dispatch } = view;
+  const characterPositions = getCharacterPositions(state, character);
+  const pos = characterPositions.at(index) ?? characterPositions.at(-1);
+  if (pos == null) {
+    return true;
+  }
+
+  const selection = EditorSelection.cursor(pos - 1);
+  dispatch({
+    selection,
+    effects: EditorView.scrollIntoView(
+      selection.head,
+      { y: "start" }
+    )
+  });
+  return true;
+}
+/**
+ * 
+ * @param {EditorView} view 
+ * @param {String} character 
+ * @returns {true}
+ */
+export function deleteAllInlineBeforeCharacter(view, character) {
+  const { state, dispatch } = view;
+  const characterPositions = getCharacterPositions(state, character);
+
+  const changes = [];
+  characterPositions.forEach((pos) => {
+    const line = state.doc.lineAt(pos);
+    if (state.doc.sliceString(line.from, line.from + 2) === COMMENT_STRING) {
+      return;
+    }
+    changes.push({
+      from: line.from,
+      to: pos - 1,
+      insert: '',
+    });
+  });
+  dispatch({ changes });
+  return true;
+}
+
+/**
+ * 
+ * @param {EditorView} view 
+ * @param {String} character 
+ * @param {String} character2 
+ * @param {number} index 
+ * @returns {true}
+ */
+export function InsertCharBeforeChar(view, character, character2, index) {
+  const { state, dispatch } = view;
+
+  const changes = [];
+  const characterPositions = getCharacterPositions(state, character);
+  const labelpos = characterPositions.at(index) ?? characterPositions.at(-1);
+  const line = state.doc.lineAt(labelpos);
+
+  //delete preceeding characters
+  changes.push({
+    from: line.from,
+    to: labelpos - 1,
+    insert: '',
+  });
+
+  changes.push({
+    insert: character2,
+    from: line.from,
+  });
+
+  dispatch({ changes });
+  return true;
+}

packages/codemirror/repeatcharacter.mjs

@@ -0,0 +1,55 @@
+import { Compartment } from "@codemirror/state";
+import { keymap } from "@codemirror/view";
+
+const repeatMode = new Compartment();
+
+function repeatPreviousChar(times) {
+  return ({ state, dispatch }) => {
+    const { from, empty } = state.selection.main;
+    if (!empty || from === 0) return false;
+
+    const prevChar = state.doc.sliceString(from - 1, from);
+    const text = Array(times).fill(prevChar).join(" ");
+
+    dispatch(state.update({
+      changes: {
+        from,
+        insert: " " + text
+      }
+    }));
+
+    return true;
+  };
+}
+
+function exitRepeatMode(view) {
+  view.dispatch({
+    effects: repeatMode.reconfigure([])
+  });
+}
+
+const digitBindings = Array.from({ length: 9 }, (_, i) => ({
+  key: String(i + 1),
+  run(view) {
+    repeatPreviousChar(i + 1)(view);
+    exitRepeatMode(view);
+    return true;
+  }
+}));
+
+export const repeatCharKeymap = [
+    
+  repeatMode.of([]),
+
+  keymap.of([
+    {
+      key: "Alt-r",
+      run(view) {
+        view.dispatch({
+          effects: repeatMode.reconfigure(keymap.of(digitBindings))
+        });
+        return true;
+      }
+    }
+  ])
+];

packages/core/controls.mjs

@@ -118,7 +118,7 @@ export const { s, sound } = registerControl(['s', 'n', 'gain'], 'sound');
  * @param {number | Pattern} position Position in the wavetable from 0 to 1
  * @synonyms wavetablePosition
  * @example
- * s("wt_digital").seg(8).note("F1").wt("0 0.25 0.5 0.75 1")
+ * s("squelch").bank("wt_digital").seg(8).note("F1").wt("0 0.25 0.5 0.75 1")
  */
 export const { wt, wavetablePosition } = registerControl('wt', 'wavetablePosition');
 
@@ -519,10 +519,10 @@ export const { fmh, fmh1, fmh2, fmh3, fmh4, fmh5, fmh6, fmh7, fmh8 } = registerM
  * each other with matrix commands like `fm13`, which would send `fm1` back into
  * `fm3`
  *
- * @name fm
+ * @name fmi
  * @tags fm, superdough, supradough
  * @param {number | Pattern} brightness modulation index
- * @synonyms fmi
+ * @synonyms fm
  * @example
  * note("c e g b g e")
  * .fm("<0 1 2 8 32>")
@@ -1988,10 +1988,11 @@ export const { spread } = registerControl('spread');
  * Set dryness of reverb. See `room` and `size` for more information about reverb.
  *
  * @name dry
- * @tags superdirt, superdough
+ * @tags superdirt
  * @param {number | Pattern} dry 0 = wet, 1 = dry
  * @example
  * n("[0,3,7](3,8)").s("superpiano").room(.7).dry("<0 .5 .75 1>").osc()
+ * @superdirtOnly
  *
  */
 export const { dry } = registerControl('dry');
@@ -2225,7 +2226,7 @@ export const { orbit } = registerControl('orbit', 'o');
  *   otherPat.bmod(..) (to modulate another pattern with the bus)
  *
  * @name bus
- * @tags superdough
+ * @tags superdirt
  * @param {number | Pattern} number
  */
 export const { bus } = registerControl('bus');
@@ -2234,7 +2235,7 @@ export const { bus } = registerControl('bus');
  * Postgain multiplier prior to sending the signal to the audio bus.
  *
  * @name busgain
- * @tags superdough
+ * @tags superdirt
  * @synonyms bgain
  * @param {number | Pattern} number
  */
@@ -2376,7 +2377,7 @@ export const { mode } = registerControl(['mode', 'anchor']);
  *
  * @name room
  * @tags orbit, superdough
- * @param {number | Pattern} level
+ * @param {number | Pattern} level between 0 and 1
  * @example
  * s("bd sd [~ bd] sd").room("<0 .2 .4 .6 .8 1>")
  * @example

packages/core/cyclist.mjs

@@ -10,7 +10,6 @@ import { errorLogger, logger } from './logger.mjs';
 export class Cyclist {
   constructor({
     interval,
-    onSchedule,
     onTrigger,
     onToggle,
     onError,
@@ -20,11 +19,6 @@ export class Cyclist {
     clearInterval,
     beforeStart,
   }) {
-    if (onTrigger) {
-      throw new Error(
-        'onTrigger has been dropped. use onSchedule(hap, time, cps) instead, see https://codeberg.org/uzu/strudel/pulls/2138',
-      );
-    }
     this.started = false;
     this.beforeStart = beforeStart;
     this.cps = 0.5;
@@ -69,7 +63,12 @@ export class Cyclist {
             if (hap.hasOnset()) {
               const targetTime =
                 (hap.whole.begin - this.num_cycles_at_cps_change) / this.cps + this.seconds_at_cps_change + latency;
-              onSchedule?.(hap, targetTime, this.cps);
+              const duration = hap.duration / this.cps;
+              // the following line is dumb and only here for backwards compatibility
+              // see https://codeberg.org/uzu/strudel/pulls/1004
+              const deadline = targetTime - phase;
+              // this onTrigger has another signature
+              onTrigger?.(hap, deadline, duration, this.cps, targetTime);
               if (hap.value.cps !== undefined && this.cps != hap.value.cps) {
                 this.cps = hap.value.cps;
                 this.num_ticks_since_cps_change = 0;

packages/core/euclid.mjs

@@ -59,11 +59,6 @@ export const bjorklund = function (ons, steps) {
  * really useful for computer/algorithmic music because they can
  * describe a large number of rhythms with a couple of numbers.
  *
- * A negative number of pulses inverts the pattern
- * so pulses happen in the gaps of the normal euclidean rhythm.
- *
- * A negative number of steps changes it into `euclidLegato`.
- *
  * @memberof Pattern
  * @name euclid
  * @tags temporal
@@ -142,38 +137,8 @@ const _euclidRot = function (pulses, steps, rotation) {
   return b;
 };
 
-const _euclidLegato = function (pulses, steps, rotation, pat) {
-  var bin_pat = _euclidRot(pulses, steps, 0);
-  // Because the `gapless` algorithm logic assumes the first entry in bin_pat is a 1,
-  // we rotate the pattern so the first onset is at the start.
-  const firstOnset = bin_pat.indexOf(1);
-  bin_pat = rotate(bin_pat, firstOnset);
-  steps = Math.abs(steps);
-  const gapless = bin_pat
-    .join('')
-    .split('1')
-    .slice(1)
-    .map((s) => [s.length + 1, true]);
-  return pat.struct(timeCat(...gapless).late(Fraction(rotation + firstOnset).div(steps)));
-};
-
-const _euclid = function (pulses, steps, rotation, pat) {
-  if (steps === 0 || pulses === 0) {
-    return silence;
-  }
-  const cycles = Math.ceil(Math.abs(pulses) / Math.abs(steps));
-  const totalSteps = cycles * steps;
-  if (totalSteps < 0) {
-    return _euclidLegato(pulses, -totalSteps, rotation, pat.fast(cycles)).slow(cycles);
-  }
-  return pat
-    .fast(cycles)
-    .struct(_euclidRot(pulses, totalSteps, rotation))
-    .slow(cycles);
-};
-
 export const euclid = register('euclid', function (pulses, steps, pat) {
-  return _euclid(pulses, steps, 0, pat);
+  return pat.struct(_euclidRot(pulses, steps, 0));
 });
 
 export const bjork = register('bjork', function (euc, pat) {
@@ -181,18 +146,16 @@ export const bjork = register('bjork', function (euc, pat) {
     euc = [euc];
   }
   const [pulses, steps = pulses, rot = 0] = euc;
-  return _euclid(pulses, steps, rot, pat);
+  return pat.struct(_euclidRot(pulses, steps, rot));
 });
 
 export const { euclidrot, euclidRot } = register(['euclidrot', 'euclidRot'], function (pulses, steps, rotation, pat) {
-  return _euclid(pulses, steps, rotation, pat);
+  return pat.struct(_euclidRot(pulses, steps, rotation));
 });
 
 /**
  * Similar to `euclid`, but each pulse is held until the next pulse,
  * so there will be no gaps.
- *
- * A negative number of steps changes it into `euclid`.
  * @name euclidLegato
  * @memberof Pattern
  * @tags temporal
@@ -204,16 +167,27 @@ export const { euclidrot, euclidRot } = register(['euclidrot', 'euclidRot'], fun
  * note("c3").euclidLegato(3,8)
  */
 
+const _euclidLegato = function (pulses, steps, rotation, pat) {
+  if (pulses < 1) {
+    return silence;
+  }
+  const bin_pat = _euclidRot(pulses, steps, 0);
+  const gapless = bin_pat
+    .join('')
+    .split('1')
+    .slice(1)
+    .map((s) => [s.length + 1, true]);
+  return pat.struct(timeCat(...gapless)).late(Fraction(rotation).div(steps));
+};
+
 export const euclidLegato = register(['euclidLegato'], function (pulses, steps, pat) {
-  return _euclid(pulses, -steps, 0, pat);
+  return _euclidLegato(pulses, steps, 0, pat);
 });
 
 /**
  * Similar to `euclid`, but each pulse is held until the next pulse,
  * so there will be no gaps, and has an additional parameter for 'rotating'
- * the resulting sequence.
- *
- * A negative number of steps changes it into `euclidRot`.
+ * the resulting sequence
  * @name euclidLegatoRot
  * @memberof Pattern
  * @tags temporal
@@ -224,7 +198,7 @@ export const euclidLegato = register(['euclidLegato'], function (pulses, steps,
  * note("c3").euclidLegatoRot(3,5,2)
  */
 export const euclidLegatoRot = register(['euclidLegatoRot'], function (pulses, steps, rotation, pat) {
-  return _euclid(pulses, -steps, rotation, pat);
+  return _euclidLegato(pulses, steps, rotation, pat);
 });
 
 /**

packages/core/neocyclist.mjs

@@ -8,12 +8,7 @@ import { logger } from './logger.mjs';
 import { ClockCollator, cycleToSeconds } from './util.mjs';
 
 export class NeoCyclist {
-  constructor({ onSchedule, onToggle, getTime, onTrigger }) {
-    if (onTrigger) {
-      throw new Error(
-        'onTrigger has been dropped. use onSchedule(hap, time, cps) instead, see https://codeberg.org/uzu/strudel/pulls/2138',
-      );
-    }
+  constructor({ onTrigger, onToggle, getTime }) {
     this.started = false;
     this.cps = 0.5;
     this.getTime = getTime; // get absolute time
@@ -48,7 +43,8 @@ export class NeoCyclist {
         if (hap.hasOnset()) {
           const timeUntilTrigger = cycleToSeconds(hap.whole.begin - this.cycle, this.cps);
           const targetTime = timeUntilTrigger + currentTime + this.latency;
-          onSchedule?.(hap, targetTime, this.cps);
+          const duration = cycleToSeconds(hap.duration, this.cps);
+          onTrigger?.(hap, 0, duration, this.cps, targetTime);
         }
       });
     };

packages/core/pattern.mjs

@@ -27,7 +27,6 @@ import {
 import drawLine from './drawLine.mjs';
 import { errorLogger, logger } from './logger.mjs';
 import { strudelScope } from './evaluate.mjs';
-import { getClockTime } from './schedulerState.mjs';
 
 let stringParser;
 
@@ -505,25 +504,10 @@ export class Pattern {
 
   /**
    * Returns a new pattern with the given function applied to the list of haps returned by every query.
-   *
-   * As an end user, you will most likely not need to use this; look at `withContext`, `withHapSpan`, etc. instead.
    * @tags internals
    * @param {Function} func
    * @returns Pattern
    * @noAutocomplete
-   * @example
-   * note("[a b, c d] a b c d").s("gm_piano").withHaps(x=>{
-   *   if (x.length > 1) {
-   *     x = x.map(hap => hap.withValue(val => {
-   *       return {
-   *         n: 1,
-   *         // select gm_piano:1 sample
-   *         ...val
-   *       }
-   *     }));
-   *   }
-   *   return x
-   * })
    */
   withHaps(func) {
     const result = new Pattern((state) => func(this.query(state), state));
@@ -533,23 +517,10 @@ export class Pattern {
 
   /**
    * As with `withHaps`, but applies the function to every hap, rather than every list of haps.
-   *
-   * As an end user, you will most likely not need to use this; look at `withContext`, `withHapSpan`, etc. instead.
    * @tags internals
    * @param {Function} func
    * @returns Pattern
    * @noAutocomplete
-   * @example
-   * note("c a f e").withHap(x=>{
-   *   if (x.value.note == 'c') {
-   *     x.value.s = 'gm_piano'
-   *   }
-   *   else {
-   *     x.value.s = 'gm_piano'
-   *     x.value.n = 2
-   *   }
-   *   return x
-   * })
    */
   withHap(func) {
     return this.withHaps((haps) => haps.map(func));
@@ -879,26 +850,6 @@ export class Pattern {
     return stack(this, ...pats);
   }
 
-  stackLeft(...pats) {
-    return stackLeft(this, ...pats);
-  }
-
-  stackRight(...pats) {
-    return stackRight(this, ...pats);
-  }
-
-  stackCenter(...pats) {
-    return stackCenter(this, ...pats);
-  }
-
-  stackCentre(...pats) {
-    return stackCentre(this, ...pats);
-  }
-
-  stackRepeat(...pats) {
-    return stackRepeat(this, ...pats);
-  }
-
   sequence(...pats) {
     return sequence(this, ...pats);
   }
@@ -921,41 +872,23 @@ export class Pattern {
   //////////////////////////////////////////////////////////////////////
   // Context methods - ones that deal with metadata
 
-  /**
-   * Attaches a function that is called for each hap onset.
-   * @name onSchedule
-   * @memberof Pattern
-   * @example
-   * s("bd sd").onSchedule((hap, time, cps) => {
-   *   console.log('hap scheduled', time, cps);
-   * })
-   */
-  onSchedule(onSchedule, dominant = true) {
+  onTrigger(onTrigger, dominant = true) {
     return this.withHap((hap) =>
       hap.setContext({
         ...hap.context,
-        onSchedule: (scheduleHap, t, cps) => {
+        onTrigger: (...args) => {
           // run previously set trigger, if it exists
-          hap.context.onSchedule?.(scheduleHap, t, cps);
-          onSchedule(scheduleHap, t, cps);
+          hap.context.onTrigger?.(...args);
+          onTrigger(...args);
         },
-        // if dominantSchedule is set to true, the default output (webaudio) will be disabled
+        // if dominantTrigger is set to true, the default output (webaudio) will be disabled
         // when using multiple triggers, you cannot flip this flag to false again!
         // example: x.csound('CooLSynth').log() as well as x.log().csound('CooLSynth') should work the same
-        dominantSchedule: hap.context.dominantSchedule || dominant,
+        dominantTrigger: hap.context.dominantTrigger || dominant,
       }),
     );
   }
 
-  // legacy:
-  onTrigger(onTrigger, dominant = true) {
-    console.warn('onTrigger is deprecated.. use onSchedule(hap, time, cps) instead');
-    return this.onSchedule((hap, t, cps) => {
-      const currentTime = getClockTime();
-      return onTrigger(hap, currentTime, cps, t);
-    }, dominant);
-  }
-
   /**
    * Writes the content of the current event to the console (visible in the side menu).
    * @tags visualization
@@ -965,7 +898,7 @@ export class Pattern {
    * s("bd sd").log()
    */
   log(func = (hap) => `[hap] ${hap.showWhole(true)}`, getData = (hap) => ({ hap })) {
-    return this.onSchedule((...args) => {
+    return this.onTrigger((...args) => {
       logger(func(...args), undefined, getData(...args));
     }, false);
   }
@@ -1141,7 +1074,7 @@ const COMPOSERS = {
    * @param {Pattern} pat
    * @returns {Pattern}
    * @memberof Pattern
-   * @tags internals, combiners
+   * @tags internal, combiners
    * @example
    * // because input pattern has `s` set,
    * // it overrides the "sine" declared earlier
@@ -1166,7 +1099,7 @@ const COMPOSERS = {
    * @param {Pattern} pat
    * @memberof Pattern
    * @returns {Pattern}
-   * @tags internals, combiners
+   * @tags internal, combiners
    * @example
    * // notes, already defined, will stay "c a f e",
    * // while "s", not defined, will be set to "piano"
@@ -1223,163 +1156,24 @@ const COMPOSERS = {
    * @tags math
    */
   div: [numeralArgs((a, b) => a / b)],
-  /**
-   *
-   * Divides each number by the given factor and returns the remainder
-   * @name mod
-   * @memberof Pattern
-   * @tags math
-   */
   mod: [numeralArgs(_mod)],
-  /**
-   *
-   * Raises each number to the power of the given factor
-   * @name pow
-   * @memberof Pattern
-   * @tags math
-   */
   pow: [numeralArgs(Math.pow)],
-  /**
-   *
-   * Performs a bitwise `and` on each number and the given factor
-   * @name band
-   * @memberof Pattern
-   * @tags math
-   */
   band: [numeralArgs((a, b) => a & b)],
-  /**
-   *
-   * Performs a bitwise `or` on each number and the given factor
-   * @name bor
-   * @memberof Pattern
-   * @tags math
-   */
   bor: [numeralArgs((a, b) => a | b)],
-  /**
-   *
-   * Performs a bitwise `xor` on each number and the given factor
-   * @name bxor
-   * @memberof Pattern
-   * @tags math
-   */
   bxor: [numeralArgs((a, b) => a ^ b)],
-  /**
-   *
-   * Performs a bitwise `left shift` on each number by the given factor
-   * @name blshift
-   * @memberof Pattern
-   * @tags math
-   */
   blshift: [numeralArgs((a, b) => a << b)],
-  /**
-   *
-   * Performs a bitwise `right shift` on each number by the given factor
-   * @name brshift
-   * @memberof Pattern
-   * @tags math
-   */
   brshift: [numeralArgs((a, b) => a >> b)],
 
   // TODO - force numerical comparison if both look like numbers?
-  /**
-   * performs a < b
-   * @name lt
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   lt: [(a, b) => a < b],
-  /**
-   * performs a > b
-   * @name gt
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   gt: [(a, b) => a > b],
-  /**
-   * performs a <= b
-   * @name lte
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   lte: [(a, b) => a <= b],
-  /**
-   * performs a >= b
-   * @name gte
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   gte: [(a, b) => a >= b],
-  /**
-   * performs a == b
-   * @name eq
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   eq: [(a, b) => a == b],
-  /**
-   * performs a === b (strictly equal)
-   * @name eqt
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   eqt: [(a, b) => a === b],
-  /**
-   * performs a != b
-   * @name ne
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   ne: [(a, b) => a != b],
-  /**
-   * performs a !== b (strictly not equal)
-   * @name net
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   net: [(a, b) => a !== b],
-  /**
-   * performs a && b
-   * @name and
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   and: [(a, b) => a && b],
-  /**
-   * performs a || b
-   * @name or
-   * @memberof Pattern
-   * @tags math
-   * @param {any} a
-   * @param {any} b
-   * @returns Pattern with boolean value(s)
-   */
   or: [(a, b) => a || b],
 
   //  bitwise ops
@@ -1655,19 +1449,7 @@ export function sequenceP(pats) {
 export function stack(...pats) {
   // Array test here is to avoid infinite recursions..
   pats = pats.map((pat) => (Array.isArray(pat) ? sequence(...pat) : reify(pat)));
-  const query = (state) =>
-    flatten(
-      pats.map((pat) => {
-        try {
-          // An error occurring in one part of the stack should not break
-          // playback of the other parts of the stack.
-          return pat.query(state);
-        } catch (e) {
-          errorLogger(e);
-          return [];
-        }
-      }),
-    );
+  const query = (state) => flatten(pats.map((pat) => pat.query(state)));
   const result = new Pattern(query);
   if (__steps) {
     result._steps = lcm(...pats.map((pat) => pat._steps));
@@ -1688,18 +1470,6 @@ function _stackWith(func, pats) {
   return stack(...func(steps, pats));
 }
 
-/**
- * The input patterns are aligned to the left, with silence padded to the shorter pattern(s) in the final steps if there's a stepcount disparity. See also `stackRight` and `stackCenter/stackCentre`
- *
- * @name stackLeft
- * @tags temporal, stepwise, combiners
- * @return {Pattern}
- * @example
- * stackLeft("0 1 2 3", "3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- * @example
- * // chainable
- * "0 1 2 3".stackLeft("3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- */
 export function stackLeft(...pats) {
   return _stackWith(
     (steps, pats) => pats.map((pat) => (pat._steps.eq(steps) ? pat : stepcat(pat, gap(steps.sub(pat._steps))))),
@@ -1707,18 +1477,6 @@ export function stackLeft(...pats) {
   );
 }
 
-/**
- * The input patterns are aligned to the right, with silence padded to the shorter pattern(s) in the initial steps if there's a stepcount disparity. See also `stackLeft` and `stackCenter/stackCentre`
- *
- * @name stackRight
- * @tags temporal, stepwise, combiners
- * @return {Pattern}
- * @example
- * stackRight("0 1 2 3", "3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- * @example
- * // chainable
- * "0 1 2 3".stackRight("3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- */
 export function stackRight(...pats) {
   return _stackWith(
     (steps, pats) => pats.map((pat) => (pat._steps.eq(steps) ? pat : stepcat(gap(steps.sub(pat._steps)), pat))),
@@ -1726,19 +1484,7 @@ export function stackRight(...pats) {
   );
 }
 
-/**
- * The input patterns are aligned to the right, with silence padded to the shorter pattern(s) in the initial steps if there's a stepcount disparity. See also `stackLeft` and `stackRight`
- * @name stackCenter
- * @tags temporal, stepwise, combiners
- * @synonyms stackCentre
- * @return {Pattern}
- * @example
- * stackCenter("0 1 2 3", "3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- * @example
- * // chainable
- * "0 1 2 3".stackCenter("3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- */
-export function stackCenter(...pats) {
+export function stackCentre(...pats) {
   return _stackWith(
     (steps, pats) =>
       pats.map((pat) => {
@@ -1752,25 +1498,6 @@ export function stackCenter(...pats) {
   );
 }
 
-export function stackCentre(...pats) {
-  return stackCenter(...pats);
-}
-
-/**
- * Shorthand for `pm(patterns).pace(m)` where m is the max step count in the input patterns
- * @name stackRepeat
- * @tags temporal, stepwise, combiners
- * @return {Pattern}
- * @example
- * stackRepeat("0 1 2 3", "3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- * @example
- * // chainable
- * "0 1 2 3".stackRepeat("3 4", "[4 5 6] 7 8 9 10").scale("c:minor").note()
- */
-export function stackRepeat(...pats) {
-  return stackBy(reify('repeat'), ...pats);
-}
-
 export function stackBy(by, ...pats) {
   const [left, ...right] = pats.map((pat) => pat._steps);
   const steps = left.maximum(...right);
@@ -1885,10 +1612,10 @@ export function arrange(...sections) {
  * @tags combiners
  * @return {Pattern}
  * @example
- * seqPLoop(
- * [0, 2, "bd(3,8)"],
- * [1, 3, "cp(3,8)"]
- * ).sound()
+seqPLoop(
+  [0, 2, "bd(3,8)"],
+  [1, 3, "cp(3,8)"]
+).sound()
  */
 export function seqPLoop(...parts) {
   let total = Fraction(0);
@@ -2354,8 +2081,8 @@ export const ply = register('ply', function (factor, pat) {
  * @example
  * s("bd hh sd hh").fast(2) // s("[bd hh sd hh]*2")
  */
-export const fast = register(
-  'fast',
+export const { fast, density } = register(
+  ['fast', 'density'],
   function (factor, pat) {
     if (factor === 0) {
       return silence;
@@ -2565,11 +2292,11 @@ export const { zoomArc, zoomarc } = register(['zoomArc', 'zoomarc'], function (a
  * @param {number} slices to play
  * @example
  * note("0 1 2 3 4 5 6 7".scale('c:mixolydian'))
- * .bite(4, "3 2 1 0")
+ *.bite(4, "3 2 1 0")
  * @example
  * sound("bd - bd bd*2, - sd:6 - sd:5 sd:1 - [- sd:2] -, hh [- cp:7]")
- * .bank("RolandTR909").speed(1.2)
- * .bite(4, "0 0 [1 2] <3 2> 0 0 [2 1] 3")
+  .bank("RolandTR909").speed(1.2)
+  .bite(4, "0 0 [1 2] <3 2> 0 0 [2 1] 3")
  */
 export const bite = register(
   'bite',
@@ -2586,74 +2313,6 @@ export const bite = register(
   false,
 );
 
-/**
- * Similar to `struct`, but every hap in the structure pattern plays the next
- * cycle of the main pattern.
- * With a different number of cycles in the main pattern and haps in the
- * structure pattern, this creates an isorhythm.
- *
- * Note: This function works on the assumption that the structure pattern
- * repeats every cycle. If the structure pattern only repeats after multiple
- * cycles, it may skip or repeat certain parts of the melody.
- * @tags temporal
- * @name isobite
- * @synonyms cycleStruct, cyclestruct
- * @memberof Pattern
- * @param {Pattern} structure structure of the pattern
- * @example
- * "<0 1 2 3 4 5>".isobite("[x - x*2]*2").n().scale("c:major")
- * // the same as "0 - [1 2] 3 - [4 5]".n().scale("c:major")
- *
- * @example
- * "<0 1 2 3 4>".isobite("x - x").n().scale("c:major")
- * // the same as "<[0 - 1] [2 - 3] [4 - 0] [1 - 2] [3 - 4]>".n().scale("c:major")
- *
- * @example
- * // Here the structure pattern repeats after 2 cycles,
- * // so certain haps from the melody are skipped.
- * "<0 1 2 3>".isobite("x x*2".slow(2)).n().scale("c:major")
- * // the same as "<[0] [2 3] [2] [2 3]>".n().scale("c:major")
- *
- * @example
- * // This can be avoided by making the struct pattern 1 cycle,
- * // and slowing the whole pattern down as follows:
- * "<0 1 2 3>".isobite("x x*2").slow(2).n().scale("c:major")
- * // the same as "<[0] [1 2] [3] [0 1] [2] [3 0] [1] [2 3]>".n().scale("c:major")
- */
-export const { isobite, cyclestruct, cycleStruct } = register(
-  ['isobite', 'cyclestruct', 'cycleStruct'],
-  (structure, pat) => {
-    const structPat = new Pattern((state) => {
-      const haps_cycle = structure
-        .withQuerySpan((span) => span.begin.wholeCycle())
-        .query(state)
-        .filter((hap) => hap.value != 0)
-        .sort((a, b) => a.whole.begin - b.whole.begin)
-        .map((hap, i) => hap.withValue((_) => i));
-
-      const haps = [];
-      for (const hap of haps_cycle) {
-        const new_part = state.span.intersection(hap.part);
-        if (new_part) {
-          haps.push(new Hap(hap.whole, new_part, hap.value, hap.context));
-        }
-      }
-      return haps;
-    }).splitQueries();
-
-    const stepsPattern = new Pattern((state) => {
-      const nrHaps = structure
-        .withQuerySpan((span) => span.begin.wholeCycle())
-        .query(state)
-        .filter((hap) => hap.value != 0).length;
-      return [new Hap(state.span.begin.wholeCycle(), state.span, nrHaps, {})];
-    }).splitQueries();
-
-    return pat.fast(stepsPattern).bite(stepsPattern, structPat);
-  },
-  false,
-);
-
 /**
  * Selects the given fraction of the pattern and repeats that part to fill the remainder of the cycle.
  * @tags temporal
@@ -2760,12 +2419,8 @@ export const off = register('off', function (time_pat, func, pat) {
  * Returns a new pattern where every other cycle is played once, twice as
  * fast, and offset in time by one quarter of a cycle. Creates a kind of
  * breakbeat feel.
- * @name brak
  * @tags temporal
  * @returns Pattern
- * @memberof Pattern
- * @example
- * s("bd hh!2 rim").brak()
  */
 export const brak = register('brak', function (pat) {
   return pat.when(slowcat(false, true), (x) => fastcat(x, silence)._late(0.25));
@@ -3254,29 +2909,10 @@ export const { ribbon, rib } = register(['ribbon', 'rib'], (offset, cycles, pat)
   pat.early(offset).restart(pure(1).slow(cycles)),
 );
 
-/**
- * Sets the pattern's color to the given [hsla](https://www.w3schools.com/htmL/html_colors_hsl.asp)
- *
- * @name hsla
- * @param {Number} hue (0 - 360)
- * @param {Number} saturation percentage (0 - 100)
- * @param {Number} lightness percentage (0 - 100)
- * @param {Number} alpha (transparency) (0.0 - 1.0)
- * @tags visualization
- */
 export const hsla = register('hsla', (h, s, l, a, pat) => {
   return pat.color(`hsla(${h}turn,${s * 100}%,${l * 100}%,${a})`);
 });
 
-/**
- * Sets the pattern's color to the given [hsl](https://www.w3schools.com/htmL/html_colors_hsl.asp)
- *
- * @name hsl
- * @param {Number} hue (0 - 360)
- * @param {Number} saturation percentage (0 - 100)
- * @param {Number} lightness percentage (0 - 100)
- * @tags visualization
- */
 export const hsl = register('hsl', (h, s, l, pat) => {
   return pat.color(`hsl(${h}turn,${s * 100}%,${l * 100}%)`);
 });
@@ -3632,7 +3268,7 @@ export const drop = stepRegister('drop', function (i, pat) {
  * @tags stepwise
  * @example
  * stepcat(
- *   sound("bd bd - <cp hh>").extend(2),
+ *   sound("bd bd - cp").extend(2),
  *   sound("bd - sd -")
  * ).pace(8)
  */
@@ -3643,12 +3279,15 @@ export const extend = stepRegister('extend', function (factor, pat) {
 /**
  * *Experimental*
  *
- * `replicate` is similar to `extend`, except that `replicate` will "replicate" the thing being extended. This will only differ from `extend` when the input pattern differs from cycle to cycle.
+ * `replicate` is similar to `fast` in that it increases its density, but it also increases the step count
+ * accordingly. So `stepcat("a b".replicate(2), "c d")` would be the same as `"a b a b c d"`, whereas
+ * `stepcat("a b".fast(2), "c d")` would be the same as `"[a b] [a b] c d"`.
  *
+ * TODO: find out how this function differs from extend
  * @tags stepwise
  * @example
  * stepcat(
- *   sound("bd bd - <cp hh>").replicate(2),
+ *   sound("bd bd - cp").replicate(2),
  *   sound("bd - sd -")
  * ).pace(8)
  */
@@ -3744,8 +3383,8 @@ export const growlist = (amount, pat) => pat.growlist(amount);
  * "tha dhi thom nam".shrink("1 -1").sound().bank("mridangam").pace(4)
  * @example
  * note("0 1 2 3 4 5 6 7".scale("C:ritusen")).sound("folkharp")
- * .shrink("1 -1").pace(8)
- *
+   .shrink("1 -1").pace(8)
+
  */
 
 export const shrink = register(
@@ -3784,7 +3423,7 @@ export const shrink = register(
  * "tha dhi thom nam".grow("1 -1").sound().bank("mridangam").pace(4)
  * @example
  * note("0 1 2 3 4 5 6 7".scale("C:ritusen")).sound("folkharp")
- * .grow("1 -1").pace(8)
+   .grow("1 -1").pace(8)
  */
 
 export const grow = register(
@@ -3808,17 +3447,17 @@ export const grow = register(
 
 /**
  * *Experimental*
- *
- * Inserts a pattern into a list of patterns. On the first repetition it will be inserted at the end of the list, then moved backwards through the list
- * on successive repetitions. The patterns are added together stepwise, with all repetitions taking place over a single cycle. Using `pace` to set the
+ * 
+ * Inserts a pattern into a list of patterns. On the first repetition it will be inserted at the end of the list, then moved backwards through the list 
+ * on successive repetitions. The patterns are added together stepwise, with all repetitions taking place over a single cycle. Using `pace` to set the 
  * number of steps per cycle is therefore usually recommended.
  *
  * @tags stepwise
  * @return {Pattern}
  * @example
  * "[c g]".tour("e f", "e f g", "g f e c").note()
- * .sound("folkharp")
- * .pace(8)
+   .sound("folkharp")
+   .pace(8)
  */
 export const tour = function (pat, ...many) {
   return pat.tour(...many);
@@ -3836,16 +3475,16 @@ Pattern.prototype.tour = function (...many) {
 
 /**
  * *Experimental*
- *
- * 'zips' together the steps of the provided patterns. This can create a long repetition, taking place over a single, dense cycle.
+ * 
+ * 'zips' together the steps of the provided patterns. This can create a long repetition, taking place over a single, dense cycle. 
  * Using `pace` to set the number of steps per cycle is therefore usually recommended.
- *
+ * 
  * @tags stepwise
  * @returns {Pattern}
  * @example
  * zip("e f", "e f g", "g [f e] a f4 c").note()
- * .sound("folkharp")
- * .pace(8)
+   .sound("folkharp")
+   .pace(8)
  */
 export const zip = function (...pats) {
   pats = pats.filter((pat) => pat.hasSteps);
@@ -4008,9 +3647,9 @@ export const slice = register(
  * s("bd!8").onTriggerTime((hap) => {console.log(hap)})
  */
 Pattern.prototype.onTriggerTime = function (func) {
-  return this.onSchedule((hap, targetTime) => {
-    const diff = targetTime - getClockTime();
-    setTimeout(() => {
+  return this.onTrigger((hap, currentTime, _cps, targetTime) => {
+    const diff = targetTime - currentTime;
+    window.setTimeout(() => {
       func(hap);
     }, diff * 1000);
   }, false);

packages/core/pick.mjs

@@ -104,8 +104,6 @@ export const pickmodF = register('pickmodF', function (pickPattern, lookup, pat)
  * @param {Pattern} pat
  * @param {*} xs
  * @returns {Pattern}
- * @example
- * note("<0*4 1 2*2 3*3>".pickOut(["g a", "e f", "f g f g" , "g c d"]))
  */
 export const pickOut = register('pickOut', function (lookup, pat) {
   return _pick(lookup, pat, false).outerJoin();

packages/core/repl.mjs

@@ -7,15 +7,13 @@ import {
   setIsStarted,
   setPattern as exposeSchedulerPattern,
   setTime,
-  setScheduleFunc,
-  setClockTime,
+  setTriggerFunc,
 } from './schedulerState.mjs';
 import { evalScope } from './evaluate.mjs';
 import { register, Pattern, isPattern, silence, stack } from './pattern.mjs';
 import { reset_state } from './impure.mjs';
 
 export function repl({
-  onSchedule,
   defaultOutput,
   onEvalError,
   beforeEval,
@@ -32,11 +30,6 @@ export function repl({
   id,
   mondo = false,
 }) {
-  if (defaultOutput) {
-    throw new Error(
-      'defaultOutput has been removed. use onSchedule(hap, time, cps) instead. see https://codeberg.org/uzu/strudel/pulls/2138/',
-    );
-  }
   const state = {
     schedulerError: undefined,
     evalError: undefined,
@@ -62,7 +55,7 @@ export function repl({
   };
 
   const schedulerOptions = {
-    onSchedule: getSchedule({ onSchedule }),
+    onTrigger: getTrigger({ defaultOutput, getTime }),
     getTime,
     onToggle: (started) => {
       updateState({ started });
@@ -80,7 +73,7 @@ export function repl({
   // NeoCyclist uses a shared worker to communicate between instances, which is not supported on mobile chrome
   const scheduler =
     sync && typeof SharedWorker != 'undefined' ? new NeoCyclist(schedulerOptions) : new Cyclist(schedulerOptions);
-  setScheduleFunc(schedulerOptions.onSchedule);
+  setTriggerFunc(schedulerOptions.onTrigger);
   setCpsFunc(() => scheduler.cps);
   let pPatterns = {};
   let anonymousIndex = 0;
@@ -231,7 +224,6 @@ export function repl({
     return pattern;
   };
   setTime(() => scheduler.now()); // TODO: refactor?
-  setClockTime(() => scheduler.getTime()); // TODO: refactor?
 
   // Helper function to apply pattern transformations (solo, each, all)
   // this should be abstracted more
@@ -415,7 +407,6 @@ export function repl({
       updateState({ code, pending: true });
       await injectPatternMethods();
       setTime(() => scheduler.now()); // TODO: refactor?
-      setClockTime(() => scheduler.getTime()); // TODO: refactor?
       await beforeEval?.({ code, blockBased: false });
       allTransforms = []; // reset all transforms
 
@@ -461,7 +452,6 @@ export function repl({
       updateState({ code, pending: true });
       await injectPatternMethods();
       setTime(() => scheduler.now()); // TODO: refactor?
-      setClockTime(() => scheduler.getTime()); // TODO: refactor?
       await beforeEval?.({ code, blockBased: true });
       allTransforms = []; // reset all transforms
 
@@ -570,17 +560,20 @@ export function repl({
   return { scheduler, evaluate, evaluateBlock, start, stop, pause, setCps, setPattern, setCode, toggle, state };
 }
 
-export const getSchedule =
-  ({ onSchedule }) =>
-  async (hap, t, cps) => {
+export const getTrigger =
+  ({ getTime, defaultOutput }) =>
+  async (hap, deadline, duration, cps, t) => {
+    //   ^ this signature is different from hap.context.onTrigger, as set by Pattern.onTrigger(onTrigger)
+    // TODO: get rid of deadline after https://codeberg.org/uzu/strudel/pulls/1004
     try {
-      if (!hap.context.onSchedule || !hap.context.dominantSchedule) {
-        await onSchedule(hap, t, cps);
+      if (!hap.context.onTrigger || !hap.context.dominantTrigger) {
+        await defaultOutput(hap, deadline, duration, cps, t);
       }
-      if (hap.context.onSchedule) {
-        await hap.context.onSchedule(hap, t, cps);
+      if (hap.context.onTrigger) {
+        // call signature of output / onTrigger is different...
+        await hap.context.onTrigger(hap, getTime(), cps, t);
       }
     } catch (err) {
-      errorLogger(err, 'getSchedule');
+      errorLogger(err, 'getTrigger');
     }
   };

packages/core/schedulerState.mjs

@@ -7,14 +7,8 @@ This program is free software: you can redistribute it and/or modify it under th
 let time;
 let cpsFunc;
 let pattern;
-let scheduleFunc;
+let triggerFunc;
 let isStarted;
-
-/**
- * @name getTime
- * @tags internals
- * @returns {Number} the current cycle time as a number
- */
 export function getTime() {
   if (!time) {
     throw new Error('no time set! use setTime to define a time source');
@@ -26,32 +20,10 @@ export function setTime(func) {
   time = func;
 }
 
-let clockTime;
-/**
- * @name getClockTime
- * @tags internals
- * @returns {Number} the current clock time in seconds (onSchedule time)
- */
-export function getClockTime() {
-  if (!clockTime) {
-    throw new Error('no clockTime set! use setClockTime to define a time source');
-  }
-  return clockTime();
-}
-
-export function setClockTime(func) {
-  clockTime = func;
-}
-
 export function setCpsFunc(func) {
   cpsFunc = func;
 }
 
-/**
- * @name getCps
- * @tags internals
- * @returns {Number} the current cycles per second
- */
 export function getCps() {
   return cpsFunc?.();
 }
@@ -64,12 +36,12 @@ export function getPattern() {
   return pattern;
 }
 
-export function setScheduleFunc(func) {
-  scheduleFunc = func;
+export function setTriggerFunc(func) {
+  triggerFunc = func;
 }
 
-export function getScheduleFunc() {
-  return scheduleFunc;
+export function getTriggerFunc() {
+  return triggerFunc;
 }
 
 export function setIsStarted(val) {

packages/core/signal.mjs

@@ -5,7 +5,7 @@ This program is free software: you can redistribute it and/or modify it under th
 */
 
 import { Hap } from './hap.mjs';
-import { Pattern, fastcat, pure, register, reify, silence, stack, sequenceP, isPattern } from './pattern.mjs';
+import { Pattern, fastcat, pure, register, reify, silence, stack, sequenceP } from './pattern.mjs';
 import { _mod } from './util.mjs';
 import Fraction from './fraction.mjs';
 
@@ -16,24 +16,6 @@ export function steady(value) {
   return new Pattern((state) => [new Hap(undefined, state.span, value)]);
 }
 
-/**
- * Creates a signal given by the input function
- *
- * @name signal
- * @param {*} func
- * @returns {Pattern} signal
- * @tags generators
- * @example
- * // sawtooth signal definition
- * signal(t=>t%1).segment(16).range(30,40).note()
- * @example
- * signal(t=>Math.pow(t,2)%1).range(40, 60).add(5).segment(16)
- * .off(0, x=>x.add(7))
- * .note()
- * .s("gm_electric_guitar_jazz,gm_epiano")
- *   .gain(1.7)
- * .pianoroll()
- */
 export const signal = (func) => {
   const query = (state) => [new Hap(undefined, state.span, func(state.span.begin, state.controls))];
   return new Pattern(query);
@@ -207,7 +189,6 @@ export const time = signal(id);
 /**
  *  The mouse's x position value ranges from 0 to 1.
  * @name mousex
- * @synonyms mouseX
  * @return {Pattern}
  * @tags external_io
  * @example
@@ -218,7 +199,6 @@ export const time = signal(id);
 /**
  *  The mouse's y position value ranges from 0 to 1.
  * @name mousey
- * @synonyms mouseY
  * @return {Pattern}
  * @tags external_io
  * @example
@@ -579,9 +559,6 @@ export const __chooseWith = (pat, xs) => {
  * @returns {Pattern}
  * @example
  * note("c2 g2!2 d2 f1").s(chooseWith(sine.fast(2), ["sawtooth", "triangle", "bd:6"]))
- * @example
- * // Compare with chooseInWith
- * note(chooseWith("<0 0.5 1>*3", ["c3", "b3", "d3"]))
  */
 export const chooseWith = (pat, xs) => {
   return __chooseWith(pat, xs).outerJoin();
@@ -593,13 +570,6 @@ export const chooseWith = (pat, xs) => {
  * @tags temporal
  * @param {Pattern} pat
  * @param {*} xs
- * @example
- * // Because the structure comes from the chosen values (the notes, here)
- * // The choosing pattern will only advance once per cycle (not 3 times per cycle)
- * note(chooseInWith("<0 0.5 1>*3", ["c3", "b3", "d3"]))
- * @example
- * // Here, the chosen values have a structure such that the choosing pattern will advance 3 times per cycle
- * note(chooseInWith("<0 0.5 1>*3", ["c3*3", "b3*3", "d3*3"]))
  * @returns {Pattern}
  */
 export const chooseInWith = (pat, xs) => {
@@ -616,7 +586,9 @@ export const chooseInWith = (pat, xs) => {
  */
 export const choose = (...xs) => chooseWith(rand, xs);
 
+// todo: doc
 export const chooseIn = (...xs) => chooseInWith(rand, xs);
+export const chooseOut = choose;
 
 /**
  * Chooses from the given list of values (or patterns of values), according
@@ -762,30 +734,12 @@ export const perlin = signal((t, controls) => _perlin(t, controls.randSeed));
  */
 export const berlin = signal((t, controls) => _berlin(t, controls.randSeed));
 
-/**
- * `degradeByWith` is like `degradeBy`, but with control over the random or other signal used to filter out the events.
- *
- * `degradeBy(x)` is essentially `degradeByWith(rand, x)`
- *
- * This allows you to do things other than with `rand`, see examples below
- *
- * @name degradeByWith
- * @param {Pattern|number} test
- * @param {Pattern|number} testAgainst
- * @memberof Pattern
- * @tags temporal
- * @returns {Pattern}
- * @example
- * note("c a f e").degradeByWith(sine, .1)
- * @example
- * note("c a f e").degradeByWith(perlin, .5)
- * @example
- * note("c a f e").degradeByWith(sine, cosine)
- */
-export const degradeByWith = register('degradeByWith', (withPat, x, pat) => {
-  if (!isPattern(withPat)) withPat = pure(withPat);
-  return pat.fmap((a) => (_) => a).appLeft(withPat.filterValues((v) => v > x));
-});
+export const degradeByWith = register(
+  'degradeByWith',
+  (withPat, x, pat) => pat.fmap((a) => (_) => a).appLeft(withPat.filterValues((v) => v > x)),
+  true,
+  true,
+);
 
 /**
  * Randomly removes events from the pattern by a given amount.

packages/core/speak.mjs

@@ -32,7 +32,7 @@ function triggerSpeech(words, lang, voice) {
 }
 
 export const speak = register('speak', function (lang, voice, pat) {
-  return pat.onSchedule((hap) => {
+  return pat.onTrigger((hap) => {
     triggerSpeech(hap.value, lang, voice);
   });
 });

packages/core/test/euclid.test.js

@@ -29,44 +29,6 @@ describe('euclid', () => {
         .map((a) => a.showWhole(true)),
     ).toStrictEqual(['0/1 → 1/8: a', '1/4 → 3/8: a', '3/8 → 1/2: a', '5/8 → 3/4: a', '3/4 → 7/8: a']);
   });
-  it('Can create euclidLegato using negative steps', () => {
-    expect(
-      fastcat('a')
-        .euclid(3, -8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    ).toStrictEqual(
-      fastcat('a')
-        .euclidLegato(3, 8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    );
-    expect(
-      fastcat('a')
-        .euclid(5, -8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    ).toStrictEqual(
-      fastcat('a')
-        .euclidLegato(5, 8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    );
-  });
-  it('stretches over multiple cycles if pulses is greater than steps', () => {
-    expect(
-      fastcat('a')
-        .euclid(5, 4)
-        .fast(2)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    ).toStrictEqual(['0/1 → 1/8: a', '1/4 → 3/8: a', '3/8 → 1/2: a', '5/8 → 3/4: a', '3/4 → 7/8: a']);
-  });
 });
 
 describe('euclidRot', () => {
@@ -105,45 +67,6 @@ describe('euclidLegato', () => {
         .map((a) => a.showWhole(true)),
     ).toStrictEqual(['0/1 → 1/4: a', '1/4 → 3/8: a', '3/8 → 5/8: a', '5/8 → 3/4: a', '3/4 → 1/1: a']);
   });
-  it('Can create euclid using negative steps', () => {
-    expect(
-      fastcat('a')
-        .euclidLegato(3, -8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    ).toStrictEqual(
-      fastcat('a')
-        .euclid(3, 8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    );
-    expect(
-      fastcat('a')
-        .euclidLegato(5, -8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    ).toStrictEqual(
-      fastcat('a')
-        .euclid(5, 8)
-        .firstCycle()
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    );
-  });
-  it('stretches over multiple cycles if pulses is greater than steps', () => {
-    expect(
-      fastcat('a')
-        .euclidLegato(5, 4)
-        .fast(2)
-        .firstCycle()
-        .filter((hap) => hap.hasOnset())
-        .sort((a, b) => a.part.begin.sub(b.part.begin))
-        .map((a) => a.showWhole(true)),
-    ).toStrictEqual(['0/1 → 1/4: a', '1/4 → 3/8: a', '3/8 → 5/8: a', '5/8 → 3/4: a', '3/4 → 1/1: a']);
-  });
 });
 
 describe('euclidLegatoRot', () => {

packages/core/test/pattern.test.mjs

@@ -58,7 +58,7 @@ import {
   arp,
 } from '../index.mjs';
 
-import { log, logValues, stackCenter } from '../pattern.mjs';
+import { log, logValues } from '../pattern.mjs';
 
 import { steady } from '../signal.mjs';
 
@@ -75,10 +75,6 @@ const sameFirst = (a, b) => {
   return expect(a.sortHapsByPart().firstCycle()).toStrictEqual(b.sortHapsByPart().firstCycle());
 };
 
-const sameFirstX = (x, a, b) => {
-  return expect(a.fast(x).sortHapsByPart().firstCycle()).toStrictEqual(b.fast(x).sortHapsByPart().firstCycle());
-};
-
 describe('TimeSpan', () => {
   describe('equals()', () => {
     it('Should be equal to the same value', () => {
@@ -1219,7 +1215,6 @@ describe('Pattern', () => {
       expect(stackRight(fastcat(0, 1, 2), fastcat(3, 4))._steps).toStrictEqual(Fraction(3));
       // maybe this should double when they are either all even or all odd
       expect(stackCentre(fastcat(0, 1, 2), fastcat(3, 4))._steps).toStrictEqual(Fraction(3));
-      expect(stackCenter(fastcat(0, 1, 2), fastcat(3, 4))._steps).toStrictEqual(Fraction(3));
       expect(fastcat(0, 1).ply(3)._steps).toStrictEqual(Fraction(6));
       expect(fastcat(0, 1).setSteps(undefined).ply(3)._steps).toStrictEqual(undefined);
       expect(fastcat(0, 1).fast(3)._steps).toStrictEqual(Fraction(2));
@@ -1325,21 +1320,6 @@ describe('Pattern', () => {
       );
     });
   });
-  describe('isobite', () => {
-    it('can play a melody with a structure', () => {
-      sameFirst(
-        slowcat(0, 1, 2, 3, 4, 5).isobite(fastcat(true, silence, [true, true]).fast(2)),
-        fastcat(0, silence, [1, 2], 3, silence, [4, 5]),
-      );
-    });
-    it('syncopates over multiple cycles if the number of haps in the patterns differ', () => {
-      sameFirstX(
-        4,
-        slowcat(0, 1, 2, 3).isobite(fastcat(true, [true, true])),
-        slowcat(0, [1, 2], 3, [0, 1], 2, [3, 0], 1, [2, 3]).fast(2),
-      );
-    });
-  });
   describe('unjoin', () => {
     it('destructures a pattern into subcycles', () => {
       sameFirst(
@@ -1383,7 +1363,7 @@ describe('Pattern', () => {
 
       // Force a trigger
       haps.forEach((hap) => {
-        hap.context?.onSchedule?.(hap);
+        hap.context?.onTrigger?.(hap);
       });
 
       expect(mockConsoleLog).toHaveBeenCalledWith(
@@ -1401,7 +1381,7 @@ describe('Pattern', () => {
 
       // Force a trigger
       haps.forEach((hap) => {
-        hap.context?.onSchedule?.(hap);
+        hap.context?.onTrigger?.(hap);
       });
 
       expect(mockConsoleLog).toHaveBeenCalledWith(

packages/core/util.mjs

@@ -70,6 +70,17 @@ export const getEventOffsetMs = (targetTimeSeconds, currentTimeSeconds) => {
   return (targetTimeSeconds - currentTimeSeconds) * 1000;
 };
 
+/**
+ * @deprecated does not appear to be referenced or invoked anywhere in the codebase
+ * @noAutocomplete
+ */
+export const getFreq = (noteOrMidi) => {
+  if (typeof noteOrMidi === 'number') {
+    return midiToFreq(noteOrMidi);
+  }
+  return midiToFreq(noteToMidi(noteOrMidi));
+};
+
 const pcs = ['C', 'Db', 'D', 'Eb', 'E', 'F', 'Gb', 'G', 'Ab', 'A', 'Bb', 'B'];
 /**
  * @deprecated only used in workshop (first-notes)
@@ -119,31 +130,8 @@ export const getPlayableNoteValue = (hap) => {
   return note;
 };
 
-/**
- * Given a hap, returns the frequency of the note or freq, if defined
- *
- * Given a note, returns the frequency of that note
- * `getFreq('c3')`
- *
- * Given a midi note number, returns the frequency of that midi note
- * `getFreq('c3')`
- *
- * @name getFrequency
- * @tags pitch
- * @synonyms getFreq
- * @param {Hap | note | number} input
- * @returns {Number}
- * @example
- * i("4 8 9 10 - - 5 7 9 11 - -").tune("tranh3")
- * .mul(getFreq('c3'))
- * .freq().clip(.5).room(1)
- */
 export const getFrequency = (hap) => {
-  let { value, context } =
-    typeof hap == 'object'
-      ? hap
-      : // default: interpret value as midi note.
-        { value: hap, context: { type: 'note' } };
+  let { value, context } = hap;
   // if value is number => interpret as midi number as long as its not marked as frequency
   if (typeof value === 'object') {
     if (value.freq) {
@@ -152,17 +140,15 @@ export const getFrequency = (hap) => {
     return getFreq(value.note ?? value.n ?? value.value);
   }
   if (typeof value === 'number' && context.type !== 'frequency') {
-    value = midiToFreq(value);
+    value = midiToFreq(hap.value);
   } else if (typeof value === 'string' && isNote(value)) {
-    value = midiToFreq(noteToMidi(value));
+    value = midiToFreq(noteToMidi(hap.value));
   } else if (typeof value !== 'number') {
     throw new Error('not a note or frequency: ' + value);
   }
   return value;
 };
 
-export const getFreq = (hap) => getFrequency(hap);
-
 // rotate array by n steps (to the left)
 export const rotate = (arr, n) => arr.slice(n).concat(arr.slice(0, n));
 

packages/csound/index.mjs

@@ -23,7 +23,7 @@ export const csound = register('csound', (instrument, pat) => {
   instrument = instrument || 'triangle';
   init(); // not async to support csound inside other patterns + to be able to call pattern methods after it
   // TODO: find a alternative way to wait for csound to load (to wait with first time playback)
-  return pat.onSchedule((hap, targetTime) => {
+  return pat.onTrigger((hap, currentTime, _cps, targetTime) => {
     if (!_csound) {
       logger('[csound] not loaded yet', 'warning');
       return;
@@ -36,10 +36,9 @@ export const csound = register('csound', (instrument, pat) => {
     const controls = Object.entries({ ...hap.value, freq })
       .flat()
       .join('/');
-
     // TODO: find out how to send a precise ctx based time
     // http://www.csounds.com/manual/html/i.html
-    const timeOffset = targetTime - getAudioContext().currentTime; // latency ?
+    const timeOffset = targetTime - currentTime; // latency ?
     //const timeOffset = time_deprecate - getAudioContext().currentTime
     const params = [
       `"${instrument}"`, // p1: instrument name
@@ -145,7 +144,7 @@ export const csoundm = register('csoundm', (instrument, pat) => {
     p1 = `"${instrument}"`;
   }
   init(); // not async to support csound inside other patterns + to be able to call pattern methods after it
-  return pat.onSchedule((hap, targetTime) => {
+  return pat.onTrigger((hap, currentTime, _cps, targetTime) => {
     if (!_csound) {
       logger('[csound] not loaded yet', 'warning');
       return;
@@ -153,7 +152,6 @@ export const csoundm = register('csoundm', (instrument, pat) => {
     if (typeof hap.value !== 'object') {
       throw new Error('csound only support objects as hap values');
     }
-    const currentTime = getAudioContext().currentTime;
     // Time in seconds counting from now.
     const p2 = targetTime - currentTime;
     const p3 = hap.duration.valueOf() + 0;

packages/desktopbridge/midibridge.mjs

@@ -1,4 +1,3 @@
-import { getAudioContext } from '@strudel/webaudio/index.mjs';
 import { Invoke } from './utils.mjs';
 import { Pattern, getEventOffsetMs, noteToMidi } from '@strudel/core';
 
@@ -7,8 +6,7 @@ const OFF_MESSAGE = 0x80;
 const CC_MESSAGE = 0xb0;
 
 Pattern.prototype.midi = function (output) {
-  return this.onSchedule((hap, targetTime, cps) => {
-    const currentTime = getAudioContext().currentTime;
+  return this.onTrigger((hap, currentTime, cps, targetTime) => {
     let { note, nrpnn, nrpv, ccn, ccv, velocity = 0.9, gain = 1 } = hap.value;
     //magic number to get audio engine to line up, can probably be calculated somehow
     const latencyMs = 34;

packages/desktopbridge/oscbridge.mjs

@@ -1,14 +1,12 @@
 import { Pattern, ClockCollator } from '@strudel/core';
-import { parseControlsFromHap } from '@strudel/osc/osc.mjs';
+import { parseControlsFromHap } from 'node_modules/@strudel/osc/osc.mjs';
 import { Invoke } from './utils.mjs';
-import { getAudioContext } from '@strudel/webaudio/index.mjs';
 
 const collator = new ClockCollator({});
 
-export async function tauriOscOutput(hap, targetTime, cps = 1) {
+export async function oscTriggerTauri(hap, currentTime, cps = 1, targetTime) {
   const controls = parseControlsFromHap(hap, cps);
   const params = [];
-  const currentTime = getAudioContext().currentTime;
   const timestamp = collator.calculateTimestamp(currentTime, targetTime);
 
   Object.keys(controls).forEach((key) => {
@@ -34,5 +32,5 @@ export async function tauriOscOutput(hap, targetTime, cps = 1) {
   });
 }
 Pattern.prototype.osc = function () {
-  return this.onSchedule(tauriOscOutput);
+  return this.onTrigger(oscTriggerTauri);
 };

packages/desktopbridge/package.json

@@ -23,8 +23,6 @@
   },
   "dependencies": {
     "@strudel/core": "workspace:*",
-    "@strudel/osc": "workspace:*",
-    "@strudel/webaudio": "workspace:*",
     "@tauri-apps/api": "^2.2.0"
   },
   "homepage": "https://codeberg.org/uzu/strudel#readme",

packages/dough/dough.mjs

@@ -37,7 +37,7 @@ export function initDough() {
   return D.ready;
 }
 
-export async function doughOutput(hap, targetTime, cps = 1) {
+export async function doughTrigger(hap, _currentTime, cps = 1, targetTime) {
   const offset = D.context_offset?.[0];
   if (!offset) {
     return; // not ready
@@ -71,5 +71,5 @@ export async function doughOutput(hap, targetTime, cps = 1) {
 export const dough = register('dough', (pat) => {
   initDough();
   ensureMinimalOutput();
-  return pat.onSchedule(doughOutput);
+  return pat.onTrigger(doughTrigger);
 });

packages/midi/midi.mjs

@@ -13,7 +13,7 @@ import {
   getIsStarted,
   getPattern,
   getTime,
-  getScheduleFunc,
+  getTriggerFunc,
   isPattern,
   logger,
   ref,
@@ -342,7 +342,7 @@ Pattern.prototype.midi = function (midiport, options = {}) {
 
   ensureMinimalOutput();
 
-  return this.sortHapsByPart().onSchedule((hap, targetTime, cps) => {
+  return this.sortHapsByPart().onTrigger((hap, _currentTime, cps, targetTime) => {
     if (!WebMidi.enabled) {
       logger('Midi not enabled');
       return;
@@ -570,8 +570,8 @@ const kListeners = {};
 
 function _triggerKeyboard(input, cps, now, latencyCycles) {
   const pattern = getPattern();
-  const schedule = getScheduleFunc();
-  if (!pattern || !schedule) {
+  const trigger = getTriggerFunc();
+  if (!pattern || !trigger) {
     return false;
   }
   const t = now + latencyCycles;
@@ -588,7 +588,8 @@ function _triggerKeyboard(input, cps, now, latencyCycles) {
       return;
     }
     const t = ctxNow + (hap.whole.begin - now) / cps;
-    schedule(hap, t, cps);
+    const duration = hap.duration / cps;
+    trigger(hap, t - ctxNow, duration, cps, t);
   });
 
   return true;
@@ -623,7 +624,7 @@ export async function midikeys(input) {
     noteoff ||= noteon && velocity === 0; // handle devices which may use velocity = 0 to signal noteoff
     const key = `${input}_${note}`;
     const cps = getCps() ?? 0.5;
-    const triggerAvailable = !!(getPattern() && getScheduleFunc());
+    const triggerAvailable = !!(getPattern() && getTriggerFunc());
     const latencySeconds = triggerAvailable ? 0.01 : 0.06; // avoid missing notes due to cyclist / trigger latency
     const now = getTime();
     const t = now + latencySeconds * cps;

packages/mini/test/mini.test.mjs

@@ -84,22 +84,6 @@ describe('mini', () => {
   it('supports patterning euclidean rhythms', () => {
     expect(minS('[a(<3 5>, <8 16>)]*2')).toEqual(minS('a(3,8) a(5,16)'));
   });
-  it('supports inverted euclidean rhythms', () => {
-    expect(minS('a(-3, 8)')).toEqual(['a: 1/8 - 1/4', 'a: 1/4 - 3/8', 'a: 1/2 - 5/8', 'a: 5/8 - 3/4', 'a: 7/8 - 1']);
-  });
-  it('supports euclidean legato rhythms', () => {
-    expect(minS('a(3, -8)')).toEqual(['a: 0 - 3/8', 'a: 3/8 - 3/4', 'a: 3/4 - 1']);
-  });
-  it('supports inverted euclidean legato rhythms', () => {
-    expect(minS('a(-3, -8)')).toEqual([
-      'a: -1/8 - 1/8',
-      'a: 1/8 - 1/4',
-      'a: 1/4 - 1/2',
-      'a: 1/2 - 5/8',
-      'a: 5/8 - 7/8',
-      'a: 7/8 - 9/8',
-    ]);
-  });
   it("reproduces Toussaint's example euclidean algorithms", () => {
     const checkEuclid = function (spec, target) {
       expect(minS(`x(${spec[0]},${spec[1]})`)).toEqual(minS(target));
@@ -134,40 +118,6 @@ describe('mini', () => {
     checkEuclid([11, 24], 'x ~ ~ x ~ x ~ x ~ x ~ x ~ ~ x ~ x ~ x ~ x ~ x ~');
     checkEuclid([13, 24], 'x ~ x x ~ x ~ x ~ x ~ x ~ x x ~ x ~ x ~ x ~ x ~');
   });
-  it("reproduces Toussaint's example euclidean legato algorithms", () => {
-    const checkEuclid = function (spec, target) {
-      expect(minS(`x(${spec[0]},${spec[1]})`)).toEqual(minS(target));
-    };
-    checkEuclid([1, -2], 'x _');
-    checkEuclid([1, -3], 'x _ _');
-    checkEuclid([1, -4], 'x _ _ _');
-    checkEuclid([4, -12], 'x _ _ x _ _ x _ _ x _ _');
-    checkEuclid([2, -5], 'x _ x _ _');
-    // checkEuclid([3, 4], "x _ x x"); // Toussaint is wrong..
-    checkEuclid([3, -4], 'x x x _'); // correction
-    checkEuclid([3, -5], 'x _ x _ x');
-    checkEuclid([3, -7], 'x _ x _ x _ _');
-    checkEuclid([3, -8], 'x _ _ x _ _ x _');
-    checkEuclid([4, -7], 'x _ x _ x _ x');
-    checkEuclid([4, -9], 'x _ x _ x _ x _ _');
-    checkEuclid([4, -11], 'x _ _ x _ _ x _ _ x _');
-    // checkEuclid([5, 6], "x _ x x x x"); // Toussaint is wrong..
-    checkEuclid([5, -6], 'x x x x x _'); // correction
-    checkEuclid([5, -7], 'x _ x x _ x x');
-    checkEuclid([5, -8], 'x _ x x _ x x _');
-    checkEuclid([5, -9], 'x _ x _ x _ x _ x');
-    checkEuclid([5, -11], 'x _ x _ x _ x _ x _ _');
-    checkEuclid([5, -12], 'x _ _ x _ x _ _ x _ x _');
-    // checkEuclid([5, 16], "x _ _ x _ _ x _ _ x _ _ x _ _ _ _");  // Toussaint is wrong..
-    checkEuclid([5, -16], 'x _ _ x _ _ x _ _ x _ _ x _ _ _'); // correction
-    // checkEuclid([7, 8], "x _ x x x x x x"); // Toussaint is wrong..
-    checkEuclid([7, -8], 'x x x x x x x _'); // Correction
-    checkEuclid([7, -12], 'x _ x x _ x _ x x _ x _');
-    checkEuclid([7, -16], 'x _ _ x _ x _ x _ _ x _ x _ x _');
-    checkEuclid([9, -16], 'x _ x x _ x _ x _ x x _ x _ x _');
-    checkEuclid([11, -24], 'x _ _ x _ x _ x _ x _ x _ _ x _ x _ x _ x _ x _');
-    checkEuclid([13, -24], 'x _ x x _ x _ x _ x _ x _ x x _ x _ x _ x _ x _');
-  });
   it('supports the - alias for ~', () => {
     expect(minS('a - b [- c]')).toEqual(minS('a ~ b [~ c]'));
   });

packages/mondough/mondough.mjs

@@ -46,6 +46,7 @@ lib[':'] = tail;
 lib['..'] = range;
 lib['def'] = () => silence;
 lib['or'] = (...children) => chooseIn(...children); // always has structure but is cyclewise.. e.g. "s oh*8.dec[.04 | .5]"
+//lib['or'] = (...children) => chooseOut(...children); // "s oh*8.dec[.04 | .5]" is better but "dec[.04 | .5].s oh*8" has no struct
 
 function evaluator(node, scope) {
   const { type } = node;

packages/mqtt/mqtt.mjs

@@ -4,7 +4,7 @@ Copyright (C) 2022 Strudel contributors - see <https://codeberg.org/uzu/strudel/
 This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more details. You should have received a copy of the GNU Affero General Public License along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-import { Pattern, getClockTime, createParams } from '@strudel/core';
+import { Pattern, isPattern, createParams } from '@strudel/core';
 import Paho from 'paho-mqtt';
 
 const connections = {};
@@ -80,39 +80,42 @@ Pattern.prototype.mqtt = function (
     }
     cx.connect(props);
   }
-  return this.onSchedule((hap, targetTime, cps) => {
-    let msg_topic = topic;
-    if (!cx || !cx.isConnected()) {
-      return;
-    }
-    let message = '';
-    if (typeof hap.value === 'object') {
-      let value = hap.value;
+  return this.withHap((hap) => {
+    const onTrigger = (hap, currentTime, cps, targetTime) => {
+      let msg_topic = topic;
+      if (!cx || !cx.isConnected()) {
+        return;
+      }
+      let message = '';
+      if (typeof hap.value === 'object') {
+        let value = hap.value;
 
-      // Try to take topic from pattern if it's not set
-      if (typeof msg_topic === 'undefined' && 'topic' in value) {
-        msg_topic = value.topic;
-        if (Array.isArray(msg_topic)) {
-          msg_topic = msg_topic.join('/');
+        // Try to take topic from pattern if it's not set
+        if (typeof msg_topic === 'undefined' && 'topic' in value) {
+          msg_topic = value.topic;
+          if (Array.isArray(msg_topic)) {
+            msg_topic = msg_topic.join('/');
+          }
+          msg_topic = '/' + msg_topic;
         }
-        msg_topic = '/' + msg_topic;
+        if (add_meta) {
+          const duration = hap.duration.div(cps);
+          value = { ...value, duration: duration.valueOf(), cps: cps };
+        }
+        message = JSON.stringify(value);
+      } else {
+        message = hap.value;
       }
-      if (add_meta) {
-        const duration = hap.duration.div(cps);
-        value = { ...value, duration: duration.valueOf(), cps: cps };
-      }
-      message = JSON.stringify(value);
-    } else {
-      message = hap.value;
-    }
-    message = new Paho.Message(message);
-    message.destinationName = msg_topic;
+      message = new Paho.Message(message);
+      message.destinationName = msg_topic;
 
-    const offset = (targetTime - getClockTime() + latency) * 1000;
+      const offset = (targetTime - currentTime + latency) * 1000;
 
-    window.setTimeout(function () {
-      cx.send(message);
-    }, offset);
+      window.setTimeout(function () {
+        cx.send(message);
+      }, offset);
+    };
+    return hap.setContext({ ...hap.context, onTrigger, dominantTrigger: true });
   });
 };
 

packages/osc/osc.mjs

@@ -55,7 +55,7 @@ export function parseControlsFromHap(hap, cps) {
   return controls;
 }
 
-export async function oscOutput(hap, targetTime, cps = 1) {
+export async function oscTrigger(hap, currentTime, cps = 1, targetTime) {
   const ws = await connect();
 
   const timeMs = getClockBridge().getPerformanceTime(targetTime);
@@ -90,5 +90,5 @@ export async function oscOutput(hap, targetTime, cps = 1) {
  */
 export const osc = register('osc', (pat) => {
   ensureMinimalOutput();
-  return pat.onSchedule(oscOutput);
+  return pat.onTrigger(oscTrigger);
 });

packages/osc/superdirtoutput.js

@@ -1,7 +1,10 @@
-/* import { tauriOscOutput } from '../desktopbridge/oscbridge.mjs';
+/* import { oscTriggerTauri } from '../desktopbridge/oscbridge.mjs';
 import { isTauri } from '../desktopbridge/utils.mjs'; */
-import { oscOutput } from './osc.mjs';
+import { oscTrigger } from './osc.mjs';
 
-const output = /* isTauri() ? tauriOscOutput : */ oscOutput;
+const trigger = /* isTauri() ? oscTriggerTauri : */ oscTrigger;
 
-export const superdirtOutput = (hap, targetTime, cps) => output(hap, targetTime, cps);
+export const superdirtOutput = (hap, deadline, hapDuration, cps, targetTime) => {
+  const currentTime = performance.now() / 1000;
+  return trigger(hap, currentTime, cps, targetTime);
+};

packages/repl/repl-component.mjs

@@ -37,7 +37,7 @@ if (typeof HTMLElement !== 'undefined') {
       const drawContext = getDrawContext();
       const drawTime = [-2, 2];
       this.editor = new StrudelMirror({
-        onSchedule: webaudioOutput,
+        defaultOutput: webaudioOutput,
         getTime: () => getAudioContext().currentTime,
         transpiler,
         root: container,

packages/serial/serial.mjs

@@ -4,7 +4,7 @@ Copyright (C) 2022 Strudel contributors - see <https://codeberg.org/uzu/strudel/
 This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more details. You should have received a copy of the GNU Affero General Public License along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-import { Pattern, getClockTime } from '@strudel/core';
+import { Pattern, isPattern } from '@strudel/core';
 
 var writeMessagers = {};
 var choosing = false;
@@ -64,50 +64,53 @@ function crc16(data) {
 }
 
 Pattern.prototype.serial = function (br = 115200, sendcrc = false, singlecharids = false, name = 'default') {
-  if (!(name in writeMessagers)) {
-    getWriter(name, br);
-  }
-  return this.onSchedule((hap, targetTime) => {
-    var message = '';
-    var chk = 0;
-    if (typeof hap.value === 'object') {
-      if ('action' in hap.value) {
-        var action = hap.value['action'];
-        if (singlecharids) {
-          action = action.charAt(0);
-        }
-        message += action + '(';
-        var first = true;
-        for (var [key, val] of Object.entries(hap.value)) {
-          if (key === 'action') {
-            continue;
-          }
-          if (first) {
-            first = false;
-          } else {
-            message += ',';
-          }
+  return this.withHap((hap) => {
+    if (!(name in writeMessagers)) {
+      getWriter(name, br);
+    }
+    const onTrigger = (hap, currentTime, _cps, targetTime) => {
+      var message = '';
+      var chk = 0;
+      if (typeof hap.value === 'object') {
+        if ('action' in hap.value) {
+          var action = hap.value['action'];
           if (singlecharids) {
-            key = key.charAt(0);
+            action = action.charAt(0);
+          }
+          message += action + '(';
+          var first = true;
+          for (var [key, val] of Object.entries(hap.value)) {
+            if (key === 'action') {
+              continue;
+            }
+            if (first) {
+              first = false;
+            } else {
+              message += ',';
+            }
+            if (singlecharids) {
+              key = key.charAt(0);
+            }
+            message += key + ':' + val;
+          }
+          message += ')';
+          if (sendcrc) {
+            chk = crc16(message);
+          }
+        } else {
+          for (const [key, val] of Object.entries(hap.value)) {
+            message += `${key}:${val}`;
           }
-          message += key + ':' + val;
-        }
-        message += ')';
-        if (sendcrc) {
-          chk = crc16(message);
         }
       } else {
-        for (const [key, val] of Object.entries(hap.value)) {
-          message += `${key}:${val}`;
-        }
+        message = hap.value;
       }
-    } else {
-      message = hap.value;
-    }
-    const offset = (targetTime - getClockTime() + latency) * 1000;
+      const offset = (targetTime - currentTime + latency) * 1000;
 
-    window.setTimeout(function () {
-      writeMessagers[name](message, chk);
-    }, offset);
+      window.setTimeout(function () {
+        writeMessagers[name](message, chk);
+      }, offset);
+    };
+    return hap.setContext({ ...hap.context, onTrigger, dominantTrigger: true });
   });
 };

packages/soundfonts/fontloader.mjs

@@ -28,7 +28,7 @@ async function loadFont(name) {
     const url = `${soundfontUrl}/${name}.js`;
     const preset = await fetch(url).then((res) => res.text());
     let [_, data] = preset.split('={');
-    return new Function('return {' + data)().zones;
+    return eval('{' + data);
   };
   loadCache[name] = load();
   return loadCache[name];

packages/soundfonts/gm.mjs

@@ -479,7 +479,7 @@ export default {
   gm_electric_bass_finger: [
     // Electric Bass (finger): Bass
     '0330_JCLive_sf2_file',
-    '0330_FluidR3_GM_sf2_file',
+    '0330_FluidR3_GM_sf2_fible',
     '0330_Aspirin_sf2_file',
     //0330_Chaos_sf2_file // same as last
     '0330_GeneralUserGS_sf2_file',
@@ -527,7 +527,7 @@ export default {
     '0370_Aspirin_sf2_file',
     // 0370_Chaos_sf2_file // same as last
     '0370_FluidR3_GM_sf2_file',
-    '0370_GeneralUserGS_sf2_file',
+    '0370_GeneralUserGS_sf2_fil e',
     '0370_JCLive_sf2_file',
     //0370_SBLive_sf2
     //0370_SoundBlasterOld_sf2
@@ -1782,5 +1782,6 @@ export default {
     '1272_GeneralUserGS_sf2_file',
     '1273_GeneralUserGS_sf2_file',
     '1274_GeneralUserGS_sf2_file',
+    '',
   ],
 };

packages/soundfonts/sfumato.mjs

@@ -3,7 +3,7 @@ import { getAudioContext, registerSound } from '@strudel/webaudio';
 import { loadSoundfont as _loadSoundfont, startPresetNote } from 'sfumato';
 
 Pattern.prototype.soundfont = function (sf, n = 0) {
-  return this.onSchedule((h, targetTime) => {
+  return this.onTrigger((h, ct, cps, targetTime) => {
     const ctx = getAudioContext();
     const note = getPlayableNoteValue(h);
     const preset = sf.presets[n % sf.presets.length];

packages/superdough/dspworklet.mjs

@@ -74,7 +74,6 @@ export const rawdsp = async (code) => {
   worklet.node.connect(ac.destination);
 };
 
-export function rawdspOutput(hap, time, cps) {
-  const currentTime = getAudioContext().currentTime;
-  window.postMessage({ time, dough: hap.value, currentTime, duration: hap.duration, cps });
+export function rawdspTrigger(hap, currentTime, cps, targetTime) {
+  window.postMessage({ time: targetTime, dough: hap.value, currentTime, duration: hap.duration, cps });
 }

packages/superdough/sampler.mjs

@@ -1,4 +1,4 @@
-import { getBaseURL, getCommonSampleInfo } from './util.mjs';
+import { BASE_MIDI_NOTE, getBaseURL, getCommonSampleInfo, noteToFreq, noteToMidi } from './util.mjs';
 import { registerSound, registerWaveTable, soundMap } from './index.mjs';
 import { getAudioContext } from './audioContext.mjs';
 import {
@@ -14,6 +14,13 @@ import { logger } from './logger.mjs';
 const bufferCache = {}; // string: Promise<ArrayBuffer>
 const loadCache = {}; // string: Promise<ArrayBuffer>
 
+/**
+ *
+ * @typedef {Object} SampleMetaData
+ * @property {string} url
+ * @property {midi} number
+ */
+
 export const getCachedBuffer = (url) => bufferCache[url];
 
 function humanFileSize(bytes, si) {
@@ -36,9 +43,8 @@ function humanFileSize(bytes, si) {
  *
  * Note: `must` be called with await, otherwise you'll get a pending Promise object.
  *
- * @name getDuration
- * @synonym getDur
- * @tags samples
+ * @name getDuration,getDur
+ * @tag samples
  * @param {string} sampleName
  * @param {number} (optional) n
  *
@@ -56,8 +62,9 @@ export const getDur = getDuration;
 
 export function getSampleInfo(hapValue, bank) {
   const { speed = 1.0 } = hapValue;
-  const { transpose, url, index, midi, label } = getCommonSampleInfo(hapValue, bank);
-  let playbackRate = Math.abs(speed) * Math.pow(2, transpose / 12);
+  const { transpose, url, index, midi, label, baseFrequency } = getCommonSampleInfo(hapValue, bank);
+
+  const playbackRate = Math.abs(speed) * Math.pow(2, transpose / 12);
   return { transpose, url, index, midi, label, playbackRate };
 }
 
@@ -180,7 +187,12 @@ export const processSampleMap = (sampleMap, fn, baseUrl = sampleMap._base || '')
     if (baseUrl.startsWith('github:')) {
       baseUrl = githubPath(baseUrl, '');
     }
-    const fullUrl = (v) => baseUrl + v;
+    /**
+     *
+     * @param {string} v
+     * @returns {SampleMetaData}
+     */
+    const fullUrl = (v) => ({ url: baseUrl + v, midi: extractMidiNoteFromString(v) });
     if (Array.isArray(value)) {
       //return [key, value.map(replaceUrl)];
       value = value.map(fullUrl);
@@ -391,3 +403,16 @@ export function registerSampleSource(key, bank, params) {
     registerSample(key, bank, params);
   }
 }
+
+export function extractMidiNoteFromString(str) {
+  const regex = /_([a-gA-G])([#b])?([1-9])?\b/;
+  const match = str.match(regex);
+  if (match == null) {
+    return BASE_MIDI_NOTE;
+  }
+  const base = match[1].toUpperCase();
+  const accidental = match[2] ?? '';
+  const octave_str = match[3] ?? '';
+  const parsedVal = base + accidental + octave_str;
+  return noteToMidi(parsedVal);
+}

packages/superdough/superdough.mjs

@@ -1048,3 +1048,7 @@ export const superdough = async (value, t, hapDuration, cps = 0.5, cycle = 0.5)
     }
   });
 };
+
+export const superdoughTrigger = (t, hap, ct, cps) => {
+  superdough(hap, t - ct, hap.duration / cps, cps);
+};

packages/superdough/util.mjs

@@ -19,7 +19,12 @@ const accs = { '#': 1, b: -1, s: 1, f: -1 };
 export const getAccidentalsOffset = (accidentals) => {
   return accidentals?.split('').reduce((o, char) => o + accs[char], 0) || 0;
 };
-
+/**
+ *
+ * @param {string} note
+ * @param {number} defaultOctave
+ * @returns {number}
+ */
 export const noteToMidi = (note, defaultOctave = 3) => {
   const [pc, acc, oct = defaultOctave] = tokenizeNote(note);
   if (!pc) {
@@ -29,6 +34,11 @@ export const noteToMidi = (note, defaultOctave = 3) => {
   const offset = getAccidentalsOffset(acc);
   return (Number(oct) + 1) * 12 + chroma + offset;
 };
+/**
+ *
+ * @param {number} n
+ * @returns {number}
+ */
 export const midiToFreq = (n) => {
   return Math.pow(2, (n - 69) / 12) * 440;
 };
@@ -38,7 +48,17 @@ export const freqToMidi = (freq) => {
   return (12 * Math.log(freq / 440)) / Math.LN2 + 69;
 };
 
-export const valueToMidi = (value, fallbackValue) => {
+/**
+ *
+ * @param {string} note
+ * @param {number} defaultOctave
+ * @returns {number}
+ */
+
+export const noteToFreq = (note, defaultOctave = 3) => {
+  return midiToFreq(noteToMidi(note, defaultOctave));
+};
+function __valueToMidi(value) {
   if (typeof value !== 'object') {
     throw new Error('valueToMidi: expected object value');
   }
@@ -52,10 +72,15 @@ export const valueToMidi = (value, fallbackValue) => {
   if (typeof note === 'number') {
     return note;
   }
-  if (!fallbackValue) {
+  return;
+}
+
+export const valueToMidi = (value, fallbackValue) => {
+  const parsedValue = __valueToMidi(value) ?? fallbackValue;
+  if (parsedValue == null) {
     throw new Error('valueToMidi: expected freq or note to be set');
   }
-  return fallbackValue;
+  return parsedValue;
 };
 
 export function nanFallback(value, fallback = 0, silent) {
@@ -84,15 +109,18 @@ export function secondsToCycle(t, cps) {
 // deduces relevant info for sample loading from hap.value and sample definition
 // it encapsulates the core sampler logic into a pure and synchronous function
 // hapValue: Hap.value, bank: sample bank definition for sound "s" (values in strudel.json format)
+export const BASE_MIDI_NOTE = 36;
+
 export function getCommonSampleInfo(hapValue, bank) {
   const { s, n = 0 } = hapValue;
-  let midi = valueToMidi(hapValue, 36);
-  let transpose = midi - 36; // C3 is middle C;
-  let url;
+  const maybeMidiNote = __valueToMidi(hapValue);
+  const midi = maybeMidiNote ?? BASE_MIDI_NOTE;
+  let transpose = midi - BASE_MIDI_NOTE; // C3 is middle C;
   let index = 0;
+  let samplemeta;
   if (Array.isArray(bank)) {
     index = getSoundIndex(n, bank.length);
-    url = bank[index];
+    samplemeta = bank[index];
   } else {
     const midiDiff = (noteA) => noteToMidi(noteA) - midi;
     // object format will expect keys as notes
@@ -104,10 +132,14 @@ export function getCommonSampleInfo(hapValue, bank) {
       );
     transpose = -midiDiff(closest); // semitones to repitch
     index = getSoundIndex(n, bank[closest].length);
-    url = bank[closest][index];
+    samplemeta = bank[closest][index];
   }
   const label = `${s}:${index}`;
-  return { transpose, url, index, midi, label };
+  if (maybeMidiNote != null) {
+    transpose = transpose + (BASE_MIDI_NOTE - samplemeta.midi);
+  }
+
+  return { transpose, index, midi, label, url: samplemeta.url };
 }
 
 /** Selects entries from `source` and renames them via `map`

packages/web/web.mjs

@@ -6,7 +6,7 @@ export * from '@strudel/mini';
 export * from '@strudel/edo';
 export * from '@strudel/tonal';
 export * from '@strudel/webaudio';
-import { Pattern, evalScope, setTime, setClockTime } from '@strudel/core';
+import { Pattern, evalScope, setTime } from '@strudel/core';
 import { initAudioOnFirstClick, registerSynthSounds, webaudioRepl } from '@strudel/webaudio';
 // import { registerSoundfonts } from '@strudel/soundfonts';
 import { evaluate as _evaluate, transpiler } from '@strudel/transpiler';
@@ -41,7 +41,6 @@ export function initStrudel(options = {}) {
     return repl;
   })();
   setTime(() => repl.scheduler.now());
-  setClockTime(() => repl.scheduler.getTime()); // TODO: refactor?
   return initDone;
 }
 

packages/webaudio/README.md

@@ -19,7 +19,7 @@ initAudioOnFirstClick();
 const ctx = getAudioContext();
 
 const { scheduler } = repl({
-  onSchedule: webaudioOutput,
+  defaultOutput: webaudioOutput,
   getTime: () => ctx.currentTime
 });
 

packages/webaudio/supradough.mjs

@@ -20,7 +20,7 @@ const soundMap = new Map();
 const loadedSounds = new Map();
 
 Pattern.prototype.supradough = function () {
-  return this.onSchedule((hap, begin, cps) => {
+  return this.onTrigger((hap, __, cps, begin) => {
     hap.value._begin = begin;
     hap.value._duration = hap.duration / cps;
     !doughWorklet && initDoughWorklet();
@@ -61,7 +61,7 @@ function githubPath(base, subpath = '') {
   }
   return `https://raw.githubusercontent.com/${path}/${subpath}`;
 }
-export async function _fetchSampleMap(url) {
+export async function fetchSampleMap(url) {
   if (url.startsWith('github:')) {
     url = githubPath(url, 'strudel.json');
   }
@@ -116,7 +116,7 @@ async function fetchSample(url) {
 
 export async function supradoughsamples(sampleMap, baseUrl) {
   if (typeof sampleMap === 'string') {
-    const [json, base] = await _fetchSampleMap(sampleMap);
+    const [json, base] = await fetchSampleMap(sampleMap);
     // console.log('json', json, 'base', base);
     return supradoughsamples(json, base);
   }

packages/webaudio/webaudio.mjs

@@ -9,7 +9,7 @@ import {
   superdough,
   getAudioContext,
   setLogger,
-  rawdspOutput,
+  rawdspTrigger,
   registerWorklet,
   setAudioContext,
   initAudio,
@@ -32,8 +32,8 @@ const hap2value = (hap) => {
 };
 
 // uses more precise, absolute t if available, see https://github.com/tidalcycles/strudel/pull/1004
-export const webaudioOutput = (hap, t, cps) => {
-  const hapDuration = hap.duration / cps;
+// TODO: refactor output callbacks to eliminate deadline
+export const webaudioOutput = (hap, _deadline, hapDuration, cps, t) => {
   return superdough(hap2value(hap), t, hapDuration, cps, hap.whole?.begin.valueOf());
 };
 
@@ -167,14 +167,14 @@ export function webaudioRepl(options = {}) {
   setAudioContext(audioContext);
   options = {
     getTime: () => audioContext.currentTime,
-    onSchedule: webaudioOutput,
+    defaultOutput: webaudioOutput,
     ...options,
   };
   return repl(options);
 }
 
 Pattern.prototype.rawdsp = function () {
-  return this.onSchedule(rawdspOutput, 1);
+  return this.onTrigger(rawdspTrigger, 1);
 };
 
 function audioBufferToWav(buffer, opt) {

packages/xen/tune.mjs

@@ -8,14 +8,11 @@ import Tune from './tunejs.js';
 import { register } from '@strudel/core';
 
 /**
- * Deprecated.
- *
  * Assumes pattern contains numerical scale degrees on the `i` control (see examples below). Accepts a scale name or list of frequencies (see all available names at the link on the reference). Returns a new pattern with all values mapped to a frequency ratio. Similar to `xen`.
  * @name tune
  * @returns Pattern
  * @memberof Pattern
  * @param {(string | number[] )} scale
- * @deprecated
  * @example
  * i("0 1 2 3 4 5").tune("hexany15").mul("220").freq()
  * @example

packages/xen/xen.mjs

@@ -4,7 +4,7 @@ Copyright (C) 2022 Strudel contributors - see <https://codeberg.org/uzu/strudel/
 This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more details. You should have received a copy of the GNU Affero General Public License along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-import { register, _mod, parseNumeral, removeUndefineds, Pattern, parray, State } from '@strudel/core';
+import { register, _mod, parseNumeral, removeUndefineds } from '@strudel/core';
 import Tune from './tunejs.js';
 
 // returns a list of frequency ratios for given edo scale
@@ -61,8 +61,14 @@ function xenOffset(xenScale, offset, index = 0) {
 
 const trimFreq = (freq) => parseFloat(freq.toPrecision(10));
 
+// accepts a scale name such as 31edo, and a pattern
+// pattern expected to follow format such that a value can be mapped
+// to an edostep within the scale. Returns the pattern with
+// values mapped to the frequencies associated with the given edosteps
+// scaleNameOrRatios: string || number[], steps?: number
+
 /**
- * Assumes a numerical pattern of scale steps, and a scale. Scales accepted are all preset scale names of `tune`, arbitrary edos such as 31edo, or an array of frequency ratios. Assumes scales repeat at octave (2/1). Returns a new pattern with all values mapped to their associated frequency, assuming a base frequency of 220hz. See first 4 examples for the different ways you can input a scale into `xen`
+ * Assumes a numerical pattern of scale steps, and a scale. Scales accepted are all preset scale names of `tune`, arbitrary edos such as 31edo, or an array of frequency ratios. Assumes scales repeat at octave (2/1). Returns a new pattern with all values mapped to their associated frequency, assuming a base frequency of 220hz.
  *
  * @name xen
  * @returns Pattern
@@ -81,15 +87,6 @@ const trimFreq = (freq) => parseFloat(freq.toPrecision(10));
  *   Math.pow(2, 18/31),
  * ]).piano()
  * @example
- * // However, with the above you won't get highlighting of the scale indices,
- * // instead you could do something like:
- * i("[<2 ->, 0 1 <- 2> 3]*2").xen([
- *   "1:1", // tonic
- *   "5:4", // Major 3rd
- *   "[3:2 4:3]", // Perfect 5th, 4th
- *   "5:3" // Major 6th
- * ]).s("tri")
- * @example
  * // xen also supports all scale names that
  * // tune does:
  * i("0 1 2 3 4 5").xen("hexany15")
@@ -99,100 +96,27 @@ const trimFreq = (freq) => parseFloat(freq.toPrecision(10));
  * i("0 1 2 3 4 5 6 7").xen("<5edo 10edo 15edo hexany15>")
  */
 
-export const xen = register(
-  'xen',
-  function (scaleNameOrRatios, pat) {
-    const JIsc2 = (input) => {
-      let k = parray(input);
-
-      return new Pattern((state) => {
-        let res = k.withValue((x) => x.map((y) => y.reduce((acc, v) => acc / v))).query(state);
-        return res;
-      });
-    };
-
-    const query = (state) => {
-      let haps = pat.query(state);
-      let resHaps = [];
-
-      haps.forEach((hap) => {
-        let hVal = hap.value;
-        const isObject = typeof hVal === 'object';
-        if (!isObject) {
-          throw new Error(
-            `Expected hap to have control 'i' set, but received ${hap.value.i}, try wrapping input in i()`,
-          );
-        }
-        const { i, ...otherValues } = hVal;
-        let edo = false;
-        let st = new State(hap.wholeOrPart().intersection(state.span), state.controls);
-
-        // Format: An array of values
-        // Each value is a pattern, representing an index on the scale
-        let sc = scaleNameOrRatios.query(st);
-        // Check to see if input is attempting to be a named scale or a raw scale
-        let isStr = typeof sc[0].value == 'string';
-        let isRawScale = Array.isArray(sc[0].value) && sc[0].value.every((x) => typeof x == 'number');
-        if (!isStr && !isRawScale) {
-          sc = sc[0].value;
-        } else if (isRawScale) {
-          sc = getXenScale(sc[0].value);
-        }
-
-        if (!isStr && !isRawScale) {
-          let scaleByIndices = [];
-          for (let j = 0; j < sc.length; j++) {
-            scaleByIndices[j] = sc[j].query(st);
-          }
-          /* 
-          Format: An array of 1 or more Haps, each Hap has an array of values of 
-            one or more scale index definitions (contains whole scale)
-          Assumption: inner value array should be same length between each
-          */
-          let sc2 = JIsc2(sc).query(st);
-
-          let index = _mod(i, sc.length);
-          for (let j = 0; j < scaleByIndices[index].length; j++) {
-            let scale = getXenScale(sc2[j].value);
-            let freq = xenOffset(scale, parseNumeral(i));
-            let newHap = hap;
-            freq = trimFreq(freq);
-            newHap.value = { ...otherValues, freq };
-            newHap = newHap.setContext(newHap.combineContext(scaleByIndices[index][j]));
-            resHaps.push(newHap);
-          }
-        } else if (isRawScale) {
-          let freq = xenOffset(sc, parseNumeral(i));
-          let newHap = hap;
-          freq = trimFreq(freq);
-          newHap.value = { ...otherValues, freq };
-          resHaps.push(newHap);
-        } else if (isStr) {
-          // scale is named scale(s)
-          for (let j = 0; j < sc.length; j++) {
-            let scaleName = sc[j].value;
-            let scale = getXenScale(scaleName);
-            let freq = xenOffset(scale, parseNumeral(i));
-            let newHap = hap;
-            freq = trimFreq(freq);
-            newHap.value = { ...otherValues, freq };
-            newHap = newHap.setContext(newHap.combineContext(sc[j]));
-            if (isEdo(scaleName)) {
-              edo = scaleName.match(/^([1-9]+[0-9]*)edo$/)[1];
-              newHap = newHap.setContext({ ...newHap.context, edoSize: edo });
-            }
-            resHaps.push(newHap);
-          }
-        } else {
-          throw new Error('failed to parse scale');
-        }
-      });
-      return resHaps;
-    };
-    return new Pattern(query);
-  },
-  false,
-);
+export const xen = register('xen', function (scaleNameOrRatios, pat) {
+  return pat.withHaps((haps) => {
+    haps = haps.map((hap) => {
+      let hVal = hap.value;
+      const isObject = typeof hVal === 'object';
+      if (!isObject) {
+        throw new Error(`Expected hap to have control 'i' set, but received ${hap.value.i}, try wrapping input in i()`);
+      }
+      const { i, ...otherValues } = hVal;
+      const scale = getXenScale(scaleNameOrRatios);
+      let freq = xenOffset(scale, parseNumeral(hVal.i));
+      // 10 is somewhat arbitrary
+      freq = trimFreq(freq);
+      hap.value = { ...otherValues, freq };
+      return isEdo(scaleNameOrRatios)
+        ? hap.setContext({ ...hap.context, edoSize: scaleNameOrRatios.match(/^([1-9]+[0-9]*)edo$/)[1] })
+        : hap;
+    });
+    return removeUndefineds(haps);
+  });
+});
 
 /**
  * Assumes pattern of frequencies tuned to some `base` frequency, such as the output of `xen`

pnpm-lock.yaml

@@ -299,12 +299,6 @@ importers:
       '@strudel/core':
         specifier: workspace:*
         version: link:../core
-      '@strudel/osc':
-        specifier: workspace:*
-        version: link:../osc
-      '@strudel/webaudio':
-        specifier: workspace:*
-        version: link:../webaudio
       '@tauri-apps/api':
         specifier: ^2.2.0
         version: 2.2.0

pnpm-workspace.yaml

@@ -4,19 +4,18 @@ packages:
   - tools/dbpatch
   - website/
 
-catalog:
-  '@codemirror/autocomplete': ^6.18.4
-  '@codemirror/commands': ^6.8.0
-  '@codemirror/lang-javascript': ^6.2.2
-  '@codemirror/language': ^6.10.8
-  '@codemirror/search': ^6.5.8
-  '@codemirror/state': ^6.5.1
-  '@codemirror/view': ^6.36.2
-
-ignoredBuiltDependencies:
-  - '@serialport/bindings-cpp'
-  - tree-sitter-haskell
-  - tree-sitter
+onlyBuiltDependencies:
   - esbuild
   - nx
   - sharp
+  - tree-sitter
+  - tree-sitter-haskell
+
+catalog:
+  "@codemirror/commands": "^6.8.0"
+  "@codemirror/language": "^6.10.8"
+  "@codemirror/lang-javascript": "^6.2.2"
+  "@codemirror/state": "^6.5.1"
+  "@codemirror/view": "^6.36.2"
+  "@codemirror/autocomplete": "^6.18.4"
+  "@codemirror/search": "^6.5.8"

test/__snapshots__/tunes.test.mjs.snap

@@ -7322,12 +7322,12 @@ exports[`renders tunes > tune: randomBells 1`] = `
 [
   "[ -9/8 ⇜ (0/1 → 3/8) | gain:0.6 note:A3 velocity:0.598990320228 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ -3/4 ⇜ (0/1 → 3/4) | gain:0.6 note:C5 velocity:0.836992966942 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 0/1 → 3/2 | note:D2 s:bass clip:1 gain:0.8 ]",
+  "[ 0/1 → 3/2 | note:F2 s:bass clip:1 gain:0.8 ]",
   "[ 0/1 → 9/4 | gain:0.6 note:D3 velocity:0.5 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 3/8 → 21/8 | gain:0.6 note:F5 velocity:0.921303892508 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 3/4 → 3/1 | gain:0.6 note:C5 velocity:0.842607785016 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 3/2 → 9/4 | note:D2 s:bass clip:1 gain:0.8 ]",
-  "[ 9/4 → 3/1 | note:D2 s:bass clip:1 gain:0.8 ]",
+  "[ 3/2 → 9/4 | note:F2 s:bass clip:1 gain:0.8 ]",
+  "[ 9/4 → 3/1 | note:F2 s:bass clip:1 gain:0.8 ]",
   "[ 9/4 → 9/2 | gain:0.6 note:D4 velocity:0.700696257874 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 21/8 → 39/8 | gain:0.6 note:C4 velocity:0.650794394314 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 3/1 → 9/2 | note:D2 s:bass clip:1 gain:0.8 ]",
@@ -7339,12 +7339,12 @@ exports[`renders tunes > tune: randomBells 1`] = `
   "[ (21/4 → 6/1) ⇝ 27/4 | gain:0.6 note:D4 velocity:0.698815540411 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 39/8 ⇜ (6/1 → 51/8) | gain:0.6 note:D5 velocity:0.875811336562 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 21/4 ⇜ (6/1 → 27/4) | gain:0.6 note:D4 velocity:0.698815540411 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 6/1 → 15/2 | note:A2 s:bass clip:1 gain:0.8 ]",
+  "[ 6/1 → 15/2 | note:D2 s:bass clip:1 gain:0.8 ]",
   "[ 6/1 → 33/4 | gain:0.6 note:G4 velocity:0.75977108255 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 51/8 → 69/8 | gain:0.6 note:G4 velocity:0.774316444062 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 27/4 → 9/1 | gain:0.6 note:C5 velocity:0.836244757287 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 15/2 → 33/4 | note:A2 s:bass clip:1 gain:0.8 ]",
-  "[ 33/4 → 9/1 | note:A2 s:bass clip:1 gain:0.8 ]",
+  "[ 15/2 → 33/4 | note:D2 s:bass clip:1 gain:0.8 ]",
+  "[ 33/4 → 9/1 | note:D2 s:bass clip:1 gain:0.8 ]",
   "[ 33/4 → 21/2 | gain:0.6 note:A3 velocity:0.59140187595 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 69/8 → 87/8 | gain:0.6 note:G4 velocity:0.754063542932 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 9/1 → 21/2 | note:A2 s:bass clip:1 gain:0.8 ]",
@@ -7356,12 +7356,12 @@ exports[`renders tunes > tune: randomBells 1`] = `
   "[ (45/4 → 12/1) ⇝ 51/4 | gain:0.6 note:A4 velocity:0.797278589569 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 87/8 ⇜ (12/1 → 99/8) | gain:0.6 note:F4 velocity:0.734787144698 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 45/4 ⇜ (12/1 → 51/4) | gain:0.6 note:A4 velocity:0.797278589569 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 12/1 → 27/2 | note:G2 s:bass clip:1 gain:0.8 ]",
+  "[ 12/1 → 27/2 | note:A2 s:bass clip:1 gain:0.8 ]",
   "[ 12/1 → 57/4 | gain:0.6 note:G5 velocity:0.979763559997 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 99/8 → 117/8 | gain:0.6 note:C4 velocity:0.666239210404 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 51/4 → 15/1 | gain:0.6 note:F5 velocity:0.95169514697 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 27/2 → 57/4 | note:G2 s:bass clip:1 gain:0.8 ]",
-  "[ 57/4 → 15/1 | note:G2 s:bass clip:1 gain:0.8 ]",
+  "[ 27/2 → 57/4 | note:A2 s:bass clip:1 gain:0.8 ]",
+  "[ 57/4 → 15/1 | note:A2 s:bass clip:1 gain:0.8 ]",
   "[ 57/4 → 33/2 | gain:0.6 note:F5 velocity:0.918253320269 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 117/8 → 135/8 | gain:0.6 note:G3 velocity:0.571157105267 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 15/1 → 33/2 | note:G2 s:bass clip:1 gain:0.8 ]",
@@ -7373,12 +7373,12 @@ exports[`renders tunes > tune: randomBells 1`] = `
   "[ (69/4 → 18/1) ⇝ 75/4 | gain:0.6 note:F3 velocity:0.508127085865 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 135/8 ⇜ (18/1 → 147/8) | gain:0.6 note:F5 velocity:0.945647025481 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 69/4 ⇜ (18/1 → 75/4) | gain:0.6 note:F3 velocity:0.508127085865 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 18/1 → 39/2 | note:F2 s:bass clip:1 gain:0.8 ]",
+  "[ 18/1 → 39/2 | note:G2 s:bass clip:1 gain:0.8 ]",
   "[ 18/1 → 81/4 | gain:0.6 note:A3 velocity:0.608644555323 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 147/8 → 165/8 | gain:0.6 note:F3 velocity:0.506259439513 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 75/4 → 21/1 | gain:0.6 note:D4 velocity:0.671621939167 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
-  "[ 39/2 → 81/4 | note:F2 s:bass clip:1 gain:0.8 ]",
-  "[ 81/4 → 21/1 | note:F2 s:bass clip:1 gain:0.8 ]",
+  "[ 39/2 → 81/4 | note:G2 s:bass clip:1 gain:0.8 ]",
+  "[ 81/4 → 21/1 | note:G2 s:bass clip:1 gain:0.8 ]",
   "[ 81/4 → 45/2 | gain:0.6 note:D4 velocity:0.704345900565 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 165/8 → 183/8 | gain:0.6 note:D5 velocity:0.887838857248 s:bell delay:0.2 delaytime:0.333333333333 delayfeedback:0.8 ]",
   "[ 21/1 → 45/2 | note:F2 s:bass clip:1 gain:0.8 ]",

website/astro.config.mjs

@@ -73,7 +73,6 @@ export default defineConfig({
       workbox: {
         maximumFileSizeToCacheInBytes: 4194304, // 4MB
         globPatterns: ['**/*.{js,css,html,ico,png,svg,json,wav,mp3,ogg,ttf,woff2,TTF,otf}'],
-        globIgnores: ['img/**', '_astro/csound*.js'],
         runtimeCaching: [
           {
             urlPattern: ({ url }) =>
@@ -89,7 +88,7 @@ export default defineConfig({
               cacheName: 'external-samples',
               expiration: {
                 maxEntries: 5000,
-                maxAgeSeconds: 60 * 60 * 24 * 30, // <== 30 days
+                maxAgeSeconds: 60 * 60 * 24 * 30, // <== 14 days
               },
               cacheableResponse: {
                 statuses: [0, 200],

website/src/docs/MiniRepl.jsx

@@ -22,7 +22,7 @@ export function MiniRepl({
   tunes,
   hideHeader = false,
   canvasHeight = 100,
-  onSchedule,
+  onTrigger,
   punchcard,
   punchcardLabels = true,
   claviature,
@@ -48,7 +48,7 @@ export function MiniRepl({
 
     const editor = new StrudelMirror({
       id,
-      onSchedule: webaudioOutput,
+      defaultOutput: webaudioOutput,
       getTime: () => getAudioContext().currentTime,
       transpiler,
       autodraw,
@@ -58,8 +58,8 @@ export function MiniRepl({
       drawTime,
       drawContext,
       editPattern: (pat, id) => {
-        if (onSchedule) {
-          pat = pat.onSchedule(onSchedule, false);
+        if (onTrigger) {
+          pat = pat.onTrigger(onTrigger, false);
         }
         if (claviature) {
           pat = pat.onPaint((ctx, time, haps, drawTime) => {

website/src/env.d.ts

@@ -2,6 +2,3 @@
 /// <reference types="astro/client" />
 
 declare module 'date-fns';
-declare module '@strudel/*';
-declare module 'dough-synth';
-declare module 'paho-mqtt';

website/src/layouts/MainLayout.astro

@@ -36,7 +36,7 @@ const githubEditUrl = `${CONFIG.GITHUB_EDIT_URL}/${currentFile}`;
         <Header currentPage={currentPage} />
       </header>
       <main class="relative pt-16">
-        <div class="h-full top-0 overflow-auto min-w-[300px] flex xl:justify-center pr-4 pl-4 md:pl-[300px] xl:pr-[300px]">
+        <div class="h-full top-0 overflow-auto min-w-[300px] flex xl:justify-center pr-4 pl-4 md:pl-[300px] xl:pl-0">
           <aside title="Site Navigation" class="w-[300px] px-6 left-0 hidden md:block fixed h-full">
             <LeftSidebar currentPage={currentPage} />
           </aside>

website/src/my_patterns.js

@@ -1,7 +1,7 @@
 import { getMetadata } from './metadata_parser';
 
 export function getMyPatterns() {
-  const my = import.meta.glob('../../my-patterns/**', { query: '?raw', eager: true });
+  const my = import.meta.glob('../../my-patterns/**', { as: 'raw', eager: true });
   return Object.fromEntries(
     Object.entries(my)
       .filter(([name]) => name.endsWith('.txt'))

website/src/pages/learn/effects.mdx

@@ -33,7 +33,7 @@ The signal chain in Strudel is as follows:
     - This is where the main (volume) ADSR happens
   - A lowpass filter (`lpf`)
   - A highpass filter (`hpf`)
-  - A bandpass filter (`bpf`)
+  - A bandpass filter (`bandpass`)
   - A vowel filter (`vowel`)
   - Sample rate reduction (`coarse`)
   - Bit crushing (`crush`)
@@ -184,9 +184,9 @@ Each filter has 2 parameters:
 
 Amplitude modulation changes the amplitude (gain) periodically over time.
 
-## tremolo
+## am
 
-<JsDoc client:idle name="tremolo" h={0} />
+<JsDoc client:idle name="am" h={0} />
 
 ## tremolosync
 

website/src/pages/learn/factories.mdx

@@ -18,6 +18,7 @@ These are the equivalents used by the Mini Notation:
 | `stack(x, y)`                  | `"x,y"`          |
 | `stepcat([3,x],[2,y])`         | `"x@3 y@2"`      |
 | `polymeter([a, b, c], [x, y])` | `"{a b c, x y}"` |
+| `polymeterSteps(2, x, y, z)`   | `"{x y z}%2"`    |
 | `silence`                      | `"~"`            |
 
 ## cat
@@ -44,6 +45,10 @@ These are the equivalents used by the Mini Notation:
 
 <JsDoc client:idle name="polymeter" h={0} />
 
+## polymeterSteps
+
+<JsDoc client:idle name="polymeterSteps" h={0} />
+
 ## silence
 
 <JsDoc client:idle name="silence" h={0} />

website/src/pages/learn/faq.mdx

@@ -346,11 +346,3 @@ s   increase by one semitone, i.e. sharp, works for steps of scales, note names
 $:  at the start of a line, defines a member of the stack. is the only stack name that should occur multiple names
 _   before a stack name: mutes the stack, i.e. hush(), for example _$: s("bd"), see above for a different usage.
 ```
-
-## What is a 'hap'?
-
-A 'hap' is a name for a thing that happens, e.g. `note("c3 -")` playing a note and then stopping after a while. Haps have a start and an end. Every separate sound that is produced by strudel is a hap on its own.
-
-We would have called it 'event' if this particular name wasn't used by JavaScript to describe things that happen on html pages, like clicking on a button or hovering over a line of text.
-
-Since strudel is written in JavaScript, this confusion of having the same name for different things is avoided by calling events 'haps'.

website/src/pages/learn/samples.mdx

@@ -329,7 +329,7 @@ Sampler effects are functions that can be used to change the behaviour of sample
 
 ### begin
 
-<JsDoc client:idle name="begin" h={0} />
+<JsDoc client:idle name="Pattern.begin" h={0} />
 
 ### end
 

website/src/pages/learn/signals.mdx

@@ -55,14 +55,6 @@ There is also `saw2`, `sine2`, `cosine2`, `tri2`, `square2` and `rand2` which ha
 
 <JsDoc client:idle name="brandBy" h={0} />
 
-## time
-
-<JsDoc client:idle name="time" h={0} />
-
-## creating your own signal
-
-<JsDoc client:idle name="signal" h={0} />
-
 ## mouseX
 
 <JsDoc client:idle name="mousex" h={0} />

website/src/pages/learn/xen.mdx

@@ -12,17 +12,11 @@ import { JsDoc } from '../../docs/JsDoc';
 
 These functions allow the use of scales other than your typical chromatic 12 based ones.
 
-### xen(scaleOrRatios)
-
-{/* TODO add explanation of EDO to documentation */}
-
-<JsDoc client:idle name="Pattern.xen" h={0} />
-
 ### tune(scale)
 
 {/* TODO (maybe): combine jsdoc things in tune.mjs with here */}
 
-{/* <JsDoc client:idle name="tune" h={0} /> */}
+<JsDoc client:idle name="tune" h={0} />
 
 Here's an example of how to configure a basic hexany scale:
 
@@ -116,3 +110,9 @@ You can also give tune a list of frequencies to use as the scale:
     523.2511306012
   ]).mul(220).freq();`}
 />
+
+### xen(scaleOrRatios)
+
+{/* TODO add explanation of EDO to documentation */}
+
+<JsDoc client:idle name="Pattern.xen" h={0} />

website/src/pages/technical-manual/internals.mdx

@@ -186,9 +186,9 @@ These functions are more low level, probably not needed by the live coder.
 
 # Other
 
-## onSchedule
+## onTrigger
 
-<JsDoc client:idle name="Pattern#onSchedule" h={0} />
+<JsDoc client:idle name="Pattern#onTrigger" h={0} />
 
 ## log
 

website/src/pages/technical-manual/patterns.mdx

@@ -8,7 +8,7 @@ import { JsDoc } from '../../docs/JsDoc';
 
 # Patterns
 
-Patterns are the essence of Uzu languages such as Strudel and Tidal. Its patterns are abstract entities that represent flows of time as functions, adapting a technique called pure functional reactive programming. Taking a time span as its input, a Pattern can output a set of events that happen within that time span. It depends on the structure of the Pattern how the events are located in time.
+Patterns are the essence of Tidal. Its patterns are abstract entities that represent flows of time as functions, adapting a technique called pure functional reactive programming. Taking a time span as its input, a Pattern can output a set of events that happen within that time span. It depends on the structure of the Pattern how the events are located in time.
 From now on, this process of generating events from a time span will be called **querying**.
 Example:
 

website/src/pages/technical-manual/repl.mdx

@@ -17,7 +17,7 @@ Besides a UI for playback control and meta information, the main part of the REP
 
 1. The user writes and updates code. Each update transpiles and evaluates it to create a `Pattern` instance
 2. While the REPL is running, the `Scheduler` queries the active `Pattern` by a regular interval, generating `Events` (also known as `Haps` in Strudel) for the next time span.
-3. For each scheduling tick, all generated `Events` are triggered by calling their `onSchedule` method, which is set by the output.
+3. For each scheduling tick, all generated `Events` are triggered by calling their `onTrigger` method, which is set by the output.
 
 <img src="https://codeberg.org/uzu/strudel/raw/branch/talk/talk/public/strudelflow.png" width="600" />
 
@@ -134,7 +134,10 @@ let minLatency = 0.1; // min time before a hap should trigger
 setInterval(() => {
   const haps = pattern.queryArc(time, time + interval);
   time += interval; // increment time
-  haps.forEach((hap) => onSchedule(hap, hap.whole.begin + minLatency));
+  haps.forEach((hap) => {
+    const deadline = hap.whole.begin - time + minLatency;
+    onTrigger(hap, deadline, duration);
+  });
 }, interval * 1000); // query each "interval" seconds
 ```
 
@@ -178,19 +181,20 @@ This example creates the custom control parameters `x` and `y` which are then us
 
 ### Outputs
 
-Now that we know how the value of an hap is manipulated using control parameters, we can look at how outputs can use that value to generate anything. The scheduler above was calling the `onSchedule` function which is used to implement the output. A very simple version of the web audio output could look like this:
+Now that we know how the value of an event is manipulated using control parameters, we can look at how outputs can use that value to generate anything. The scheduler above was calling the `onTrigger` function which is used to implement the output. A very simple version of the web audio output could look like this:
 
 ```js
-function onSchedule(hap, time, cps) {
+function onTrigger(hap, deadline, duration) {
   const { note } = hap.value;
+  const time = getAudioContext().currentTime + deadline;
   const o = getAudioContext().createOscillator();
   o.frequency.value = getFreq(note);
   o.start(time);
-  o.stop(time + hap.duration / cps);
+  o.stop(time + event.duration);
   o.connect(getAudioContext().destination);
 }
 ```
 
-The above example will create an `OscillatorNode` for each hap, where the frequency is controlled by the `note` param. In essence, this is how the WebAudio API output of Strudel works, only with many more parameters to control synths, samples and effects.
+The above example will create an `OscillatorNode` for each event, where the frequency is controlled by the `note` param. In essence, this is how the WebAudio API output of Strudel works, only with many more parameters to control synths, samples and effects.
 
 I want to help, how do I contribute to the [Docs](/technical-manual/docs)?

website/src/repl/audiograph.mjs

@@ -628,7 +628,7 @@ export const debugAudiograph = async (argOptions = {}) => {
 
   /*global all*/
   all((pat) =>
-    pat.onSchedule(async (hap, t, cps) => {
+    pat.onTrigger(async (hap, duration, cps, t) => {
       hap_count++;
       const key = Object.entries(hap.value)
         .map((param) => param.join('/'))
@@ -643,7 +643,7 @@ export const debugAudiograph = async (argOptions = {}) => {
         return;
       }
 
-      await webaudioOutput(hap, t, cps);
+      await webaudioOutput(hap, t, hap.duration / cps, cps, t);
 
       if (hapsBatch && hap_count % hapsBatch === 0) drawDiagram();
     }),

website/src/repl/components/panel/PatternsTab.jsx

@@ -9,9 +9,7 @@ import {
   userPattern,
 } from '../../../user_pattern_utils.mjs';
 import { useMemo, useRef } from 'react';
-import { getMetadata } from '../../../metadata_parser.js';
 import { useExamplePatterns } from '../../useExamplePatterns.jsx';
-import { parseJSON, isUdels } from '../../util.mjs';
 import { useSettings } from '../../../settings.mjs';
 import { ActionButton } from '../button/action-button.jsx';
 import { Pagination } from '../pagination/Pagination.jsx';
@@ -20,8 +18,13 @@ import { useDebounce } from '../usedebounce.jsx';
 import cx from '@src/cx.mjs';
 import { Textbox } from '@src/repl/components/panel/SettingsTab.jsx';
 
+const PATTERN_SORT = {
+  "NEWEST": "most recent",
+  "A-Z": "A-Z",
+}
+
 export function PatternLabel({ pattern } /* : { pattern: Tables<'code'> } */) {
-  const meta = useMemo(() => getMetadata(pattern.code), [pattern]);
+  const meta = pattern.meta
 
   let title = meta.title;
   if (title == null) {
@@ -58,6 +61,10 @@ function PatternButtons({ patterns, activePattern, onClick, started }) {
   return (
     <div className="p-2">
       {Object.values(patterns)
+        .sort((a, b) => {
+          return (b.meta.title ?? "").localeCompare(a.meta.title ?? "")
+
+        })
         .reverse()
         .map((pattern) => {
           const id = pattern.id;
@@ -93,7 +100,7 @@ export function PatternsTab({ context }) {
     }
     return Object.fromEntries(
       Object.entries(userPatterns).filter(([_key, pattern]) => {
-        const meta = getMetadata(pattern.code);
+        const meta = pattern.meta;
 
         // Search for specific meta keys
         const searchLowercaseTrimmed = search.trim().toLowerCase();

website/src/repl/idbutils.mjs

@@ -1,4 +1,4 @@
-import { registerSampleSource } from '@strudel/webaudio';
+import { extractMidiNoteFromString, registerSampleSource } from '@strudel/webaudio';
 import { isAudioFile } from './files.mjs';
 import { logger } from '@strudel/core';
 
@@ -47,7 +47,7 @@ export function registerSamplesFromDB(config = userSamplesDBConfig, onComplete =
       Promise.all(
         [...soundFiles]
           .sort((a, b) => a.title.localeCompare(b.title, undefined, { numeric: true, sensitivity: 'base' }))
-          .map((soundFile, i) => {
+          .map((soundFile) => {
             const title = soundFile.title;
             if (!isAudioFile(title)) {
               return;
@@ -58,25 +58,26 @@ export function registerSamplesFromDB(config = userSamplesDBConfig, onComplete =
               splitRelativePath[splitRelativePath.length - 2] ?? soundFile.id.split(/\W+/)[0] ?? 'user';
             const blob = soundFile.blob;
 
-            return blobToDataUrl(blob).then((soundPath) => {
-              const titlePathMap = sounds.get(parentDirectory) ?? new Map();
+            return blobToDataUrl(blob).then((path) => {
+              const sampleInfoMap = sounds.get(parentDirectory) ?? new Map();
+              const midi = extractMidiNoteFromString(title);
+              /** @type {import('@strudel/webaudio').SampleMetaData} */
+              const samplemetadata = { url: path, midi };
+              sampleInfoMap.set(title, samplemetadata);
 
-              titlePathMap.set(title, soundPath);
-
-              sounds.set(parentDirectory, titlePathMap);
+              sounds.set(parentDirectory, sampleInfoMap);
               return;
             });
           }),
       )
         .then(() => {
-          sounds.forEach((titlePathMap, key) => {
-            const value = Array.from(titlePathMap.keys())
+          sounds.forEach((sampleInfoMap, key) => {
+            const bank = Array.from(sampleInfoMap.keys())
               .sort((a, b) => {
                 return a.localeCompare(b);
               })
-              .map((title) => titlePathMap.get(title));
-
-            registerSampleSource(key, value, { prebake: false });
+              .map((title) => sampleInfoMap.get(title));
+            registerSampleSource(key, bank, { prebake: false });
           });
 
           logger('imported sounds registered!', 'success');

website/src/repl/useReplContext.jsx

@@ -68,7 +68,7 @@ const initialCode = `// LOADING`;
 export function useReplContext() {
   const { isSyncEnabled, audioEngineTarget, prebakeScript, includePrebakeScriptInShare } = useSettings();
   const shouldUseWebaudio = audioEngineTarget !== audioEngineTargets.osc;
-  const onSchedule = shouldUseWebaudio ? webaudioOutput : superdirtOutput;
+  const defaultOutput = shouldUseWebaudio ? webaudioOutput : superdirtOutput;
   const getTime = shouldUseWebaudio ? getAudioContextCurrentTime : getPerformanceTimeSeconds;
   const init = useCallback(() => {
     setActivePattern(getViewingPatternData().id);
@@ -76,7 +76,7 @@ export function useReplContext() {
     const drawContext = getDrawContext();
     const editor = new StrudelMirror({
       sync: isSyncEnabled,
-      onSchedule,
+      defaultOutput,
       getTime,
       setInterval,
       clearInterval,

website/src/repl/util.mjs

@@ -1,15 +1,12 @@
-import * as strudelCore from '@strudel/core';
-import * as strudelWebaudio from '@strudel/webaudio';
+import { code2hash, errorLogger, evalScope, hash2code, logger } from '@strudel/core';
 import { settingPatterns } from '../settings.mjs';
-import { getMetadata } from '../metadata_parser.js';
+import { setVersionDefaults } from '@strudel/webaudio';
+import { getMetadata } from '../metadata_parser';
 import { isTauri } from '../tauri.mjs';
 import './Repl.css';
 import { createClient } from '@supabase/supabase-js';
 import { writeText } from '@tauri-apps/plugin-clipboard-manager';
-import { $featuredPatterns } from '@src/user_pattern_utils.mjs';
-
-const { setVersionDefaults } = strudelWebaudio;
-const { code2hash, errorLogger, evalScope, hash2code, logger } = strudelCore;
+import { $featuredPatterns /* , loadDBPatterns */ } from '@src/user_pattern_utils.mjs';
 
 // Create a single supabase client for interacting with your database
 export const supabase = createClient(
@@ -71,13 +68,13 @@ export async function getRandomTune() {
 
 export function loadModules() {
   let modules = [
-    strudelCore,
+    import('@strudel/core'),
     import('@strudel/draw'),
     import('@strudel/edo'),
     import('@strudel/tonal'),
     import('@strudel/mini'),
     import('@strudel/xen'),
-    strudelWebaudio,
+    import('@strudel/webaudio'),
     import('@strudel/codemirror'),
     import('@strudel/hydra'),
     import('@strudel/serial'),

website/src/settings.mjs

@@ -3,6 +3,7 @@ import { useStore } from '@nanostores/react';
 import { register } from '@strudel/core';
 import { isUdels } from './repl/util.mjs';
 import { computed } from 'nanostores';
+import { getMetadata } from './metadata_parser';
 
 export const audioEngineTargets = {
   webaudio: 'webaudio',
@@ -18,6 +19,10 @@ export const soundFilterType = {
   ALL: 'all',
 };
 
+export const PATTERN_SORT = {
+  "NEWEST": "most recent",
+  "A-Z": "A-Z",
+}
 const initialPrebakeScript = `// Prebake script
 //
 // This is code that is loaded before your pattern is run.
@@ -86,6 +91,7 @@ export const $settings = computed(settingsMap, (state) => {
   Object.keys(userPatterns).forEach((key) => {
     const data = userPatterns[key];
     data.id = data.id ?? key;
+    data.meta = getMetadata(data.code)
     userPatterns[key] = data;
   });
   return {
@@ -138,7 +144,7 @@ export const setIsZen = (active) => settingsMap.setKey('isZen', !!active);
 
 const patternSetting = (key) =>
   register(key, (value, pat) =>
-    pat.onSchedule(() => {
+    pat.onTrigger(() => {
       value = Array.isArray(value) ? value.join(' ') : value;
       if (value !== settingsMap.get()[key]) {
         settingsMap.setKey(key, value);