prevent filter modulation pops

Merge pull request 'prefix "S" for solo' (#1481 ) from solo into main
Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1481
2026-07-21 20:55:12 -04:00 · 2025-11-22 18:21:24 -05:00 · 2025-11-23 00:03:31 +01:00 · 2025-11-22 17:17:41 -05:00 · 2025-11-22 17:11:17 -05:00 · 2025-11-22 16:40:31 -05:00
2 changed files with 15 additions and 4 deletions
@@ -152,9 +152,9 @@ export function repl({
        // allows muting a pattern x with x_ or _x
        return silence;
      }
-      if (id === '$') {
+      if (id.includes('$')) {
        // allows adding anonymous patterns with $:
-        id = `$${anonymousIndex}`;
+        id = `${id}${anonymousIndex}`;
        anonymousIndex++;
      }
      pPatterns[id] = this;
@@ -215,8 +215,19 @@ export function repl({
      let { pattern, meta } = await _evaluate(code, transpiler, transpilerOptions);
      if (Object.keys(pPatterns).length) {
        let patterns = [];
+        let soloActive = false;
        for (const [key, value] of Object.entries(pPatterns)) {
-          patterns.push(value.withState((state) => state.setControls({ id: key })));
+          // handle soloed patterns ex: S$: s("bd!4")
+          const isSolod = key.length > 1 && key.startsWith('S');
+          if (isSolod && soloActive === false) {
+            // first time we see a soloed pattern, clear existing patterns
+            patterns = [];
+            soloActive = true;
+          }
+          if (!soloActive || (soloActive && isSolod)) {
+            const valWithState = value.withState((state) => state.setControls({ id: key }));
+            patterns.push(valWithState);
+          }
        }
        if (eachTransform) {
          // Explicit lambda so only element (not index and array) are passed
@@ -238,7 +238,7 @@ export function createFilter(context, start, end, params, cps) {
  if (sync != null) {
    rate = cps * sync;
  }
-  const lfoValues = { depth, dcoffset, skew, shape, frequency: rate };
+  const lfoValues = { depth, dcoffset, skew, shape, frequency: rate, min: 10, max: 20000 };
  getParamLfo(context, frequencyParam, start, end, lfoValues);
  return filter;
 }
Author	SHA1	Message	Date
Jade (Rose) Rowland	1d5f3a4f30	prevent filter modulation pops	2025-11-22 18:21:24 -05:00
Switch Angel AKA Jade Rose	5fa6cb4653	Merge pull request 'prefix "S" for solo' (#1481 ) from solo into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1481	2025-11-23 00:03:31 +01:00
Jade (Rose) Rowland	19fd0fc649	rm unessecary file	2025-11-22 17:17:41 -05:00
Jade (Rose) Rowland	e72e26eb81	add comment	2025-11-22 17:11:17 -05:00
Jade (Rose) Rowland	1c4b05d55f	solo search n = 1	2025-11-22 16:40:31 -05:00
Aria	06bf17f444	Merge pull request 'Bug Fix: Use frac due to negative frequencies from FM' (#1759 ) from glossing/droponelettertosaveears into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1759	2025-11-21 01:56:10 +01:00
Switch Angel AKA Jade Rose	f4cf77f5c6	Merge branch 'main' into solo	2025-09-30 08:09:37 +02:00
Felix Roos	7f103e77e3	prefix "S" for solo	2025-07-28 04:05:21 +02:00