Merge branch 'main' into jade/orbitsynonym

synonym:
Merge pull request '[perf] fix connect-leak in fm modulation' (#1758 ) from jeromew/strudel:fix-perf6 into main
2026-09-16 18:56:57 -04:00 · 2025-11-23 19:06:16 -05:00 · 2025-11-23 19:05:57 -05:00 · 2025-11-23 22:23:24 +01:00 · 2025-11-23 09:47:22 +01:00 · 2025-11-23 04:23:04 +01:00
4 changed files with 13 additions and 6 deletions
@@ -1833,6 +1833,7 @@ export const { octave } = registerControl('octave');
 * An `orbit` is a global parameter context for patterns. Patterns with the same orbit will share the same global effects.
 *
 * @name orbit
+ * @synonyms o
 * @param {number | Pattern} number
 * @example
 * stack(
@@ -1840,7 +1841,7 @@ export const { octave } = registerControl('octave');
 *   s("~ sd ~ sd").delay(.5).delaytime(.125).orbit(2)
 * )
 */
-export const { orbit } = registerControl('orbit');
+export const { orbit } = registerControl('orbit', 'o');
 // TODO: what is this? not found in tidal doc Answer: gain is limited to maximum of 2. This allows you to go over that
 export const { overgain } = registerControl('overgain');
 // TODO: what is this? not found in tidal doc. Similar to above, but limited to 1
@@ -238,8 +238,8 @@ export function repl({
        pattern = eachTransform(pattern);
      }
      if (allTransforms.length) {
-        for (let i in allTransforms) {
-          pattern = allTransforms[i](pattern);
+        for (const transform of allTransforms) {
+          pattern = transform(pattern);
        }
      }

@@ -362,9 +362,9 @@ const mod = (freq, range = 1, type = 'sine') => {
  }

  osc.start();
-  const g = new GainNode(ctx, { gain: range });
+  const g = gainNode(range);
  osc.connect(g); // -range, range
-  return { node: g, stop: (t) => osc.stop(t) };
+  return { node: g, stop: (t) => osc.stop(t), osc: osc };
 };
 const fm = (frequencyparam, harmonicityRatio, modulationIndex, wave = 'sine') => {
  const carrfreq = frequencyparam.value;
@@ -416,6 +416,11 @@ export function applyFM(param, value, begin) {
      modulator.connect(envGain);
      envGain.connect(param);
    }
+    fmmod.osc.onended = () => {
+      envGain.disconnect();
+      modulator.disconnect();
+      fmmod.osc.disconnect();
+    };
  }
  return { stop };
 }
@@ -543,8 +543,9 @@ class SuperSawOscillatorProcessor extends AudioWorkletProcessor {
        if (pn >= 1.0) pn -= 1.0;
        this.phase[n] = pn;
        // invert right and left gain
+        const tmp = gainL;
        gainL = gainR;
-        gainR = gainL;
+        gainR = tmp;
      }
    }
    return true;
Author	SHA1	Message	Date
Jade (Rose) Rowland	8325b4cfc4	Merge branch 'main' into jade/orbitsynonym	2025-11-23 19:06:16 -05:00
Jade (Rose) Rowland	3b2df0b725	synonym:	2025-11-23 19:05:57 -05:00
froos	22f1512697	Merge pull request '[perf] fix `connect-leak` in `fm` modulation' (#1758 ) from jeromew/strudel:fix-perf6 into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1758	2025-11-23 22:23:24 +01:00
froos	9a05a679aa	Merge pull request 'Fix interoperability issue between `all` and `await initHydra()`' (#1663 ) from jeromew/strudel:jeromew-hydra-all into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1663	2025-11-23 09:47:22 +01:00
Aria	f7f3aa7668	Merge pull request 'Bug fix: Swap l/r gains with temp variable' (#1768 ) from glossing/stereo-bug into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1768	2025-11-23 04:23:04 +01:00
Aria	adc3a9ac6c	Swap with temp variable	2025-11-22 20:51:30 -06:00
Jade (Rose) Rowland	2efd56e331	add synonym	2025-11-22 18:10:28 -05:00
jeromew	d453c861d3	Merge branch 'fix-perf6' of https://codeberg.org/jeromew/strudel into fix-perf6	2025-11-21 09:01:02 +00:00
jeromew	f637b8b0dd	[perf] fix `connect-leak` in fm modulation	2025-11-21 09:00:17 +00:00
jeromew	907f03f3bf	[perf] fix `connect-leak` in fm modulation	2025-11-20 17:40:51 +00:00
jeromew	47c85f8540	fix interoperability of `all` with hydra Hydra add methods on Array.prototype which breaks the Array enumeration with for...in. Use for...of instead cf https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of#difference_between_for...of_and_for...in for details on the issue without this fix, it is impossible to use both `await initHydra()` and `all` in the same strudel code. Strudel errors with "Error: got "undefined" instead of pattern." example code: https://strudel.cc/#YXdhaXQgaW5pdEh5ZHJhKCkKCmFsbChwaWFub3JvbGwpCgokOiBzKCJiZCIp	2025-10-16 14:06:33 +02:00