add pregain + move postgain after sends

packages/codemirror/codemirror.mjs

@@ -323,7 +323,6 @@ export class StrudelMirror {
     this.editor.dispatch({ changes });
   }
   clear() {
-    this.stop();
     this.onStartRepl && document.removeEventListener('start-repl', this.onStartRepl);
   }
 }

packages/core/controls.mjs

@@ -87,7 +87,12 @@ const generic_params = [
    */
   ['gain'],
   /**
-   * Gain applied after all effects have been processed.
+   * Gain applied before effect sends (delay, reverb ...)
+   *
+   */
+  ['pregain'],
+  /**
+   * Gain applied after effect sends (delay, reverb ...)
    *
    * @name postgain
    * @example

packages/superdough/superdough.mjs

@@ -272,7 +272,8 @@ export const superdough = async (value, deadline, hapDuration) => {
     bank,
     source,
     gain = 0.8,
-    postgain = 1,
+    pregain = 1,
+    postgain,
     density = 0.03,
     // filters
     ftype = '12db',
@@ -470,16 +471,15 @@ export const superdough = async (value, deadline, hapDuration) => {
     chain.push(phaserFX);
   }
 
-  // last gain
-  const post = new GainNode(ac, { gain: postgain });
-  chain.push(post);
-  connectToDestination(post, channels);
+  // pre fx gain
+  const pre = new GainNode(ac, { gain: pregain });
+  chain.push(pre);
 
   // delay
   let delaySend;
   if (delay > 0 && delaytime > 0 && delayfeedback > 0) {
     const delyNode = getDelay(orbit, delaytime, delayfeedback, t);
-    delaySend = effectSend(post, delyNode, delay);
+    delaySend = effectSend(pre, delyNode, delay);
   }
   // reverb
   let reverbSend;
@@ -496,9 +496,16 @@ export const superdough = async (value, deadline, hapDuration) => {
       roomIR = await loadBuffer(url, ac, ir, 0);
     }
     const reverbNode = getReverb(orbit, roomsize, roomfade, roomlp, roomdim, roomIR);
-    reverbSend = effectSend(post, reverbNode, room);
+    reverbSend = effectSend(pre, reverbNode, room);
   }
 
+  let post = pre;
+  if (postgain !== undefined) {
+    // post fx gain
+    post = new GainNode(ac, { gain: postgain });
+    chain.push(post);
+  }
+  connectToDestination(post, channels);
   // analyser
   let analyserSend;
   if (analyze) {

website/src/repl/Repl.jsx

@@ -100,16 +100,6 @@ export function Repl({ embedded = false }) {
     });
 
     editorRef.current = editor;
-
-    if (import.meta.hot) {
-      import.meta.hot.dispose(() => {
-        editorRef.current.clear();
-        setTimeout(() => {
-          delete editorRef.current;
-          delete containerRef.current;
-        });
-      });
-    }
   }, []);
 
   const [replState, setReplState] = useState({});
@@ -209,7 +199,7 @@ export function Repl({ embedded = false }) {
             id="code"
             ref={(el) => {
               containerRef.current = el;
-              if (!editorRef.current && containerRef.current) {
+              if (!editorRef.current) {
                 init();
               }
             }}