disable fm for supersaw

Merge pull request 'corrected minor spelling mistake (#1425 )' (#1434 ) from tj-mueller/strudel_1425:spelling_mistake_1425 into main
Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1434
2026-09-23 05:26:37 -04:00 · 2025-07-04 22:29:18 +02:00 · 2025-06-30 13:28:09 +02:00 · 2025-06-30 11:51:39 +02:00
4 changed files with 7 additions and 17 deletions
@@ -126,7 +126,7 @@ export const getAudioDevices = async () => {
  return devicesMap;
 };

-let defaultDefaultValues = {
+const defaultDefaultValues = {
  s: 'triangle',
  gain: 0.8,
  postgain: 1,
@@ -150,17 +150,6 @@ let defaultDefaultValues = {
  fft: 8,
 };

-const defaultDefaultDefaultValues = Object.freeze({ ...defaultDefaultValues });
-
-export function setDefault(control, value) {
-  // const main = getControlName(control); // we cant do this because superdough is independent of strudel/core
-  defaultDefaultValues[control] = value;
-}
-
-export function resetDefaults() {
-  defaultDefaultValues = { ...defaultDefaultDefaultValues };
-}
-
 let defaultControls = new Map(Object.entries(defaultDefaultValues));

 export function setDefaultValue(key, value) {
@@ -121,7 +121,10 @@ export function registerSynthSounds() {
      const gainAdjustment = 1 / Math.sqrt(voices);
      getPitchEnvelope(o.parameters.get('detune'), value, begin, holdend);
      const vibratoOscillator = getVibratoOscillator(o.parameters.get('detune'), value, begin);
-      const fm = applyFM(o.parameters.get('frequency'), value, begin);
+      // const fm = applyFM(o.parameters.get('frequency'), value, begin);
+      // https://codeberg.org/uzu/strudel/issues/1428
+      // if you think about re-enabling this, please test with fm > 1 first
+      // it's like 10x gain, so it's really dangerous
      let envGain = gainNode(1);
      envGain = o.connect(envGain);

@@ -133,7 +136,7 @@ export function registerSynthSounds() {
          destroyAudioWorkletNode(o);
          envGain.disconnect();
          onended();
-          fm?.stop();
+          // fm?.stop();
          vibratoOscillator?.stop();
        },
        begin,
@@ -95,7 +95,7 @@ Diese Kombinationen von Buchstaben stehen für verschiedene Teile eines Schlagze
 - `mt` = **m**iddle tom
 - `ht` = **h**igh tom
 - `rd` = **r**i**d**e cymbal
- `rd` = **cr**ash cymbal
+- `cr` = **cr**ash cymbal

 Probier verschiedene Sounds aus!

@@ -13,7 +13,6 @@ import {
  resetGlobalEffects,
  resetLoadedSounds,
  initAudioOnFirstClick,
-  resetDefaults,
 } from '@strudel/webaudio';
 import { setVersionDefaultsFrom } from './util.mjs';
 import { StrudelMirror, defaultSettings } from '@strudel/codemirror';
@@ -182,7 +181,6 @@ export function useReplContext() {

  const resetEditor = async () => {
    (await getModule('@strudel/tonal'))?.resetVoicings();
-    resetDefaults();
    resetGlobalEffects();
    clearCanvas();
    clearHydra();
Author	SHA1	Message	Date
Felix Roos	168269a839	disable fm for supersaw	2025-07-04 22:29:18 +02:00
froos	caf6686d01	Merge pull request 'corrected minor spelling mistake (#1425 )' (#1434 ) from tj-mueller/strudel_1425:spelling_mistake_1425 into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1434	2025-06-30 13:28:09 +02:00
tj-mueller	c063fb6b1c	correct rd to cr	2025-06-30 11:51:39 +02:00