Swap with temp variable

Merge pull request 'FIX: prevent LFO filter modulation from popping from negative values' (#1767 ) from lpmod_improvements into main
Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1767
2026-09-17 11:09:51 -04:00 · 2025-11-22 20:51:30 -06:00 · 2025-11-23 00:52:27 +01:00 · 2025-11-22 18:21:24 -05:00 · 2025-11-23 00:03:31 +01:00
2 changed files with 3 additions and 2 deletions
@@ -238,7 +238,7 @@ export function createFilter(context, start, end, params, cps) {
  if (sync != null) {
    rate = cps * sync;
  }
-  const lfoValues = { depth, dcoffset, skew, shape, frequency: rate };
+  const lfoValues = { depth, dcoffset, skew, shape, frequency: rate, min: 10, max: 20000 };
  getParamLfo(context, frequencyParam, start, end, lfoValues);
  return filter;
 }
@@ -543,8 +543,9 @@ class SuperSawOscillatorProcessor extends AudioWorkletProcessor {
        if (pn >= 1.0) pn -= 1.0;
        this.phase[n] = pn;
        // invert right and left gain
+        const tmp = gainL;
        gainL = gainR;
-        gainR = gainL;
+        gainR = tmp;
      }
    }
    return true;
Author	SHA1	Message	Date
Aria	adc3a9ac6c	Swap with temp variable	2025-11-22 20:51:30 -06:00
Switch Angel AKA Jade Rose	2518b2aed2	Merge pull request 'FIX: prevent LFO filter modulation from popping from negative values' (#1767 ) from lpmod_improvements into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1767	2025-11-23 00:52:27 +01:00
Jade (Rose) Rowland	1d5f3a4f30	prevent filter modulation pops	2025-11-22 18:21:24 -05:00
Switch Angel AKA Jade Rose	5fa6cb4653	Merge pull request 'prefix "S" for solo' (#1481 ) from solo into main Reviewed-on: https://codeberg.org/uzu/strudel/pulls/1481	2025-11-23 00:03:31 +01:00