Another round of GCC fixes (#3115)

* Fix remaining <string> -> <cstring> for GCC compilation (#3114 follow-up)

MWerks' <string> header transitively includes C string functions
(memcpy, strlen, strcmp, etc.), but GCC/Clang's <string> is the C++
std::string header. These files all use C string functions and should
include <cstring> instead.

* Use std::isnan instead of isnan for GCC compilation

GCC's <cmath> places isnan in the std namespace. Using the unqualified
isnan fails to compile with GCC/Clang.

* Fix cCcD_Src types: s32 -> u32 for bitmask fields

cCcD_SrcObjCommonBase::mSPrm, cCcD_SrcObjTg::mType, and
cCcD_SrcObjAt::mType are used as bitmasks (SetType/SetSPrm take u32,
MskType/MskSPrm use u32, values like 0xFFFFFFFF are common in
aggregate inits). Change from s32 to u32 to match usage.

Also fix AT_TYPE_WOLF_ATTACK/AT_TYPE_UNK to use unsigned literals,
and remove now-unnecessary (s32) casts on hex literals in collision
source data.

* Mark dummy() functions as static to avoid multiple definition errors

These decomp artifact functions have the same name and signature across
TUs, causing linker errors when building as a single binary.

include/JSystem/JAudio2/JASGadget.h

@@ -2,7 +2,7 @@
 #define JASGADGET_H
 
 #include "JSystem/JUtility/JUTAssert.h"
-#include <string>
+#include <cstring>
 
 #ifdef __MWERKS__
 #define JAS_GLOBAL_INSTANCE_INIT

include/JSystem/JUtility/JUTFont.h

@@ -2,7 +2,7 @@
 #define JUTFONT_H
 
 #include "JSystem/JUtility/TColor.h"
-#include <string>
+#include <cstring>
 
 /**
 * @ingroup jsystem-jutility

include/SSystem/SComponent/c_cc_d.h

@@ -62,8 +62,8 @@ enum cCcD_ObjAtType {
     /* 0x10000000 */ AT_TYPE_10000000 = (1 << 28),
     /* 0x10000000 */ AT_TYPE_20000000 = (1 << 29),
     /* 0x40000000 */ AT_TYPE_WOLF_CUT_TURN = (1 << 30),
-    /* 0x80000000 */ AT_TYPE_WOLF_ATTACK = (1 << 31),
-    /* 0xD8000000 */ AT_TYPE_UNK = 0xD8000000
+    /* 0x80000000 */ AT_TYPE_WOLF_ATTACK = (1u << 31),
+    /* 0xD8000000 */ AT_TYPE_UNK = 0xD8000000u
 };
 
 struct cCcD_SrcTriAttr {
@@ -120,16 +120,16 @@ public:
 STATIC_ASSERT(0x40 == sizeof(cCcD_DivideArea));
 
 struct cCcD_SrcObjCommonBase {
-    /* 0x0 */ s32 mSPrm;
+    /* 0x0 */ u32 mSPrm;
 };
 
 struct cCcD_SrcObjTg {
-    /* 0x0 */ s32 mType;
+    /* 0x0 */ u32 mType;
     /* 0x4 */ cCcD_SrcObjCommonBase mBase;
 };  // Size: 0x8
 
 struct cCcD_SrcObjAt {
-    /* 0x0 */ s32 mType;
+    /* 0x0 */ u32 mType;
     /* 0x4 */ u8 mAtp;
     /* 0x8 */ cCcD_SrcObjCommonBase mBase;
 };  // Size: 0xC

include/d/d_save.h

@@ -1,7 +1,7 @@
 #ifndef D_SAVE_D_SAVE_H
 #define D_SAVE_D_SAVE_H
 
-#include <string>
+#include <cstring>
 #include "SSystem/SComponent/c_xyz.h"
 #include <dolphin/os.h>
 #include "global.h"

include/f_ap/f_ap_game.h

@@ -6,7 +6,7 @@
 #include "JSystem/JFramework/JFWDisplay.h"
 #include "JSystem/JUtility/JUTAssert.h"
 #include "CaptureScreen.h"
-#include <string>
+#include <cstring>
 
 void fapGm_After();
 void fapGm_Create();

include/global.h

@@ -152,4 +152,9 @@ static const float INF = 2000000000.0f;
 #define FABSF std::fabsf
 #endif
 
+#ifndef __MWERKS__
+#include <cmath>
+using std::isnan;
+#endif
+
 #endif

src/JSystem/J2DGraph/J2DManage.cpp

@@ -2,7 +2,7 @@
 
 #include "JSystem/J2DGraph/J2DManage.h"
 #include "JSystem/JSupport/JSUInputStream.h"
-#include <string>
+#include <cstring>
 
 void* J2DDataManage::get(char const* name) {
     J2DataManageLink* link;

src/JSystem/J2DGraph/J2DMaterialFactory.cpp

@@ -5,7 +5,7 @@
 #include "JSystem/J2DGraph/J2DScreen.h"
 #include "JSystem/JSupport/JSupport.h"
 #include "JSystem/JUtility/JUTResource.h"
-#include <string>
+#include <cstring>
 #include <dolphin/types.h>
 
 J2DMaterialFactory::J2DMaterialFactory(J2DMaterialBlock const& param_0) {

src/JSystem/J3DGraphAnimator/J3DSkinDeform.cpp

@@ -4,7 +4,7 @@
 #include "JSystem/J3DGraphAnimator/J3DAnimation.h"
 #include "JSystem/J3DGraphAnimator/J3DModel.h"
 #include "JSystem/JKernel/JKRHeap.h"
-#include <string>
+#include <cstring>
 
 J3DSkinNList::J3DSkinNList() {
     field_0x0 = NULL;

src/JSystem/J3DGraphBase/J3DMatBlock.cpp

@@ -5,7 +5,7 @@
 #include "JSystem/J3DGraphBase/J3DSys.h"
 #include "JSystem/J3DGraphBase/J3DTransform.h"
 #include "global.h"
-#include <string>
+#include <cstring>
 
 inline void loadMatColors(const J3DGXColor* color) {
     J3DGDWriteXFCmdHdr(0x100C, 2);

src/JSystem/J3DGraphBase/J3DPacket.cpp

@@ -7,7 +7,7 @@
 #include "JSystem/J3DGraphBase/J3DShapeMtx.h"
 #include "JSystem/JKernel/JKRHeap.h"
 #include <dolphin/os.h>
-#include <string>
+#include <cstring>
 #include "global.h"
 
 J3DError J3DDisplayListObj::newDisplayList(u32 maxSize) {

src/JSystem/J3DGraphBase/J3DShapeDraw.cpp

@@ -2,7 +2,7 @@
 
 #include "JSystem/J3DGraphBase/J3DShapeDraw.h"
 #include "JSystem/JKernel/JKRHeap.h"
-#include <string>
+#include <cstring>
 #include <stdint.h>
 #include <dolphin/gx.h>
 

src/JSystem/J3DGraphBase/J3DVertex.cpp

@@ -4,7 +4,7 @@
 #include "JSystem/J3DGraphAnimator/J3DJointTree.h"
 #include "JSystem/J3DGraphBase/J3DSys.h"
 #include "JSystem/JKernel/JKRHeap.h"
-#include <string>
+#include <cstring>
 
 J3DVertexData::J3DVertexData() {
     mVtxNum = 0;

src/JSystem/J3DGraphLoader/J3DClusterLoader.cpp

@@ -9,7 +9,7 @@
 #include "JSystem/JSupport/JSupport.h"
 #include "JSystem/JKernel/JKRHeap.h"
 #include <dolphin/os.h>
-#include <string>
+#include <cstring>
 
 void* J3DClusterLoaderDataBase::load(const void* i_data) {
     J3D_ASSERT_NULLPTR(41, i_data);

src/JSystem/JAudio2/JASWaveArcLoader.cpp

@@ -5,7 +5,7 @@
 #include "JSystem/JAudio2/JASTaskThread.h"
 #include "JSystem/JAudio2/JASMutex.h"
 #include "JSystem/JKernel/JKRDvdAramRipper.h"
-#include <string>
+#include <cstring>
 #include <dolphin/os.h>
 #include <stdint.h>
 

src/JSystem/JHostIO/JHIMccBuf.cpp

@@ -4,7 +4,7 @@
 #include "JSystem/JKernel/JKRHeap.h"
 #include "JSystem/JHostIO/JHIRMcc.h"
 #include <revolution/hio2.h>
-#include <string>
+#include <cstring>
 
 void JHIReport(const char* fmt, ...) {}
 

src/JSystem/JHostIO/JORServer.cpp

@@ -5,7 +5,7 @@
 #include "JSystem/JHostIO/JORFile.h"
 #include "JSystem/JHostIO/JORHostInfo.h"
 #include "JSystem/JSupport/JSUMemoryStream.h"
-#include <string>
+#include <cstring>
 
 void JOREventCallbackListNode::JORAppend() {
     JORServer* pServer = JORServer::getInstance();

src/JSystem/JKernel/JKRAram.cpp

@@ -8,7 +8,7 @@
 #include "JSystem/JUtility/JUTException.h"
 #include <dolphin/ar.h>
 #include <dolphin/os.h>
-#include <string>
+#include <cstring>
 
 #if PLATFORM_GCN
 const u32 stack_size = 0xc00;

src/JSystem/JKernel/JKRAramArchive.cpp

@@ -8,7 +8,7 @@
 #include "JSystem/JUtility/JUTAssert.h"
 #include "JSystem/JUtility/JUTException.h"
 #include <cmath>
-#include <string>
+#include <cstring>
 
 JKRAramArchive::JKRAramArchive() {}
 

src/JSystem/JKernel/JKRArchivePri.cpp

@@ -3,7 +3,7 @@
 #include "JSystem/JKernel/JKRArchive.h"
 #include "JSystem/JKernel/JKRHeap.h"
 #include <cctype>
-#include <string>
+#include <cstring>
 
 u32 JKRArchive::sCurrentDirID;
 

src/JSystem/JKernel/JKRCompArchive.cpp

@@ -11,7 +11,7 @@
 #include "JSystem/JUtility/JUTAssert.h"
 #include "JSystem/JUtility/JUTException.h"
 #include <cmath>
-#include <string>
+#include <cstring>
 #include <stdint.h>
 
 JKRCompArchive::JKRCompArchive(s32 entryNum, JKRArchive::EMountDirection eMountDirection)

src/JSystem/JKernel/JKRDvdAramRipper.cpp

@@ -11,7 +11,7 @@
 #include <dolphin/os.h>
 #include <dolphin/vi.h>
 #include "global.h"
-#include <string>
+#include <cstring>
 
 static int JKRDecompressFromDVDToAram(JKRDvdFile*, u32, u32, u32, u32, u32, u32*);
 static int decompSZS_subroutine(u8*, u32);

src/JSystem/JKernel/JKRDvdArchive.cpp

@@ -7,7 +7,7 @@
 #include "JSystem/JUtility/JUTAssert.h"
 #include "JSystem/JUtility/JUTException.h"
 #include <cmath>
-#include <string>
+#include <cstring>
 #include "global.h"
 #include <stdint.h>
 

src/JSystem/JKernel/JKRDvdRipper.cpp

@@ -8,7 +8,7 @@
 #include "JSystem/JKernel/JKRDvdFile.h"
 #include "JSystem/JKernel/JKRDecomp.h"
 #include "JSystem/JUtility/JUTException.h"
-#include <string>
+#include <cstring>
 #include <dolphin/os.h>
 #include <dolphin/vi.h>
 #include <stdint.h>

src/JSystem/JKernel/JKRFileCache.cpp

@@ -7,7 +7,7 @@
 #include "JSystem/JUtility/JUTAssert.h"
 
 #include <cctype>
-#include <string>
+#include <cstring>
 #include "global.h"
 
 JKRFileCache* JKRFileCache::mount(const char* path, JKRHeap* heap, const char* param_3) {

src/JSystem/JKernel/JKRFileLoader.cpp

@@ -4,7 +4,7 @@
 
 #define MSL_USE_INLINES 1  // needed to inline tolower call. not inlined elsewhere in the repo
 
-#include <string>
+#include <cstring>
 #include <cctype>
 #include "global.h"
 

src/JSystem/JKernel/JKRHeap.cpp

@@ -9,7 +9,7 @@
 #include "JSystem/JUtility/JUTAssert.h"
 #include "JSystem/JUtility/JUTException.h"
 #include <stdint.h>
-#include <string>
+#include <cstring>
 
 #if DEBUG
 u8 JKRValue_DEBUGFILL_NOTUSE = 0xFD;

src/JSystem/JKernel/JKRMemArchive.cpp

@@ -5,7 +5,7 @@
 #include "JSystem/JKernel/JKRDvdRipper.h"
 #include "JSystem/JUtility/JUTAssert.h"
 #include "JSystem/JUtility/JUTException.h"
-#include <string>
+#include <cstring>
 #include "global.h"
 #include <stdint.h>
 

src/JSystem/JMessage/resource.cpp

@@ -4,7 +4,7 @@
 #include "JSystem/JGadget/search.h"
 #include "JSystem/JGadget/define.h"
 #include <algorithm>
-#include <string>
+#include <cstring>
 
 u16 JMessage::TResource::toMessageIndex_messageID(u32 uMsgID, u32 upperHalf, bool* pbValid) const {
     if (!oParse_TBlock_messageID_.getRaw()) {

src/JSystem/JParticle/JPAResourceManager.cpp

@@ -3,7 +3,7 @@
 #include "JSystem/JParticle/JPAResourceManager.h"
 #include "JSystem/JParticle/JPADynamicsBlock.h"
 #include "JSystem/JParticle/JPAResource.h"
-#include <string>
+#include <cstring>
 
 struct JPAResourceLoader {
     JPAResourceLoader(u8 const*, JPAResourceManager*);

src/JSystem/JStudio/JStudio/ctb.cpp

@@ -2,7 +2,7 @@
 
 #include "JSystem/JStudio/JStudio/ctb.h"
 #include <iterator>
-#include <string>
+#include <cstring>
 #include <algorithm>
 
 JStudio::ctb::TObject::~TObject() {}

src/JSystem/JStudio/JStudio/fvb.cpp

@@ -2,7 +2,7 @@
 
 #include "JSystem/JStudio/JStudio/fvb.h"
 #include "JSystem/JUtility/JUTException.h"
-#include <string>
+#include <cstring>
 
 namespace JStudio {
 namespace fvb {

src/JSystem/JStudio/JStudio/jstudio-control.cpp

@@ -7,7 +7,7 @@
 #include "JSystem/JStudio/JStudio/jstudio-control.h"
 #include "JSystem/JStudio/JStudio/jstudio-math.h"
 #include "JSystem/JStudio/JStudio/jstudio-data.h"
-#include <string>
+#include <cstring>
 
 JStudio::TControl::TControl() {
     mTransformOnSet = false;

src/JSystem/JStudio/JStudio/stb.cpp

@@ -4,7 +4,7 @@
 #include "JSystem/JStudio/JStudio/jstudio-object.h"
 #include "JSystem/JUtility/JUTException.h"
 #include <algorithm>
-#include <string>
+#include <cstring>
 
 namespace JStudio {
 namespace stb {

src/JSystem/JSupport/JSUMemoryStream.cpp

@@ -1,7 +1,7 @@
 #include "JSystem/JSystem.h" // IWYU pragma: keep
 
 #include "JSystem/JSupport/JSUMemoryStream.h"
-#include <string>
+#include <cstring>
 
 void JSUMemoryInputStream::setBuffer(void const* pBuffer, s32 length) {
     mBuffer = pBuffer;

src/JSystem/JSupport/JSUOutputStream.cpp

@@ -3,7 +3,7 @@
 #include "JSystem/JSupport/JSUOutputStream.h"
 #include "JSystem/JSupport/JSURandomOutputStream.h"
 #include <dolphin/dolphin.h>
-#include <string>
+#include <cstring>
 
 JSUOutputStream::~JSUOutputStream() {
     if (!isGood()) {

src/JSystem/JUtility/JUTNameTab.cpp

@@ -1,7 +1,7 @@
 #include "JSystem/JSystem.h" // IWYU pragma: keep
 
 #include "JSystem/JUtility/JUTNameTab.h"
-#include <string>
+#include <cstring>
 
 JUTNameTab::JUTNameTab() {
     setResource(NULL);

src/JSystem/JUtility/JUTResource.cpp

@@ -3,7 +3,7 @@
 #include "JSystem/JUtility/JUTResource.h"
 #include "JSystem/JKernel/JKRArchive.h"
 #include "JSystem/JSupport/JSUInputStream.h"
-#include <string>
+#include <cstring>
 
 void* JUTResReference::getResource(JSUInputStream* stream, u32 resType, JKRArchive* archive) {
     stream->read(mType);

src/PowerPC_EABI_Support/MSL/MSL_C/MSL_Common/Include/cstring

@@ -26,6 +26,22 @@ size_t strlen(const char* str);
 
 #ifdef __cplusplus
 };
+
+namespace std {
+using ::memcpy;
+using ::memset;
+using ::memcmp;
+using ::memchr;
+using ::memmove;
+using ::strrchr;
+using ::strchr;
+using ::strlen;
+using ::strncmp;
+using ::strcmp;
+using ::strcat;
+using ::strncpy;
+using ::strcpy;
+} // namespace std
 #endif
 
 #endif /* _MSL_COMMON_STRING_H */

src/SSystem/SComponent/c_lib.cpp

@@ -4,7 +4,7 @@
  */
 
 #include "SSystem/SComponent/c_lib.h"
-#include <string>
+#include <cstring>
 #include "SSystem/SComponent/c_math.h"
 
 /**

src/d/actor/d_a_alink.cpp

@@ -1467,7 +1467,7 @@ static f32 l_ladderAnmBaseTransY = 102.00054168701172f;
 
 static dCcD_SrcCyl l_cylSrc = {
     {
-        {0, {{AT_TYPE_WOLF_ATTACK, 3, 0x1A}, {(s32)0xD8FFFDFF, 5}, 0x73}},
+        {0, {{AT_TYPE_WOLF_ATTACK, 3, 0x1A}, {0xD8FFFDFF, 5}, 0x73}},
         {dCcD_SE_WOLF_BITE, 3, 1, 0, {1}},
         {dCcD_SE_NONE, 6, 0, 0, {0}},
         {0},
@@ -1483,7 +1483,7 @@ static dCcD_SrcCyl l_cylSrc = {
 
 static dCcD_SrcSph l_sphSrc = {
     {
-        {0, {{AT_TYPE_NORMAL_SWORD, 3, 0x1A}, {(s32)0xD8FBFDFF, 5}, 0x73}},
+        {0, {{AT_TYPE_NORMAL_SWORD, 3, 0x1A}, {0xD8FBFDFF, 5}, 0x73}},
         {dCcD_SE_SWORD, 3, 1, 0, {1}},
         {dCcD_SE_NONE, 6, 0, 0, {0}},
         {0},
@@ -4640,7 +4640,7 @@ void daAlink_c::playerInit() {
     }
 }
 
-void dummy(fopAc_ac_c* i_this) {
+static void dummy(fopAc_ac_c* i_this) {
     fopAcM_RegisterCreateID(i_this, "ALINK");
 }
 

src/d/actor/d_a_e_bg.cpp

@@ -44,7 +44,7 @@ void daE_BG_HIO_c::genMessage(JORMContext* ctx) {
 namespace {
 dCcD_SrcSph cc_bg_src = {
     {
-        {0x0, {{0x0, 0x0, 0x0}, {(s32)0xD8FBFDFF, 0x03}, 0x75}}, // mObj
+        {0x0, {{0x0, 0x0, 0x0}, {0xD8FBFDFF, 0x03}, 0x75}}, // mObj
         {dCcD_SE_METAL, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
         {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2}, // mGObjTg
         {0x0}, // mGObjCo

src/d/actor/d_a_e_dk.cpp

@@ -46,7 +46,7 @@ enum E_DK_RES_FILE_ID {
 namespace {
 static dCcD_SrcSph cc_dk_src = {
     { // mObjInf
-        { 0x0, { { 0, 0, { 0 } }, { (s32)0xd8fbbddf, { 3 } }, { { 0x75 } } } }, // mObj
+        { 0x0, { { 0, 0, { 0 } }, { 0xd8fbbddf, { 3 } }, { { 0x75 } } } }, // mObj
         { 0x09, 0, 0, 0, { 0 } }, // mGObjAt
         { 0x00, 0x00, 0x00, 0x00, { 5 } }, // mGObjTg
         { { 0 } }, // mGObjCo

src/d/actor/d_a_e_hm.cpp

@@ -94,7 +94,7 @@ static int useHeapInit(fopAc_ac_c* i_this) {
 void daE_HM_c::initCcCylinder() {
     static const dCcD_SrcSph ccShpSrc = {
         {
-            {0x0, {{0x2, 0x1, 0xd}, {(s32)0xD8FBFDFF, 0x43}, 0x75}},  // mObj
+            {0x0, {{0x2, 0x1, 0xd}, {0xD8FBFDFF, 0x43}, 0x75}},  // mObj
             {dCcD_SE_STONE, 0x0, 0x0, 0x0, 0x0},                  // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0},                   // mGObjTg
             {0x0},                                                // mGObjCo

src/d/actor/d_a_e_hp.cpp

@@ -31,7 +31,7 @@ public:
 namespace {
 static dCcD_SrcCyl cc_hp_src = {
     {
-        {0, {{0x0, 0x0, 0x0}, {(s32)0xd8000000, 0x3}, 0x0}},
+        {0, {{0x0, 0x0, 0x0}, {0xd8000000, 0x3}, 0x0}},
         {dCcD_SE_13, 0, 0, 0, {0}},
         {dCcD_SE_NONE, 0, 0, 0, {6}},
         {0},
@@ -47,7 +47,7 @@ static dCcD_SrcCyl cc_hp_src = {
 
 static dCcD_SrcSph cc_lamp_src = {
     {
-        {0x0, {{0x0, 0x0, 0x0}, {(s32)0xD8FBFDFF, 0x43}, 0x75}},  // mObj
+        {0x0, {{0x0, 0x0, 0x0}, {0xD8FBFDFF, 0x43}, 0x75}},  // mObj
         {dCcD_SE_13, 0x0, 0x0, 0x0, 0x0},                         // mGObjAt
         {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x6},                       // mGObjTg
         {0x0},                                                    // mGObjCo

src/d/actor/d_a_e_hz.cpp

@@ -2016,7 +2016,7 @@ int daE_HZ_c::create() {
 
     static dCcD_SrcSph cc_sph_src2 = {
         {
-            {0x0, {{AT_TYPE_CSTATUE_SWING, 0x1, 0x0}, {(s32)0xd8fafdff, 0x3}, 0x75}},   // mObj
+            {0x0, {{AT_TYPE_CSTATUE_SWING, 0x1, 0x0}, {0xd8fafdff, 0x3}, 0x75}},   // mObj
             {dCcD_SE_METAL, 0x0, 0x0, 0x0, 0x0},                                        // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2},                                         // mGObjTg
             {0x0},                                                                      // mGObjCo

src/d/actor/d_a_e_kr.cpp

@@ -2258,7 +2258,7 @@ static int daE_Kr_Create(fopAc_ac_c* i_this) {
     };
     static dCcD_SrcSph head_tg_sph_src = {
         {
-            {0x0, {{0x0, 0x1, 0x0}, {(s32)0xd8fbfdff, 0x3}, 0x0}},  // mObj
+            {0x0, {{0x0, 0x1, 0x0}, {0xd8fbfdff, 0x3}, 0x0}},  // mObj
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0},                     // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2},                     // mGObjTg
             {0x0},                                                  // mGObjCo
@@ -2270,7 +2270,7 @@ static int daE_Kr_Create(fopAc_ac_c* i_this) {
 
     static dCcD_SrcSph body_tg_sph_src = {
         {
-            {0x0, {{0x0, 0x1, 0x0}, {(s32)0xd8fbfdff, 0x3}, 0x0}},  // mObj
+            {0x0, {{0x0, 0x1, 0x0}, {0xd8fbfdff, 0x3}, 0x0}},  // mObj
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0},                // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2},                // mGObjTg
             {0x0},                                             // mGObjCo

src/d/actor/d_a_e_sh.cpp

@@ -1160,7 +1160,7 @@ static int useHeapInit(fopAc_ac_c* i_this) {
 static int daE_SH_Create(fopAc_ac_c* i_this) {
     static dCcD_SrcSph cc_sph_src = {
         {
-            {0x0, {{0x0, 0x0, 0x0}, {(s32)0xd8fbfdff, 0x3}, 0x75}}, // mObj
+            {0x0, {{0x0, 0x0, 0x0}, {0xd8fbfdff, 0x3}, 0x75}}, // mObj
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2}, // mGObjTg
             {0x0}, // mGObjCo

src/d/actor/d_a_e_yd.cpp

@@ -1361,7 +1361,7 @@ static int useHeapInit(fopAc_ac_c* i_this) {
 static int daE_YD_Create(fopAc_ac_c* i_this) {
     static dCcD_SrcSph cc_sph_src = {
         {
-            {0x0, {{0x0, 0x0, 0xd}, {(s32)0xd8fbfdff, 0x3}, 0x25}}, // mObj
+            {0x0, {{0x0, 0x0, 0xd}, {0xd8fbfdff, 0x3}, 0x25}}, // mObj
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
             {dCcD_SE_STONE, 0x0, 0x0, 0x0, 0x2}, // mGObjTg
             {0x0}, // mGObjCo
@@ -1383,7 +1383,7 @@ static int daE_YD_Create(fopAc_ac_c* i_this) {
     };
     static dCcD_SrcSph kuki_sph_src = {
         {
-            {0x0, {{0x0, 0x0, 0xd}, {(s32)0xd8fbfdff, 0x3}, 0x0}}, // mObj
+            {0x0, {{0x0, 0x0, 0xd}, {0xd8fbfdff, 0x3}, 0x0}}, // mObj
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2}, // mGObjTg
             {0x0}, // mGObjCo

src/d/actor/d_a_e_yr.cpp

@@ -2416,7 +2416,7 @@ static int daE_Yr_Create(fopAc_ac_c* i_this) {
 
     static dCcD_SrcSph head_tg_sph_src = {
         {
-            {0x0, {{0x0, 0x1, 0x0}, {(s32)0xd8fbfdff, 0x3}, 0x0}}, // mObj
+            {0x0, {{0x0, 0x1, 0x0}, {0xd8fbfdff, 0x3}, 0x0}}, // mObj
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2}, // mGObjTg
             {0x0}, // mGObjCo
@@ -2428,7 +2428,7 @@ static int daE_Yr_Create(fopAc_ac_c* i_this) {
 
     static dCcD_SrcSph body_tg_sph_src = {
         {
-            {0x0, {{0x0, 0x1, 0x0}, {(s32)0xd8fbfdff, 0x3}, 0x0}}, // mObj
+            {0x0, {{0x0, 0x1, 0x0}, {0xd8fbfdff, 0x3}, 0x0}}, // mObj
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
             {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x2}, // mGObjTg
             {0x0}, // mGObjCo

src/d/actor/d_a_grass.cpp

@@ -10,7 +10,7 @@
 #include "SSystem/SComponent/c_math.h"
 #include "d/d_com_inf_game.h"
 #include "Z2AudioLib/Z2Instances.h"
-#include <string>
+#include <cstring>
 
 #include "d/actor/d_grass.inc" // IWYU pragma: keep
 #include "d/actor/d_flower.inc"

src/d/actor/d_a_obj_hakai_brl.cpp

@@ -84,7 +84,7 @@ int daObjHBarrel_c::execute() {
 
 dCcD_SrcCyl const daObjHBarrel_c::s_CcDCyl = {
     {
-        {0x0, {{0x0, 0x0, 0xd}, {(s32)0xd8fafdff, 0x11}, 0x79}},  // mObj
+        {0x0, {{0x0, 0x0, 0xd}, {0xd8fafdff, 0x11}, 0x79}},  // mObj
         {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0},                  // mGObjAt
         {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x5},                  // mGObjTg
         {0x0},                                               // mGObjCo

src/d/actor/d_a_obj_kbacket.cpp

@@ -22,7 +22,7 @@ const daObj_KBacket_HIOParam daObj_KBacket_Param_c::m = {
 };
 
 static const dCcD_SrcGObjInf l_ccDObjData = {
-    {0x0, {{0x0, 0x0, 0x0}, {(s32)0xd8fbfdff, 0x0}, 0x79}}, // mObj
+    {0x0, {{0x0, 0x0, 0x0}, {0xd8fbfdff, 0x0}, 0x79}}, // mObj
     {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
     {dCcD_SE_STONE, 0x0, 0x0, 0x0, 0x0}, // mGObjTg
     {0x0}, // mGObjCo

src/d/actor/d_a_obj_klift00.cpp

@@ -78,7 +78,7 @@ static const char* l_arcName = "K_lift00";
 
 static dCcD_SrcSph l_cc_sph_src = {
     {
-        {0x0, {{0x0, 0x0, 0x0}, {(s32)0xd8fbfdff, 0x11}, 0x79}}, // mObj
+        {0x0, {{0x0, 0x0, 0x0}, {0xd8fbfdff, 0x11}, 0x79}}, // mObj
         {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
         {dCcD_SE_NONE, 0x5, 0x0, 0x0, 0x2}, // mGObjTg
         {0x0}, // mGObjCo

src/d/actor/d_a_obj_wood_statue.cpp

@@ -14,7 +14,7 @@
 
 const static dCcD_SrcCyl l_cyl_src = {
     {
-        {0x0, {{0x0, 0x0, 0x0}, {-1, 0x11}, 0x59}}, // mObj
+        {0x0, {{0x0, 0x0, 0x0}, {0xFFFFFFFF, 0x11}, 0x59}}, // mObj
         {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x0}, // mGObjAt
         {dCcD_SE_NONE, 0x0, 0x0, 0x0, 0x4}, // mGObjTg
         {0x0}, // mGObjCo

src/d/actor/d_a_tag_kmsg.cpp

@@ -4,7 +4,7 @@
 #include "d/actor/d_a_npc.h"
 #include "d/actor/d_a_player.h"
 #include "SSystem/SComponent/c_counter.h"
-#include <string>
+#include <cstring>
 
 struct EventListItem {
     char* mEventName;

src/d/d_envse.cpp

@@ -9,7 +9,7 @@
 #include "d/d_com_inf_game.h"
 #include "d/d_path.h"
 #include "f_op/f_op_camera_mng.h"
-#include <string>
+#include <cstring>
 
 static int dEnvSe_Draw(dEnvSe_c* i_this) {
     return 1;

src/d/d_error_msg.cpp

@@ -5,7 +5,7 @@
 
 #include "d/dolzel.h" // IWYU pragma: keep
 
-#include <string>
+#include <cstring>
 #include "JSystem/J2DGraph/J2DOrthoGraph.h"
 #include "JSystem/J2DGraph/J2DPicture.h"
 #include "JSystem/J2DGraph/J2DTextBox.h"

src/d/d_event_manager.cpp

@@ -13,7 +13,7 @@
 #include "d/d_demo.h"
 #include "d/d_s_play.h"
 #include "SSystem/SComponent/c_counter.h"
-#include <string>
+#include <cstring>
 
 #if DEBUG
 static dEvM_HIO_c l_HIO;

src/d/d_kankyo_wether.cpp

@@ -12,7 +12,7 @@
 #include "d/d_kankyo.h"
 #include "d/d_kankyo_rain.h"
 #include "f_op/f_op_camera_mng.h"
-#include <string>
+#include <cstring>
 #include "m_Do/m_Do_audio.h"
 
 static void dKyw_pntlight_set(WIND_INFLUENCE* pntwind);

src/d/d_menu_option.cpp

@@ -22,7 +22,7 @@
 #include "f_op/f_op_msg_mng.h"
 #include "m_Do/m_Do_controller_pad.h"
 #include "m_Do/m_Do_graphic.h"
-#include <string>
+#include <cstring>
 
 typedef void (dMenu_Option_c::*initFunc)();
 static initFunc init[] = {

src/d/d_menu_ring.cpp

@@ -25,7 +25,7 @@
 #include "d/d_msg_string.h"
 #include "m_Do/m_Do_controller_pad.h"
 #include "m_Do/m_Do_graphic.h"
-#include <string>
+#include <cstring>
 
 #include <cstdio>
 

src/d/d_meter2_draw.cpp

@@ -20,7 +20,7 @@
 #include "d/d_msg_class.h"
 #include "d/d_msg_object.h"
 #include "d/d_pane_class.h"
-#include <string>
+#include <cstring>
 
 dMeter2Draw_c::dMeter2Draw_c(JKRExpHeap* mp_heap) {
     OS_REPORT("enter dMeter2Draw_c::dMeter2Draw_c(JKRExpHeap *mp_heap)\n");

src/d/d_msg_scrn_3select.cpp

@@ -10,7 +10,7 @@
 #include "JSystem/J2DGraph/J2DGrafContext.h"
 #include "JSystem/J2DGraph/J2DScreen.h"
 #include "JSystem/J2DGraph/J2DTextBox.h"
-#include <string>
+#include <cstring>
 #include "d/d_com_inf_game.h"
 #include "d/d_select_cursor.h"
 #include "d/d_msg_object.h"

src/d/d_msg_scrn_base.cpp

@@ -6,7 +6,7 @@
 #include "d/d_msg_object.h"
 #include "d/d_msg_out_font.h"
 #include "d/d_pane_class.h"
-#include <string>
+#include <cstring>
 
 dMsgScrnBase_c::dMsgScrnBase_c() {
     init();

src/f_op/f_op_actor_mng.cpp

@@ -776,7 +776,7 @@ bool fopAcM_addAngleY(fopAc_ac_c* i_actor, s16 i_target, s16 i_step) {
     return cLib_chaseAngleS(&angle->y, i_target, i_step);
 }
 
-void dummy(fopAc_ac_c* i_actor) {
+static void dummy(fopAc_ac_c* i_actor) {
     fopAcM_SetSpeedF(i_actor, 10.0f);
 }
 

src/m_Do/m_Do_main.cpp

@@ -33,7 +33,7 @@
 #include "m_Do/m_Do_printf.h"
 #include "m_Do/m_Do_ext2.h"
 #include "SSystem/SComponent/c_counter.h"
-#include <string>
+#include <cstring>
 
 #if PLATFORM_WII || PLATFORM_SHIELD
 #include <revolution/sc.h>