J3DVisibility OK (#527)

* J3DVisibility OK

* Addressing review comments
This commit is contained in:
Kristopher Early
2023-10-16 19:15:54 +01:00
committed by GitHub
parent 0e82b07cf2
commit 8a37ec07d1
3 changed files with 23 additions and 16 deletions
+1 -1
View File
@@ -875,7 +875,7 @@ config.libs = [
Object(NonMatching, "JSystem/J3DGraphAnimator/J3DModel.cpp"),
Object(NonMatching, "JSystem/J3DGraphAnimator/J3DAnimation.cpp"),
Object(NonMatching, "JSystem/J3DGraphAnimator/J3DMaterialAnm.cpp"),
Object(NonMatching, "JSystem/J3DGraphAnimator/J3DVisibility.cpp"),
Object(Matching, "JSystem/J3DGraphAnimator/J3DVisibility.cpp"),
Object(NonMatching, "JSystem/J3DGraphAnimator/J3DCluster.cpp"),
Object(NonMatching, "JSystem/J3DGraphAnimator/J3DJoint.cpp"),
Object(Matching, "JSystem/J3DGraphAnimator/J3DNode.cpp"),
+2 -2
View File
@@ -38,13 +38,13 @@ class J3DVisibilityManager {
public:
J3DVisibilityManager(J3DAnmVisibilityFull* visibility) {
mAnmVisibility = visibility;
field_0x8 = 1;
mbActive = 1;
}
virtual ~J3DVisibilityManager();
virtual void setVisibility(J3DModelData*);
/* 0x04 */ J3DAnmVisibilityFull* mAnmVisibility;
/* 0x08 */ int field_0x8;
/* 0x08 */ int mbActive;
};
class J3DUnkCallBack {
+20 -13
View File
@@ -1,17 +1,24 @@
//
// Generated by dtk
// Translation Unit: J3DVisibility.cpp
//
/*
* J3DVisibility.cpp
*/
#include "JSystem/J3DGraphAnimator/J3DModel.h"
#include "JSystem/J3DGraphAnimator/J3DModelData.h"
#include "JSystem/J3DGraphAnimator/J3DAnimation.h"
#include "JSystem/J3DGraphAnimator/J3DVisibility.h"
#include "dolphin/types.h"
void J3DVisibilityManager::setVisibility(J3DModelData* pModel) {
u8 visibility;
/* 802F36BC-802F377C .text setVisibility__20J3DVisibilityManagerFP12J3DModelData */
void J3DVisibilityManager::setVisibility(J3DModelData*) {
/* Nonmatching */
if ((mbActive & 1) != 0 && mAnmVisibility != NULL) {
for (u16 index = 0; index < pModel->getShapeNum(); index++) {
visibility = 0;
mAnmVisibility->getVisibility(index, &visibility);
if (visibility != 0) {
pModel->getShapeNodePointer(index)->offFlag(1);
} else {
pModel->getShapeNodePointer(index)->onFlag(1);
}
}
}
}
/* 802F377C-802F37C4 .text __dt__20J3DVisibilityManagerFv */
J3DVisibilityManager::~J3DVisibilityManager() {
/* Nonmatching */
}
J3DVisibilityManager::~J3DVisibilityManager() {}