* 99% match
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 7% text
* 28% text
* 41% text
* 65% text
* Rewrote _execute to increase accuracy. Only issue in .text is a label not loading correctly. I have no idea how to fix this.
* Equivalent. Weak func ordering.
* 82% text
* Equivalent. A lot of work is needed to name variables and clean up functions. Weak function ordering is wrong.
* Cleaned some functions, named several variables, and began documenting dialog tree.
* Naming a couple more variables
* 21% text
* change out getMySubstanceP for getMyIntegerP inline
* 100% text
* Refactor to use JUT_ASSERT macro
* #181: d_a_tag_attention matching; TODO: implement chk_inside and dComIfGp_att_Look2RequestF
* #181: continue working on d_a_tag_attention, matching almost complete
* #181: revert naming class member (not certain enough)
* #181: preliminary changes to resolve#784 comments regarding usage of debug maps
* #181: commit suggestion by @WilliamArnett, fixing regalloc error
Co-authored-by: WilliamArnett <149556961+WilliamArnett@users.noreply.github.com>
* #181: fix missing curly bracket
* #181: resolve#784 comments with the kind help of @WilliamArnett;
move `daTagAttention::Act_c::chk_inside` to header file; split `plyrToObjVec` definition to match assembly;
remove temp variable, use values directly and swap operands;
implement `Look2RequestF` in `include/d/d_attention.h`;
remove non-matching use of temp variable `iVar1` and replace `current.pos` with uninitialized variable in `daTagAttention::Act_c::_execute`
* Update fork to match upstream
* some changes
* 12% text
* 21% text
* 26% text
* 43% text
* 51% text
* Revert unnecessary file changes
* Update d_a_tag_attention.cpp
* 55% text
* 52% text
* 52% text
* 56% text
* 68%
* 77% text
* 100% matching minus regswap
* 100% matching for retail
* Many more demo matches
* Fix broken match in _create()
* Demo Match
* Add some missing inlines
* Fix dComIfGp_setMesgCameraInfoActor
* More inline matching
* fix broken demo match
* Name some fields
* Utilize EventBit enum
* Name more fields, and add inline calls to d_a_npc_ls1
* Remove comments
* Implement @LagoLunatic suggested changes
* remove actor cast from dSnap_RegistFig calls
* Fix broken match in eInit_ATTENTION_
* Second round of @LagoLunatic 's suggested changes
---------
Co-authored-by: Skelp <skelp@pm.me>
Co-authored-by: Skelp <59535863+Skelp@users.noreply.github.com>
* initial progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* fix outdated member names
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* fixed deprecated member references
* more progress
* more progress
* more progress
* fix deprecated member references
* more progress
* more progress
* more progress
* more progress
* more progress
* check in for review
* remove comment
* initial PR changes
* more PR changes
* more PR changes
* added anonymous struct as class member
* reverted changes to `stage_camera2_data_class`
* added `dCamera_event_data`, `dCamera_monitoring_things` and `dCamera_DMC_system` from debug maps
* more progress
* more progress
* realmatch for `camera_draw`
* PR changes
* fix broken merge
* formatting
* Reverted change to `camSphChkdata` that caused `sph_chk_callback` match to regress
* Reverted change to `BG` struct that caused ctor and dtor match to regress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* more progress
* PR changes
* corrected size comment
* fixed broken member references
* more d_camera work
* remove comment
* update symbols
* d_cam_param 100% for GZLE01
Code is 100% matching
* Update math.h
* initial progress
* more progress
* more progress
* d_picture_box mostly matching for GZLE01
Unable to resolve the regswap in dJle_Pb_c::draw()
* reverted some changes to member names
* filled missing enum value
* PR changes made
* renamed some fields
Functions are now marked as "FAKE?" instead of "FAKE" in cases where it's possible that they only seem fake due to the linker map not showing duplicate symbols multiple times (inlines used in multiple TUs).
"UNREFERENCED DUPLICATE" data in the base maps are now also taken into account. Also, limited linkage diffing can be done for main.dol symbols (based on the naming convention of l_ and g_ prefixes).
Auto-detect if the TU is in main.dol or a REL. Detect this separately for the target and the base, in order to support TUs like d_a_npc_tt which are in main.dol for the debug build, but a REL for release builds. And disable linkage comparison when comparing a REL TU to a main.dol TU as the official main.dol maps do not include linkage information, but the REL maps do.
* d_a_npc_mt 100% for GZLE01
* implemented dPb_erasePicture and added some relevant inlines
* fixed existing references to mSelectPicture
* PR changes made
* d_a_kb Almost Matching
- Get most of the logic in
Still need to switch over from inheritance to composition, will fix at least 2/3 of the functions
* Switch Inheritance -> Composition
Causes regressions in way_check and target_set
* Use More Enums
Now uses res/loop mode/item number/sound/particle/collision attribute/event flag enums properly
* Fix d_a_npc_people
Used kb_class in a couple spots
* Another Inline
Found it in the debug map
* Joint Enums
- Add joint enums with note about normal/big pigs needing to have (at least partially) identical joint setups
* Assert for Joint Numbers
- Make sure the joint numbers match for the normal pig + big pig models
- Update/extend note accordingly
LagoLunatic