Coderabbit fixes

This commit is contained in:
patchzyy
2026-08-29 11:56:35 +02:00
parent b5e5858e1d
commit 6dc4e59052
2 changed files with 23 additions and 7 deletions
+6 -2
View File
@@ -165,8 +165,12 @@ static bool cache_init_core() {
db = nullptr;
std::error_code ec;
std::filesystem::remove(path, ec);
std::filesystem::remove(std::filesystem::path{file + "-wal"}, ec);
std::filesystem::remove(std::filesystem::path{file + "-shm"}, ec);
auto wal = path;
wal += "-wal";
std::filesystem::remove(wal, ec);
auto shm = path;
shm += "-shm";
std::filesystem::remove(shm, ec);
ret = sqlite3_open(file.c_str(), &db);
if (ret != SQLITE_OK) {
Log.error("Failed to recreate database: {}", sqlite3_errmsg(db));
+17 -5
View File
@@ -578,11 +578,23 @@ std::string FormatHostStackTrace(unsigned framesToSkip) {
&module) != 0 &&
module != nullptr) {
moduleBase = reinterpret_cast<DWORD64>(module);
wchar_t modulePathBuffer[MAX_PATH] = L"";
const DWORD length = GetModuleFileNameW(module, modulePathBuffer, MAX_PATH);
if (length != 0) {
modulePath = RuntimeConfigFile::PathToUtf8(
std::filesystem::path(std::wstring(modulePathBuffer, length)));
std::wstring modulePathBuffer(MAX_PATH, L'\0');
for (;;) {
const DWORD length =
GetModuleFileNameW(module, modulePathBuffer.data(), static_cast<DWORD>(modulePathBuffer.size()));
if (length == 0) {
break;
}
if (length < modulePathBuffer.size()) {
modulePathBuffer.resize(length);
modulePath = RuntimeConfigFile::PathToUtf8(std::filesystem::path(modulePathBuffer));
break;
}
// Truncated; retry with a larger buffer up to the extended path limit.
if (modulePathBuffer.size() >= 32768) {
break;
}
modulePathBuffer.resize(modulePathBuffer.size() * 2);
}
}