8c737be65e
Make the connection macro more convenient and foolproof ( #1261 )
2026-06-28 18:21:02 -04:00
a55bc33d67
Use features of RGBDS 1.0.0 ( #1204 )
...
- Use single-quoted character literals or `CHARVAL` when you need
a character's numeric value; using strings as numbers is deprecated
- Use `?` to silence a node in warning/error location backtraces
- Use `===` and `!==` instead of `STRCMP`, and `++` instead of `STRCAT`
- Use `__SCOPE__` instead of checking for `..` and `.` separately
- Use `#string` instead of `"{string}"`
- All programs (rgbasm, rgblink, rgbfix, rgbgfx) support `-W` warnings
- `rgbgfx --colors dmg` is short for `rgbgfx --colors dmg=e4`
2025-11-12 15:43:54 -05:00
4c540aa43b
Replace hardware_constants.asm with the community-standard hardware.inc 5.0 ( #1186 )
2025-06-23 09:11:33 -04:00
85ddf0e90a
Don't pass redundant label names to table_width and list_start ( #1160 )
2024-12-27 12:35:35 -05:00
644bd42fb0
Identify more bit flags ( #1153 )
2024-11-29 19:29:30 -05:00
0abd8a7b38
Rename Bill's brother to Bill's older sister ( #1132 )
2024-10-17 17:03:29 -04:00
bd6ceec193
Improve some innacurate function names, labels, and comments ( #1078 )
...
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371 ]
2024-01-07 13:36:05 +01:00
dbf6044650
Update to RGBDS 0.7.0 ( #1101 )
2024-01-03 10:58:53 -05:00
a82dfd81bb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names ( #1094 )
2023-11-19 20:04:45 -05:00
f3b31087e3
Use MAP_CONNECTION_PADDING_WIDTH in MACRO connection
...
Fixes #1033
2023-08-15 19:54:16 -04:00
8e135931a6
Require rgbds 0.6.0
2022-10-02 22:03:53 -04:00
8fc3b8e6e3
Dance Theatre -> Dance Theater
...
Fixes #1008
2022-09-23 22:06:52 -04:00
0d5cf5c8b9
Refer to "Rival", not "Silver" ( #983 )
...
Fixes #982
2022-08-10 21:24:56 -04:00
3648afda16
RGBDS syntax updates ( #905 )
...
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
ed0a0f7159
Move the dbbw, dbww, and dbwww macros to legacy
2021-05-30 15:51:49 -04:00
3684296583
Revise some constant definitions
2021-03-16 18:06:18 -04:00
dbabd8b4a9
Define MAPGROUP_* constants and verify MapGroup_* table sizes
2021-03-10 21:16:54 -05:00
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
212846af57
Treat map setup commands like trade script commands
...
Fixes #736
2020-07-22 13:37:43 -04:00
a9941e28cc
Define NUM_FLYPOINTS
2020-07-21 11:48:39 -04:00
eca33ef190
Define map setup commands as macros like other script commands
2020-07-13 20:44:16 -04:00
26d764de5d
Use STRCMP, not ==, to compare multi-character strings
2020-07-02 11:46:30 -04:00
c3c18dd196
Comment more ROM labels as unreferenced
...
(Some unreferenced labels are above code which is still used via fallthrough!)
2020-06-21 18:33:31 -04:00
b9f2b93c17
Harmonize some more symbols with pokegold
2020-06-16 11:28:52 -04:00
20464d1bfb
Miscellaneous updates
...
- `PREDEFPAL_00` -> `PREDEFPAL_ROUTES` (observed from `LoadSGBLayout.GetMapPalsIndex.route`)
- `$0` -> `PLAYER` (standard person ID)
- Fix some whitespace formatting
2020-04-30 11:27:32 -04:00
6a6ba10315
rgbds supports 'X - 1' instead of 'X + -1'
2020-03-21 14:01:05 -04:00
ad50e94b50
Add a LANDMARK_ prefix to landmark constants
...
Resolves #697
2020-03-15 19:50:39 -04:00
65f22544e0
Refactor flypoints to separate const definition from data usage
2020-03-15 14:10:53 -04:00
94ebdab6d3
Merge pull request #660 from mid-kid/master
...
Make the map setup commands match the actual function names better
2020-01-04 20:08:43 -05:00
ef48ae98b5
Separate tilesets.o goes with pics.o and sprites.o
2019-11-23 20:43:33 -05:00
739a60b33c
Make the map setup commands match the actual function names better
...
These functions used as map setup commands are used in other places,
too, so I can't prefix them under the same. The names should match
except I won't repeat "map" in a map setup command name.
2019-11-18 18:21:57 +01:00
01f68fcc6a
Rename TILESET_BATTLE_TOWER to TILESET_BATTLE_TOWER_INSIDE
2019-11-03 12:03:37 -05:00
689acb0e36
Try to identify more of maps/unused/Beta*.blk
2019-04-20 14:45:20 -04:00
79dc22c769
Define constants for map event sizes
2019-03-03 14:19:16 -05:00
1853e3d127
Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank
2019-01-12 15:17:20 -05:00
814a720e9d
Adapt macro based on suggestions
2018-11-11 00:32:05 +01:00
375963349a
Finish new connection macro
...
Tried simplifying things a bit, although not nearly as much as I wanted.
Ideally, we'd either have one of two situations:
- A single set of calculations based on values depending on the
direction of the connection
- A bunch of "generic" calculations done before applying simple
modifiers to them in the final `if` block
Right now it's an icky mix of both and I'm not really sure what to make
of it.
2018-11-10 14:34:49 +01:00
abb9454307
Make the connection macro simpler to use
...
It now only takes one numerical parameter, which is the offset of the
target map relative to the source map, much like in AdvancedMap. This
makes it easier to make connections and avoids having to calculate these
values by hand, and/or "mess with the values 'till it works", as many
have been doing thus far. It's just one, easy-to-understand value.
To convert from the old macro to the new macro, just take the fourth and
the fifth parameter, and calculate `<4th_param> - <5th_param>`. The
result is the value required for the new macro.
2018-11-06 21:19:07 +01:00
0ce8dd75cd
gfx/roofs/*.png filenames match ROOF_* constants
2018-10-31 17:46:18 -04:00
5e6837807c
landmark macro includes the +8/+16 offsets for X/Y coordinates
2018-07-07 00:59:27 -04:00
67d1364c7a
Fix triple newlines left over from removing address comments
2018-06-24 23:22:50 -04:00
5efce10789
Remove even more address comments
...
That should be all of them this time
2018-06-25 02:10:37 +02:00
1d9a68dbdd
Remove all address comments
2018-06-24 16:13:22 +02:00
0447ee0cf9
Relabel some map-related WRAM
...
wMisc -> {wSurroundingTiles, wBoxPartialData, wLink_c608}
wOverworldMap -> {wOverworldMapBlocks, wHallOfFamePokemonList}
2018-03-19 11:36:14 -04:00
f0b01a4eea
Document more quirks and bugs
2018-02-26 13:41:48 -05:00
9a7da21006
Mention "HAUNTED HOUSE" ( resolves #492 )
2018-02-25 22:25:32 -05:00
2f9a0d7d9f
Pokecom Center Admin Room -> Office
2018-02-25 22:19:17 -05:00
f8f3294130
Add ROOF_ constants
2018-02-04 21:39:46 -05:00
32ed487a47
Merge branch 'master' of https://github.com/pret/pokecrystal
...
# Conflicts:
# audio/engine.asm
# constants/gfx_constants.asm
# constants/map_data_constants.asm
# constants/pokemon_data_constants.asm
# constants/sprite_constants.asm
# constants/wram_constants.asm
# data/maps/data.asm
# engine/battle/ai/scoring.asm
# engine/battle/core.asm
# engine/battle/effect_commands.asm
# engine/battle/misc.asm
# engine/battle_anims/getpokeballwobble.asm
# engine/breeding.asm
# engine/buy_sell_toss.asm
# engine/decorations.asm
# engine/events/battle_tower/battle_tower.asm
# engine/events/battle_tower/rules.asm
# engine/events/buena.asm
# engine/events/bug_contest/contest_2.asm
# engine/events/daycare.asm
# engine/events/dratini.asm
# engine/events/halloffame.asm
# engine/events/happiness_egg.asm
# engine/events/kurt.asm
# engine/events/lucky_number.asm
# engine/events/magnet_train.asm
# engine/events/overworld.asm
# engine/events/pokerus/pokerus.asm
# engine/events/print_unown.asm
# engine/events/print_unown_2.asm
# engine/events/unown_walls.asm
# engine/item_effects.asm
# engine/link.asm
# engine/mon_menu.asm
# engine/player_object.asm
# engine/routines/playslowcry.asm
# engine/scripting.asm
# engine/search.asm
# engine/search2.asm
# engine/specials.asm
# engine/start_menu.asm
# engine/timeset.asm
# home/battle_vars.asm
# home/map.asm
# maps/GoldenrodUndergroundSwitchRoomEntrances.asm
# maps/IlexForest.asm
# maps/KrissHouse2F.asm
# maps/Route39Barn.asm
# mobile/mobile_12_2.asm
# mobile/mobile_40.asm
# mobile/mobile_5f.asm
# wram.asm
2018-02-03 19:42:56 -05:00
Rangi