121 Commits

Author SHA1 Message Date
Narishma-gb 5beda23ffa Update some URLs, add a few constants (#1266) 2026-09-29 10:55:56 -04:00
Narishma-gb cbafcfea64 Add some comments/constants, minor fixes (#1255) 2026-06-08 13:33:11 -04:00
Rangi bbd7e68b4c Use the SPRITE_ANIM_FRAMESET_PARTY_MON_*_FAST constants 2026-01-11 20:10:42 -05:00
Rangi a55bc33d67 Use features of RGBDS 1.0.0 (#1204)
- Use single-quoted character literals or `CHARVAL` when you need
  a character's numeric value; using strings as numbers is deprecated
- Use `?` to silence a node in warning/error location backtraces
- Use `===` and `!==` instead of `STRCMP`, and `++` instead of `STRCAT`
- Use `__SCOPE__` instead of checking for `..` and `.` separately
- Use `#string` instead of `"{string}"`
- All programs (rgbasm, rgblink, rgbfix, rgbgfx) support `-W` warnings
- `rgbgfx --colors dmg` is short for `rgbgfx --colors dmg=e4`
2025-11-12 15:43:54 -05:00
Rangi42 468488e7a5 Identify JOYP_SGB_MLT_REQ constant 2025-08-11 16:38:46 -04:00
Rangi42 fcd13b1298 Update hardware.inc to 5.3.0 and use its new constants 2025-08-11 16:01:32 -04:00
Rangi 4c540aa43b Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#1186) 2025-06-23 09:11:33 -04:00
Darsh 7a7a06289c Add assert to note _CGB_Diploma also loads PartyMenuOBPals (#1167) 2025-02-24 12:40:50 -05:00
Rangi 85ddf0e90a Don't pass redundant label names to table_width and list_start (#1160) 2024-12-27 12:35:35 -05:00
Rangi 61c9ba5f6c Use RGBDS 0.9.0 (#1159) 2024-12-25 21:24:37 -05:00
Rangi42 41045d0266 Crystal-only jumptable exit bits 2024-12-02 12:16:30 -05:00
xCrystal bd6ceec193 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-07 13:36:05 +01:00
Rangi dbf6044650 Update to RGBDS 0.7.0 (#1101) 2024-01-03 10:58:53 -05:00
Idain 2907d65a47 Improve use of palette macro and use PAL_* constants (#1087)
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 12:24:09 -06:00
vulcandth aba1f14044 Sync sprite and battle anim consts/labels (#1055)
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 13:09:28 -05:00
Idain 94df3c5aa3 Replace magic numbers with TILE_WIDTH (#1056)
* Replace magic numbers with TILE_WIDTH

* Address more instances
2023-07-26 19:50:16 -05:00
Rangi ce004be92c Revise constants in CheckShininess 2022-10-12 21:41:08 -04:00
Rangi 7ef31d9889 Move non-Pokémon graphics out of gfx/icons
Fixes #987
2022-08-17 17:45:26 -04:00
Colton G. Rushton 145d8dd5c2 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
Rangi a2e8f078a4 Split "gfx anims" into "pic anims" and "sprite anims"
Fixes #876
2022-07-04 01:11:42 -04:00
vulcandth 3648afda16 RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
vulcandth a4d346cc8c Improved Virtual Console patch identifiers (#907) 2022-06-06 17:22:48 -04:00
vulcandth 31c3c94d64 Build the Virtual Console patch with make crystal11_vc (#882)
Fixes #813
2022-03-12 18:34:04 -05:00
Rangi e706b878d9 Use ~X instead of $ff ^ X 2021-11-23 20:37:18 -05:00
Rangi 187b120007 Add assertions to some more tables 2021-10-24 18:28:54 -04:00
Rangi bd45cfd5fd Add assert PokemonPicPointers == UnownPicPointers in GetFrontpicPointer 2021-10-06 17:44:34 -04:00
Rangi d93c13c94c Identify more palettes in CBG layouts 2021-07-19 18:59:16 -04:00
Rangi f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
Rangi 316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi 2fe0cbbb19 Add some comments regarding 16-bit increment/decrement 2021-03-24 18:34:33 -04:00
Rangi 3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi 40902ffe24 Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi 7d3ea88611 Rename GetFarHalfword to GetFarWord
Fixes #796
2021-01-09 15:16:05 -05:00
Rangi 5db892782a Remove "Buffer" suffix from two HRAM labels 2020-12-23 16:54:28 -05:00
Rangi 17894e5f39 Replace $0 with 0 for "ld l, a / ld h, 0" idiom 2020-11-09 15:20:40 -05:00
Rangi 62b756c46e Rename "dummy game" to "memory game" 2020-11-08 19:32:57 -05:00
Rangi 6220200f0f Identify some more labels, and make some more consistent 2020-11-01 12:36:38 -05:00
Rangi 4a323cf591 UnusedSpriteAnimGFX was to sprite anims as AnimObjGFX is to battle anims 2020-10-30 17:41:03 -04:00
Rangi 9b0002161b Extract more RGB data to .pal files 2020-10-30 16:12:25 -04:00
Rangi fe1a58deea Identify wSpriteAnimDict key constants 2020-10-30 15:39:08 -04:00
Rangi 1237156948 Identify mobile Name Card exchange labels 2020-10-30 10:45:31 -04:00
Rangi ea426a8879 Identify more WRAM labels, and start a <X>_DummyFunction label convention 2020-10-28 14:34:38 -04:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi c85ba78b77 Use more assertions to ensure correct code and data 2020-10-26 22:24:38 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi a2b6befd7d Identify some more labels, mostly WRAM 2020-10-23 16:04:15 -04:00
Rangi 15f6a0af43 Identify a few more labels and data 2020-10-22 12:55:46 -04:00
Rangi b9a74ff777 Identify more sprite graphics and map object labels, and have consistent anonymous jumptable labels 2020-10-22 10:54:53 -04:00
Rangi 42d0a2567a Identify some more unnamed labels 2020-10-05 20:10:01 -04:00
Rangi 6b7ade66da Identify more unnamed labels 2020-10-05 16:15:57 -04:00