525 Commits

Author SHA1 Message Date
Narishma-gb cbafcfea64 Add some comments/constants, minor fixes (#1255) 2026-06-08 13:33:11 -04:00
Rangi42 845e4a55ad Use constants for Battle Tower reward items 2026-06-06 19:11:45 -04:00
Rangi 9b69c36897 Fix the GoldenrodUndergroundSwitchRoomEntrances door-switch macros (#1245) 2026-03-01 18:18:46 -05:00
SnorlaxMonster 7c3d2956cd Consistently use Japanese control codes for Japanese strings (#1222) 2026-01-24 15:37:50 -05:00
Rangi 4c540aa43b Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#1186) 2025-06-23 09:11:33 -04:00
Brianum b34b4c3291 Document bug with Mania's Shuckie (#1187) 2025-06-06 10:59:47 -04:00
metallicity 0abd8a7b38 Rename Bill's brother to Bill's older sister (#1132) 2024-10-17 17:03:29 -04:00
Damien Doury 9ea843b8a4 Fixed wrong text label (#1107) 2024-01-29 18:59:46 -05:00
xCrystal 7f3b87950a more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap (#1078) 2024-01-07 14:37:46 +01:00
xCrystal bd6ceec193 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-07 13:36:05 +01:00
SatoMew 768b3bdec1 Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
SnorlaxMonster c931b98a81 Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (#1058)
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2023-07-26 19:51:34 -05:00
vulcandth 438c48daad Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
vulcandth bceeea8e3b Fix Typo: GoldenrodPokecomCenterSaveBeforeTradeCornetText -> GoldenrodPokecomCenterSaveBeforeTradeCornerText 2022-09-24 20:04:28 -05:00
Rangi 8fc3b8e6e3 Dance Theatre -> Dance Theater
Fixes #1008
2022-09-23 22:06:52 -04:00
Rangi 0d5cf5c8b9 Refer to "Rival", not "Silver" (#983)
Fixes #982
2022-08-10 21:24:56 -04:00
vulcandth c3331eb7b1 Rename scene and callback labels (#981)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-09 18:04:18 -04:00
Rangi 8826d97ee4 Define scene constants alongside scene_scripts (#979)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:10 -04:00
vulcandth ef9b9bb437 Clean up bugs commented in the source code (#912)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-07-09 16:12:02 -05:00
vulcandth 3648afda16 RGBDS syntax updates (#905)
New MACRO and DEF syntax
2022-06-06 17:25:42 -04:00
Idain d0c8f63f25 Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM (#879) 2022-02-22 09:47:05 -05:00
vulcandth 145ab57aba Fixed IlexForestKurtStepsDownMovement capitalization typo (#877) 2022-02-13 13:39:45 -05:00
Rangi 418c70a8af Don't require a boolean trainer flag for givepoke
Fixes #865
2022-01-10 21:16:34 -05:00
Rangi e4d82e92d0 Rename prioritysjump to sdefer 2021-06-08 20:35:04 -04:00
Rangi 90ce126139 Use numeric constants in text strings with "{d:interpolation}" 2021-03-21 18:14:31 -04:00
Rangi 6c8f8609cb Assert some more table widths 2021-03-17 11:38:01 -04:00
Rangi 97a11c623e Sync some files with pokegold 2021-03-11 17:43:20 -05:00
Rangi 3c3d87e765 Use NITE_HOUR constant for Buena's event 2021-02-16 15:58:09 -05:00
Rangi d10b168c6f Identify unreferenced Goldenrod Pokémon Center text labels 2021-02-05 13:56:39 -05:00
Rangi 4264d53eb6 Identify some more labels 2021-02-05 12:44:21 -05:00
Rangi c88c4a8340 Identify more uses of wBuffer1-6 2020-11-03 19:53:07 -05:00
Rangi 826e070f04 More syncing with pokegold 2020-11-03 10:13:06 -05:00
Rangi 6d333bed5f Replace many '; unused' with '; unreferenced' 2020-10-28 10:21:10 -04:00
Rangi 9dcdad5e60 Comment, remove, or revise many unreferenced labels 2020-10-26 20:29:58 -04:00
Rangi 7991db972b Identify some more link.asm labels (syncing to pokegold) 2020-10-23 13:36:54 -04:00
Rangi 0e3857eac7 Identify unused Route 40 movement data 2020-10-21 16:09:56 -04:00
Rangi 3cd7b9e52e Consistent (x, y) coordinates for ugdoor macro 2020-10-21 15:39:50 -04:00
Rangi ff2d850219 Identify some more unnamed labels 2020-10-05 12:02:56 -04:00
Rangi 169470378a Identify movement labels in map scripts 2020-10-04 18:15:38 -04:00
Rangi 51352aaa4d Use EGG_LEVEL for Togepi egg 2020-09-27 12:31:39 -04:00
Rangi dcb24bc724 Use def_* macros for automatic map event counts
Resolves #742
2020-07-24 09:57:16 -04:00
Rangi 59d9932255 SPRITE_GYM_GUY -> SPRITE_GYM_GUIDE 2020-07-17 13:01:48 -04:00
Rangi ef452ccbc7 return → endcallback, reloadandreturn → reloadend 2020-07-17 08:37:03 -04:00
Rangi c086de0c98 Use const_skip and const_next macros for brevity 2020-07-10 20:03:46 -04:00
Rangi 73d20afd15 Use pokepret account for committing to symbols branch 2020-06-22 17:25:42 -04:00
Rangi 61847b3596 Identify some more labels 2020-06-22 16:30:13 -04:00
Rangi 91774f206e Replace "Unreferenced" labels with "; unreferenced" comments 2020-06-21 16:27:43 -04:00
Rangi ac0025064f Identify some more Unknown labels 2020-06-20 18:52:26 -04:00
Rangi f2550fc3c2 ReplaceKrisSprite -> UpdatePlayerSprite 2020-06-16 19:38:00 -04:00
Rangi 7b2515d1e4 [in progress] Harmonize more constant and data files with pokegold 2020-06-16 14:32:57 -04:00