44 Commits

Author SHA1 Message Date
Alieneer 00362921e8 Separate engine/menu/start_menu.asm, fix missing GetSGBLayout labels, change several menu coords to use SCREEN_WIDTH and SCREEN_HEIGHT (#213) 2026-09-08 18:08:17 -04:00
Alieneer f7e5260f01 Rename FindItemInTable to IsInArray (#211)
This syncs the label with pokegold/pokecrystal.
2026-09-07 16:28:24 -04:00
Alieneer 2bfbf06cff Finish various remaining TODO items (#191) 2026-08-14 01:42:59 -04:00
Rangi 54024d427f Use more hardware constants 2026-08-05 12:29:35 -04:00
Rangi 2c13e2fa55 Replace hardware_constants.asm with hardware.inc (#189) 2026-08-05 11:57:44 -04:00
Alieneer 32f70c9b2e Add unreferenced comments to labels and correct Mail offsets (#188) 2026-08-04 21:31:07 -04:00
Alieneer 3911801821 Label all unnamed symbols (#184)
---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-08-02 13:03:11 -04:00
Alieneer e1b4a5f0b6 Finish some TODOs and extract bank 34 garbage map scripts (#177) 2026-07-06 19:51:27 -04:00
Narishma-gb 047bcb4e6d Remove some hardcoded addresses, and update PrintNumber+PrintBCDNumber flags (#174) 2026-07-06 13:19:07 -04:00
Narishma-gb e88fe24e15 Use the same Makefile build system as Gen 1+2 repos (#163)
This uses catch-all files like main.asm to reduce the total quantity and size of
build objects (from 1.1 GB to 70 MB).

---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-07-05 15:36:09 -04:00
Alieneer e3abdef586 Name all unnamed RAM symbols (#160) 2026-07-02 12:02:54 -04:00
Alieneer 4f22b8cd00 General cleanup for home/, and identify more unnamed symbols (#154)
---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-06-23 11:09:10 -04:00
Rangi 569f827a1e Only use double blank lines (triple newlines) for separating SECTIONs 2026-06-15 14:36:21 -04:00
Rangi 80191247a7 Trim trailing whitespace, and add missing newlines at end of files
git ls-files '*.asm' '*.inc' | xargs sed -i -e 's/[[:blank:]]\+$//' -e '$a\'
2026-06-15 13:50:02 -04:00
Rangi d87cd47364 Apply suggestions from code review
Co-authored-by: Narishma-gb <194818981+Narishma-gb@users.noreply.github.com>
2026-01-07 22:14:25 -05:00
DrippingYellow 2e7dc6596a Merge branch 'master' into changes 2025-12-20 13:30:16 -05:00
DrippingYellow b23ebba34a Finished labelling overworld loop states 2025-12-12 20:22:47 -06:00
Rangi42 5904823317 Remove executable permission from various files 2025-12-02 12:23:39 -05:00
Narishma-gb d94d75f8fc Charmap and text strings update (#124)
* Add Katakana `リ`, `ヘ`, `ベ`, `ペ` in charmap and text strings

* Format text strings, using macro where possible

* Remove unused charmap entries, name `Function3036`

* Charmap update and reorder, `TextAsmEnd`
2025-11-25 14:27:50 -05:00
Rangi 26a44bf940 Use features of RGBDS 1.0.0 (#123)
* All programs (rgbasm, rgblink, rgbfix, rgbgfx) support `-W` warnings

* Use `rgbgfx -c dmg` for grayscale 1bpp/2bpp

* Use new string functions and operators

* Use `?` to silence nodes in warning/error location backtraces

* Use single-quoted character literals for numeric values

* Do not warn about overwriting bytes in the corrected header
2025-11-13 15:28:12 -05:00
DrippingYellow e384ea25ec Finish labelling and split off bank03, bank09, and bank0b (#119)
* Fully labelled bank09.asm, started bank03.asm

* Finished labelling bank03.asm and bank0b.asm

* Tying up loose ends, splitting most of the completely labelled bank dumps

* Moved pokedex letter graphics out of charmap
2025-07-30 17:35:58 -04:00
DrippingYellow 030186d4cf Labelling and separating bank01.asm (#117)
* Started labelling dumped bank 1 functions, identified movement values

* Changed all NPCs to use the new movement constants

* Updated the rest of the movement constant instances, removed the old movement_constants.asm

* Ready to deal the finishing blow to bank01.asm

* Bank 01 is no more. Other scattered changes.

* Labelled a few flags and matched a few variables with pokegold

* Finished labelling bank02.asm too while I was at it
2025-07-07 19:02:15 -04:00
DrippingYellow 05a77ef010 Decompiling Pokedex and Sprite Animation objects (#114)
* Partially decompiled banks $10 and $23

* Couple minor tweaks

* Decompiled mon menu icon-related functions

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2025-03-27 23:38:42 -05:00
DrippingYellow 9e05bc90a3 Finish labelling Bank 0D (#113)
* Labelling Bank 0D, part 1

* Untangled math HRAM variables

* Bank 10's out of the bag, I guess

* Label Bank 0D, part 2, decompiled related Bank 0E functions

* Fix data outside section

* Finished labeling Bank 0D and connected variables and functions

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2025-02-15 17:48:47 -06:00
DrippingYellow ce247cc761 Adding bank14, good chunk of text transcribed and labelled in bank0d, renaming farcall to callab, and much more (#112)
* Sporadic constantifying and function naming

* Added bank 14

* Delete .DS_Store files

* Delete EOL whitespace

* Use Tab indents instead of four spaces

* Identify some routines

* Identify more stuff

* Identified party and box structs

* Identified wBattleMon and wEnemyMon structs

* Macro'd landmarks, cleaned up comments

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2025-01-16 12:12:38 -06:00
Rangi 3b4ea37c36 Replace enum with const, and update many constants to be more like pokegold 2020-09-22 12:57:02 -04:00
jd-0 8900eb7ad0 Remove address comments
Regex patterns used:
 ; [0-9a-f]{1,5} \([0-9a-f]{1,2}:[0-9a-f]{1,4}\)
 ; [0-9a-f]{1,2}:[0-9a-f]{4}
 ; [0-9a-f]{4,5}

 ;[0-9a-f]{4,5}
 ;[0-9a-f]{1,2}:[0-9a-f]{1,4}
2020-09-20 12:07:01 -07:00
Rangi fac958b280 - Remove trailing whitespace
- Indent with single tabs, not spaces
- Colons after labels
- Capitalize BANK, HIGH, and LOW
- dbw BANK(X), X -> dba X
2020-09-20 13:58:03 -04:00
Ebernacher90 d4315d68bd Give all .asm and all .inc except of base_stats/???.inc new line at the end of file 2020-09-13 03:46:21 +02:00
2Tie 7564f1a7c2 Disassembled the rest of the code in bank 4 as far as i can tell. Lines 899, 1538, and 1631 in engine/menu/start_menu.asm have hardcoded jumps that i couldn't figure out how to make work myself. 2018-11-29 01:50:18 -07:00
luckytyphlosion e1659ecd41 Introduce linkerscript.
Addresses of sections will now be added to the linkerscript via `org`, and the section name will be the path/to/file. If there is more than one section in the file, then add a @SectionName after the path/to/file to describe the section.
2018-07-03 17:07:05 -04:00
luckytyphlosion 870d85fc27 Merge branch 'master' of https://github.com/pret/pokegold-spaceworld 2018-07-03 13:27:51 -04:00
Pokeglitch 12823eea3e Added in macros for scripts, queue 2018-06-18 08:41:39 -04:00
Pokeglitch 2cb260953d Added constants, removed TODOs to health.asm 2018-06-17 07:38:57 -04:00
Pokeglitch f11e353fbb More Bank 3 routines 2018-06-16 10:24:17 -04:00
Pokeglitch c3b0443d8b Using macros for FarCall 2018-06-15 06:57:48 -04:00
Pokeglitch c955c8d353 Disassembled teleport 2018-06-14 21:46:09 -04:00
Pokeglitch d6b6771073 updated labels 2018-06-13 21:15:47 -04:00
Pokeglitch b84c9c4974 Extracted a few more bank 3 routines 2018-06-13 21:05:24 -04:00
Pokeglitch 26393f7ee2 Improved labels 2018-06-04 21:27:01 -04:00
Pokeglitch c315ddbf89 More formatting fixes 2018-06-04 20:54:45 -04:00
Pokeglitch 2873751d31 Removed unnecessary comments 2018-06-04 20:33:25 -04:00
Pokeglitch 96f14d6a3a Disassembled additional Inventory methods 2018-06-04 16:12:19 -04:00
Pokeglitch 1f01b4d330 Added Inventory Add/Remove routines 2018-06-04 14:29:20 -04:00