98 Commits

Author SHA1 Message Date
Alieneer 00362921e8 Separate engine/menu/start_menu.asm, fix missing GetSGBLayout labels, change several menu coords to use SCREEN_WIDTH and SCREEN_HEIGHT (#213) 2026-09-08 18:08:17 -04:00
Alieneer f7e5260f01 Rename FindItemInTable to IsInArray (#211)
This syncs the label with pokegold/pokecrystal.
2026-09-07 16:28:24 -04:00
Alieneer 4d6ee553b5 Rename wActiveFrame to wTextboxFrame and interpolate FrameTypeDialog.MenuData (#201)
This syncs with pokegold and pokecrystal.
2026-08-27 17:23:39 -04:00
Rangi42 a0c361cd79 Identify PartyMenuAttributes data 2026-08-14 01:55:08 -04:00
Alieneer 2bfbf06cff Finish various remaining TODO items (#191) 2026-08-14 01:42:59 -04:00
Rangi 620527be18 Do not use unnecessary parentheses 2026-08-05 12:52:43 -04:00
Rangi 54024d427f Use more hardware constants 2026-08-05 12:29:35 -04:00
Rangi 2c13e2fa55 Replace hardware_constants.asm with hardware.inc (#189) 2026-08-05 11:57:44 -04:00
Alieneer 32f70c9b2e Add unreferenced comments to labels and correct Mail offsets (#188) 2026-08-04 21:31:07 -04:00
Alieneer 3911801821 Label all unnamed symbols (#184)
---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-08-02 13:03:11 -04:00
Alieneer e1b4a5f0b6 Finish some TODOs and extract bank 34 garbage map scripts (#177) 2026-07-06 19:51:27 -04:00
Rangi 2bb372d0a7 Identify more four-digit hex literals 2026-07-06 14:01:13 -04:00
Narishma-gb 047bcb4e6d Remove some hardcoded addresses, and update PrintNumber+PrintBCDNumber flags (#174) 2026-07-06 13:19:07 -04:00
Narishma-gb e88fe24e15 Use the same Makefile build system as Gen 1+2 repos (#163)
This uses catch-all files like main.asm to reduce the total quantity and size of
build objects (from 1.1 GB to 70 MB).

---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-07-05 15:36:09 -04:00
xaerochill 3b191f8396 Name functions with exact pokegold and pokered equivalents (#161)
- TimeOfDayFade (`pokegold/home/fade.asm`) (unreferenced in `pokegold`)
- SetClock (`pokegold/home/time.asm`)
- StopRTC, StartRTC (`pokegold/engine/rtc/rtc.asm`)
- WriteOAMBlock (`pokered/home/oam.asm`)

Update call sites in oak_speech.asm and set_time.asm accordingly.
2026-07-02 18:47:16 -04:00
Alieneer e3abdef586 Name all unnamed RAM symbols (#160) 2026-07-02 12:02:54 -04:00
Rangi c220ea3f43 Fix some more non-labeled stuff and add comments 2026-07-01 22:01:49 -04:00
Alieneer 4f22b8cd00 General cleanup for home/, and identify more unnamed symbols (#154)
---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-06-23 11:09:10 -04:00
Rangi 062a875864 Clean up some whitespace
- Exactly one newline at the end of each file
- No double blank lines, except to separate SECTIONs
- Tabs only used for indentation, not alignment
2026-06-21 09:34:04 -04:00
Alieneer 41007b4796 Name labels for songs and set_time.asm (#150) 2026-06-15 20:38:19 -04:00
Rangi fc1dcf65e5 Store all garbage data as visible PNGs (#149)
Renames slack/padding to garbage, like pokeyellow
2026-06-15 19:37:09 -04:00
Rangi 569f827a1e Only use double blank lines (triple newlines) for separating SECTIONs 2026-06-15 14:36:21 -04:00
Rangi c7571ec354 Don't use tabs for aligning comments, only for initial indentation 2026-06-15 14:16:17 -04:00
Rangi 272935f57c Fix some mixed tabs and spaces 2026-06-15 14:00:48 -04:00
Rangi 80191247a7 Trim trailing whitespace, and add missing newlines at end of files
git ls-files '*.asm' '*.inc' | xargs sed -i -e 's/[[:blank:]]\+$//' -e '$a\'
2026-06-15 13:50:02 -04:00
MDTravis 4a51e1a819 Build Silver debug ROM (pokesilver-spaceworld.gb, aka Silver_debug.sgb, aka MONS2SD.COM) (#131)
* Named constants for SGB town palettes
* Correct collision_type_table.asm ID comments
* Documented 2 bugs, and 3 functions.
* Adjust sprite constants (duplicate sprite IDs reference the latest definition of it instead of the earliest)

---------

Co-authored-by: Narishma-gb <194818981+Narishma-gb@users.noreply.github.com>
Co-authored-by: Alieneer <37123222+BreavyTF2@users.noreply.github.com>
Co-authored-by: Rangi <sylvie.oukaour+rangi42@gmail.com>
2026-06-08 16:50:54 -04:00
Alieneer 605b2d2810 Disassemble Unreferenced_GetMoveSound + minor cleanup (#139)
Removes some useless origins and fixes the table in fifteen puzzle minigames.
Changes `[hl+]` to `[hli]`.
2026-06-08 15:09:55 -04:00
Alieneer d694763e28 Correct town names and Silent Hill dungeon name (#135)
Corrects Baadon to Birdon, Bull Forest to Blue Forest,
Haiteku to HighTech, and Shizukana Oka to Silent Hills.
2026-04-12 22:13:30 -04:00
DrippingYellow 2e7dc6596a Merge branch 'master' into changes 2025-12-20 13:30:16 -05:00
DrippingYellow b23ebba34a Finished labelling overworld loop states 2025-12-12 20:22:47 -06:00
Narishma-gb d94d75f8fc Charmap and text strings update (#124)
* Add Katakana `リ`, `ヘ`, `ベ`, `ペ` in charmap and text strings

* Format text strings, using macro where possible

* Remove unused charmap entries, name `Function3036`

* Charmap update and reorder, `TextAsmEnd`
2025-11-25 14:27:50 -05:00
Rangi 26a44bf940 Use features of RGBDS 1.0.0 (#123)
* All programs (rgbasm, rgblink, rgbfix, rgbgfx) support `-W` warnings

* Use `rgbgfx -c dmg` for grayscale 1bpp/2bpp

* Use new string functions and operators

* Use `?` to silence nodes in warning/error location backtraces

* Use single-quoted character literals for numeric values

* Do not warn about overwriting bytes in the corrected header
2025-11-13 15:28:12 -05:00
DrippingYellow c13ff726a7 Decompiled the rest of bank 23 2025-10-22 21:41:35 -05:00
DrippingYellow d7eb11cf06 Decompiled the rest of bank 05, definitively labelled the map object struct 2025-09-04 13:28:26 -05:00
DrippingYellow e384ea25ec Finish labelling and split off bank03, bank09, and bank0b (#119)
* Fully labelled bank09.asm, started bank03.asm

* Finished labelling bank03.asm and bank0b.asm

* Tying up loose ends, splitting most of the completely labelled bank dumps

* Moved pokedex letter graphics out of charmap
2025-07-30 17:35:58 -04:00
DrippingYellow 030186d4cf Labelling and separating bank01.asm (#117)
* Started labelling dumped bank 1 functions, identified movement values

* Changed all NPCs to use the new movement constants

* Updated the rest of the movement constant instances, removed the old movement_constants.asm

* Ready to deal the finishing blow to bank01.asm

* Bank 01 is no more. Other scattered changes.

* Labelled a few flags and matched a few variables with pokegold

* Finished labelling bank02.asm too while I was at it
2025-07-07 19:02:15 -04:00
DrippingYellow 05a77ef010 Decompiling Pokedex and Sprite Animation objects (#114)
* Partially decompiled banks $10 and $23

* Couple minor tweaks

* Decompiled mon menu icon-related functions

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2025-03-27 23:38:42 -05:00
DrippingYellow 9e05bc90a3 Finish labelling Bank 0D (#113)
* Labelling Bank 0D, part 1

* Untangled math HRAM variables

* Bank 10's out of the bag, I guess

* Label Bank 0D, part 2, decompiled related Bank 0E functions

* Fix data outside section

* Finished labeling Bank 0D and connected variables and functions

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2025-02-15 17:48:47 -06:00
DrippingYellow ce247cc761 Adding bank14, good chunk of text transcribed and labelled in bank0d, renaming farcall to callab, and much more (#112)
* Sporadic constantifying and function naming

* Added bank 14

* Delete .DS_Store files

* Delete EOL whitespace

* Use Tab indents instead of four spaces

* Identify some routines

* Identify more stuff

* Identified party and box structs

* Identified wBattleMon and wEnemyMon structs

* Macro'd landmarks, cleaned up comments

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2025-01-16 12:12:38 -06:00
Zumi 44cdca9cdd (Partially) dump banks $0D and $0F (#99)
* Bank $0f dumping (will not build)

* Optimize title logo graphic

* Make buildable again

* Add some more labels to bank $0f

* Add bank $0d, non-building

* fix erroneous shim

* bank $0D dump buildable

* Make buildable again

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 21:40:28 -06:00
rawr51919 cd0c4adf15 wVirtualOAM->wShadowOAM as per convention (#103)
* wVirtualOAM->wShadowOAM as per convention

* Use macro for expanding out wShadowOAM
2023-06-02 10:25:51 -05:00
vulcandth 84adc261cf Remove unnecessary whitespace 2023-06-02 15:11:07 +00:00
vulcandth d4e74d920a Reference wJohtoBadges in SelectedPokemonSubmenu 2023-06-02 14:58:49 +00:00
Tauwasser 910bed2381 wram: identify badge flag arrays
Signed-off-by: Tauwasser <Tauwasser@tauwasser.eu>
2023-06-02 14:27:38 +00:00
vulcandth 033ae0afed Add DEF to constants w/ some macro updates 2023-06-01 18:51:20 -05:00
Zumi af65010e2c Disassemble field debug (bank $3f) (#97)
* Disassemble SFX and cries

* Disassemble clock dialog

* Disassemble slot machine minigame

* Disassemble AnimateTilesetImpl

* Disassemble start menu frame type dialog

* Disassemble field menu

* Split debug menus into debug folder

* Remove redundant shims
2021-07-04 18:08:45 -04:00
Zumi d9f52a57a6 Disassemble RTC setup dialog and slot machine minigame (bank $24) (#87)
Also identify SFX and cry pointers
2021-01-25 22:29:07 -05:00
Zumi 735e9f09a2 Disassemble subgame portion of title debug menu (#91)
Disassemble subgame menu and add shims for the minigames in bank $38
2021-01-25 13:03:09 -05:00
Zumi c6d003b9b0 Disassemble Pokecenter PC (#90)
Disassemble Pokecenter PC and identify some menu functions in bank 09
2021-01-25 13:02:28 -05:00
Zumi Daxuya 9e07bb0778 Disassemble start menu frame type dialog 2021-01-21 16:22:01 +07:00