133 Commits

Author SHA1 Message Date
Alieneer 294d41a445 Change unused battle command and unused tileset anims labels to match pokegold-spaceworld (#150)
---------

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-06-28 13:02:16 -04:00
Narishma-gb 6d3139ce90 Rename EVENT_LAKE_OF_RAGE_ELIXIR_ON_STANDBY to match the ETHER prize 2026-06-08 13:32:48 -04:00
Narishma-gb 4cb90a8c0a Renaming in DoBattleTransition
Fix comments in `CopyBGMapViaStack` routines, fix some flags
2026-06-08 13:32:48 -04:00
Narishma-gb e317ca613f Add some comments/constants to core.asm and intro_menu.asm 2026-06-08 13:32:48 -04:00
Rangi 4a557cfebd Remove the spurious WEATHER_*_END constants
These were probably a mistake from confusing two consecutive
pointer tables, `.WeatherMessages` and `.WeatherEndedMessages`,
with one long table
2026-06-07 21:35:15 -04:00
MichailTalReborn 7caa3e141b Comment bug: AI does not discourage Nightmare if the player has any status condition 2026-06-07 01:26:15 -04:00
Jordan Moore be1ddee94d Replace magic numbers with constants in engine/battle/ai/switch.asm (#1216) 2026-01-20 19:09:39 -05:00
SourApple ba069a1fad Bug: AI use of Full Heal or Full Restore does not cure Attack or Speed drops from burn or paralysis
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2026-01-20 19:08:34 -05:00
Rangi d2c9e2d74f Use features of RGBDS 1.0.0 (#138) 2025-11-12 15:44:00 -05:00
Rangi42 b03ba1a549 Update hardware.inc to 5.1.0 2025-06-30 12:47:34 -04:00
Rangi f57be98873 Replace hardware_constants.asm with the community-standard hardware.inc 5.0 (#130) 2025-06-23 09:11:35 -04:00
Rangi42 9a798b0137 Use offsets from ANIM_* constants for wBattleAfterAnim (formerly wNumHits) 2025-05-31 15:22:54 -04:00
Rangi42 24db8a0183 Add a CANNOT_MOVE constant 2025-05-31 15:12:11 -04:00
Rangi42 83e31d7c07 Correct wrong and misleading comments about enemy trainer AI 2025-03-14 23:13:09 -04:00
Rangi42 1a7bc6b1f5 Remove "skip" prefix from AI move score labels 2024-12-29 15:33:40 -05:00
Rangi bcb1092774 Use RGBDS 0.9.0 (#124) 2024-12-25 21:24:31 -05:00
Jordan Moore 990f43865b Rename checkcurl to checkrollout 2024-12-25 12:05:58 +01:00
Rangi42 0388785af8 Use SERIAL_RNS_LENGTH in _BattleRandom 2024-12-21 21:05:39 -05:00
Sylvie 201d12d44e Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F (#123) 2024-11-30 17:25:26 -05:00
Sylvie 7ebc4324db Identify more bit flags (#120) 2024-11-28 14:50:00 -05:00
Rangi42 8e9706d8a4 Fix AI_Smart_Curse labels 2024-10-17 17:28:27 -04:00
vulcandth 00fa23fdb1 Use NUM_TRAINER_ATTRIBUTES const in AI scoring Layers 2024-07-27 22:13:19 -05:00
Rangi42 10552c2e39 Consolidate the duplicate stat level data files 2024-06-12 13:14:01 -04:00
Rangi42 1675a00a42 Use constants for VBlank handlers 2024-05-22 21:02:56 -04:00
Idain a62dfe8548 Add more assert cases in the codebase (pret/pokecrystal#1115)
* Add assert for FACING_GRASS_1 and FACING_GRASS_2

* Add more assert cases

* Add assert for HP bar colors

* Assert LINK_NULL == 0

* Fix assert syntax

* Add asserts for WILD_BATTLE == 1

* Add additional WILD assert

- I need to sleep more...

* Revert asserts for WILD_BATTLE and LINK_NULL

* Commit suggested changes

* Add more assert cases

* Fix syntax error
2024-04-27 12:23:02 -05:00
SnorlaxMonster 144133d98e Rename MON_ID to MON_OT_ID (pret/pokecrystal#1114)
* Rename MON_ID to MON_TRAINER_ID

The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.

The original definition of MON_ID is preserved in macros/legacy.asm

* Remove MON_ID from macros/legacy.asm

Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>

* Apply rename to missed file

* Rename to `MON_OT_ID`

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
2024-04-27 12:21:32 -05:00
xCrystal f035cd599c Rename wVramState to wStateFlags and use flag constants (#1078) 2024-01-30 00:35:14 +01:00
xCrystal 10d38669b0 In labels, stick to Place for text without delay, and Print for text with letter delay (#1078) 2024-01-30 00:31:05 +01:00
xCrystal c0812ca008 Improve some innacurate function names, labels, and comments (#1078)
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
2024-01-30 00:26:13 +01:00
Rangi42 202282b15b Fix bug doc formatting 2024-01-01 22:09:41 -05:00
SoupPotato a1c8b2d7dd Document SFX_RUN does not play correctly when a wild Pokemon flees from battle (pret/pokecrystal#1099)
Co-authored-by: SoupPotato <22991349+SoupPotato@users.noreply.github.com>
2024-01-01 20:42:29 -06:00
Idain 5140706094 Use proper constant for battle stats (pret/pokecrystal#1088) 2023-10-23 19:10:43 +00:00
Idain caffcdd9f7 Replace hardcoded numbers for stats (pret/pokecrystal#1073) 2023-08-21 15:56:09 +00:00
vulcandth 47c19fd588 Document fix about AI item pointer overflowing (pret/pokecrystal#1066)
Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
2023-08-10 17:26:32 -05:00
SnorlaxMonster a4aa97213d Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (pret/pokecrystal#1058)
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2023-07-27 10:53:25 -05:00
Idain 63d552f6e5 Replace magic numbers with TILE_WIDTH (pret/pokecrystal#1056)
* Replace magic numbers with TILE_WIDTH

* Address more instances
2023-07-27 10:51:54 -05:00
vulcandth ab45a2728e Bug: PRZ and BRN stat reductions don't apply to switched Pokémon
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-12-01 18:50:18 -06:00
Idain c9a8d2f5cf Replace hardcoded wMonType constants (#1011) 2022-09-28 19:52:27 -05:00
Rangi 5ae0bfb414 $f -> BATTLEACTION_FORFEIT
(thanks, Vulcandth)
2022-09-23 23:11:07 -04:00
vulcandth 6de80c7795 Fix AI_Smart_Rage comment 2022-08-21 22:45:40 -05:00
Rangi d4362cad05 Fix some whitespace 2022-08-07 00:38:04 -04:00
Colton G. Rushton 99fd84eba6 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#99) 2022-07-09 17:18:21 -04:00
vulcandth 4c95a9a708 Clean up bugs commented in the source code (#89)
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-09 16:12:32 -05:00
vulcandth 6805c678ee Rename SLP to SLP_MASK (#84)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:55 -04:00
vulcandth 357a90f08f Remove redundant comments referencing labels (#85) 2022-06-06 17:34:51 -04:00
vulcandth 464c67ee73 RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
vulcandth 2bab8a2946 Improved Virtual Console patch identifiers (#79) 2022-06-06 17:22:43 -04:00
Rangi d0491ecb6e Use NUM_BATTLE_STATS instead of raw numbers 2022-04-08 17:11:05 -04:00
vulcandth 3d58fb9556 Build the Virtual Console patches with make gold_vc and make silver_vc (#74) 2022-03-14 17:03:15 -04:00
mid-kid c43b1f7194 Use constants for PartyAttr in move_effects/thief.asm 2022-02-15 18:52:44 +01:00