2571edf37b
Avoid using EQUS when EQU or MACRO will do
2025-03-14 21:38:49 -04:00
44226aa43d
Add assert to note _CGB_Diploma also loads PartyMenuOBPals
2025-03-14 21:31:52 -04:00
1a7bc6b1f5
Remove "skip" prefix from AI move score labels
2024-12-29 15:33:40 -05:00
3affb23969
Don't pass redundant label names to table_width and list_start ( #126 )
2024-12-27 12:35:41 -05:00
bcb1092774
Use RGBDS 0.9.0 ( #124 )
2024-12-25 21:24:31 -05:00
990f43865b
Rename checkcurl to checkrollout
2024-12-25 12:05:58 +01:00
0388785af8
Use SERIAL_RNS_LENGTH in _BattleRandom
2024-12-21 21:05:39 -05:00
201d12d44e
Bit 7 of wJumptableIndex is often JUMPTABLE_EXIT_F ( #123 )
2024-11-30 17:25:26 -05:00
3257bc1924
Add documentation for HideHeadbuttTree
2024-11-28 22:03:14 -05:00
9b19999aee
Some formatting cleanup
2024-11-28 22:02:24 -05:00
7ebc4324db
Identify more bit flags ( #120 )
2024-11-28 14:50:00 -05:00
8e9706d8a4
Fix AI_Smart_Curse labels
2024-10-17 17:28:27 -04:00
b1e3ef3b45
Update mislabeled sweet_scent.asm subroutine
2024-10-17 17:20:57 -04:00
fe8254c900
Rename dt and dd to bigdt and bigdd
...
This makes their big-endianness obvious and matches `dw`
2024-10-17 14:56:47 -04:00
00fa23fdb1
Use NUM_TRAINER_ATTRIBUTES const in AI scoring Layers
2024-07-27 22:13:19 -05:00
10552c2e39
Consolidate the duplicate stat level data files
2024-06-12 13:14:01 -04:00
98d728262f
Identify various "????"s ( #116 )
2024-06-11 20:54:43 -04:00
0d3575ce8e
Rename wram_constants.asm to ram_constants.asm
2024-05-22 21:07:42 -04:00
3ea3640e1f
wPrinterQueueLength values are divisible by 2
2024-05-22 21:02:56 -04:00
1675a00a42
Use constants for VBlank handlers
2024-05-22 21:02:56 -04:00
a62dfe8548
Add more assert cases in the codebase ( pret/pokecrystal#1115 )
...
* Add assert for FACING_GRASS_1 and FACING_GRASS_2
* Add more assert cases
* Add assert for HP bar colors
* Assert LINK_NULL == 0
* Fix assert syntax
* Add asserts for WILD_BATTLE == 1
* Add additional WILD assert
- I need to sleep more...
* Revert asserts for WILD_BATTLE and LINK_NULL
* Commit suggested changes
* Add more assert cases
* Fix syntax error
2024-04-27 12:23:02 -05:00
144133d98e
Rename MON_ID to MON_OT_ID ( pret/pokecrystal#1114 )
...
* Rename MON_ID to MON_TRAINER_ID
The constant name MON_ID implies it relates to the ID number of the
Pokémon itself. However, it actually refers to the Trainer ID number of
the Pokémon's Original Trainer. Renaming it to MON_TRAINER_ID makes it
substantially more clear what its purpose is.
The original definition of MON_ID is preserved in macros/legacy.asm
* Remove MON_ID from macros/legacy.asm
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com >
* Apply rename to missed file
* Rename to `MON_OT_ID`
---------
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com >
Co-authored-by: Sylvie <35663410+Rangi42@users.noreply.github.com >
Co-authored-by: vulcandth <vulcandth@gmail.com >
2024-04-27 12:21:32 -05:00
202797a008
Fix/update sprite y-coord offscreen definitions ( pret/pokecrystal#1108 )
2024-04-14 16:09:18 -05:00
257d56018d
Address PR suggestions ( #1078 )
2024-01-30 00:42:08 +01:00
df10c9ea1a
Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission ( #1078 )
2024-01-30 00:41:51 +01:00
59642837e9
more accurate script names: refreshscreen -> reanchormap, and reloadmappart -> refreshmap ( #1078 )
2024-01-30 00:41:00 +01:00
f035cd599c
Rename wVramState to wStateFlags and use flag constants ( #1078 )
2024-01-30 00:35:14 +01:00
10d38669b0
In labels, stick to Place for text without delay, and Print for text with letter delay ( #1078 )
2024-01-30 00:31:05 +01:00
aac0d97362
Improve some innacurate function names, labels, and comments ( #1078 )
...
[https://github.com/pret/pokecrystal/issues/1078#issuecomment-1872396250 ]
2024-01-30 00:27:27 +01:00
c0812ca008
Improve some innacurate function names, labels, and comments ( #1078 )
...
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371 ]
2024-01-30 00:26:13 +01:00
202282b15b
Fix bug doc formatting
2024-01-01 22:09:41 -05:00
16571da5eb
Replace "¯" and "%" (breakable whitespace) with more meaningful charmap names
2024-01-01 21:58:26 -05:00
a1c8b2d7dd
Document SFX_RUN does not play correctly when a wild Pokemon flees from battle ( pret/pokecrystal#1099 )
...
Co-authored-by: SoupPotato <22991349+SoupPotato@users.noreply.github.com >
2024-01-01 20:42:29 -06:00
859b45abcf
Improve use of palette macro and use PAL_* constants ( pret/pokecrystal#1087 )
...
* Improve use of palette macro and use PAL_* constants
* Use proper constant for battle stats (#1088 )
* Add suggestions about function names and variables
* Add colors macro
---------
Co-authored-by: vulcandth <vulcandth@gmail.com >
2023-11-17 18:27:43 +00:00
7266ac4bdc
Correct macro for default Mystery Gift item ( pret/pokecrystal#1084 )
...
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com >
2023-11-17 18:19:26 +00:00
5140706094
Use proper constant for battle stats ( pret/pokecrystal#1088 )
2023-10-23 19:10:43 +00:00
70f883dc86
Sync sprite and battle anim consts/labels ( pret/pokecrystal#1055 )
...
* Sync sprite and battle anim consts/labels
* Add `; 00` comments
* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 14:48:08 -05:00
1a5c2b0414
1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either)
2023-09-13 08:07:13 +02:00
97a3786fc8
Labeled framesets and related constants ( pret/pokecrystal#1063 )
...
* Labeled Framesets and Constants Related
* Feedback Implemented with PascalCase and Constant Renames
* Fix framset.asm comment spacing
* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`
* Feedback applied and labeled 1E & B2
* Fixed SpinningBone
---------
Co-authored-by: vulcandth <vulcandth@gmail.com >
2023-08-21 19:11:14 -05:00
caffcdd9f7
Replace hardcoded numbers for stats ( pret/pokecrystal#1073 )
2023-08-21 15:56:09 +00:00
47c19fd588
Document fix about AI item pointer overflowing ( pret/pokecrystal#1066 )
...
Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com >
2023-08-10 17:26:32 -05:00
a4aa97213d
Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY ( pret/pokecrystal#1058 )
...
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY
The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).
* Rename to BATTLETYPE_FORCESHINY
Align name of BATTLETYPE with BATTLETYPE_FORCEITEM
---------
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com >
2023-07-27 10:53:25 -05:00
63d552f6e5
Replace magic numbers with TILE_WIDTH ( pret/pokecrystal#1056 )
...
* Replace magic numbers with TILE_WIDTH
* Address more instances
2023-07-27 10:51:54 -05:00
3edd4eb48d
Rename PAL_NPC_SILVER to PAL_NPC_EMOTE ( pret/pokecrystal#1053 )
2023-06-01 12:54:49 +00:00
be7c950f05
Use NO_INPUT instead of magic number ( pret/pokecrystal#1051 )
...
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
2023-05-28 09:17:03 -05:00
d8512cd864
Use time capsule label for time capsule copies
2023-04-19 19:11:32 +02:00
d04f895040
Use more appropriate labels for link operations
2023-04-19 19:11:26 +02:00
4cd953c1e5
Define SERIAL_PATCH_PREAMBLE_LENGTH
...
Crystal: 86cc644b970eecfb616b858ad8b697f9a09f57eb
2023-04-19 19:11:15 +02:00
5801a30424
Label wOTLinkBattleRNData
2023-04-19 19:09:40 +02:00
7050425c82
Document link patch lists a little bit better
...
Crystal: c8738a3aaecacd1ceec96bc6ccd80592f44de0fc
2023-04-19 19:09:25 +02:00
Rangi42