Commit Graph

509 Commits

Author SHA1 Message Date
vulcandth 47c19fd588 Document fix about AI item pointer overflowing (pret/pokecrystal#1066)
Co-Authored-By: Idain <54337884+Idain@users.noreply.github.com>
2023-08-10 17:26:32 -05:00
SnorlaxMonster a4aa97213d Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (pret/pokecrystal#1058)
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2023-07-27 10:53:25 -05:00
Idain 63d552f6e5 Replace magic numbers with TILE_WIDTH (pret/pokecrystal#1056)
* Replace magic numbers with TILE_WIDTH

* Address more instances
2023-07-27 10:51:54 -05:00
vulcandth 3edd4eb48d Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (pret/pokecrystal#1053) 2023-06-01 12:54:49 +00:00
Idain be7c950f05 Use NO_INPUT instead of magic number (pret/pokecrystal#1051)
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
2023-05-28 09:17:03 -05:00
mid-kid d8512cd864 Use time capsule label for time capsule copies 2023-04-19 19:11:32 +02:00
mid-kid d04f895040 Use more appropriate labels for link operations 2023-04-19 19:11:26 +02:00
mid-kid 4cd953c1e5 Define SERIAL_PATCH_PREAMBLE_LENGTH
Crystal: 86cc644b970eecfb616b858ad8b697f9a09f57eb
2023-04-19 19:11:15 +02:00
mid-kid 5801a30424 Label wOTLinkBattleRNData 2023-04-19 19:09:40 +02:00
mid-kid 7050425c82 Document link patch lists a little bit better
Crystal: c8738a3aaecacd1ceec96bc6ccd80592f44de0fc
2023-04-19 19:09:25 +02:00
mid-kid 4d20b8420c Make wMysteryGift*GameVersion constants consistent
Crystal: c244ec5a15981b890afa2d2ddef1fc77a226766c
2023-04-19 19:08:30 +02:00
mid-kid bbc7261da2 IsMailEuropean → ParseMailLanguage (and give it constants)
Crystal: c012a77e83b2a2efa7ade90b18a5a10d57900327
2023-04-19 19:06:48 +02:00
vulcandth d36f220b90 Relabel some map_object struct fields 2023-01-03 22:15:15 -06:00
vulcandth 6bfb25b9e6 Add table assert DoBattleAnimFrame.Jumptable 2022-12-23 18:50:37 -06:00
vulcandth ab45a2728e Bug: PRZ and BRN stat reductions don't apply to switched Pokémon
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-12-01 18:50:18 -06:00
vulcandth b82653d62c TrainerWalkToPlayer should reference wSeenTrainerDistance (#1020) 2022-11-22 20:05:59 -06:00
vulcandth a769f6f9ca .CheckNPC label and comment correction 2022-11-09 14:00:58 +01:00
Idain 263f7833b4 Fix Spelling Typos in engine/battle_anims/functions.asm 2022-10-16 23:16:38 -05:00
Rangi 16d88ae356 Revise constants in CheckShininess 2022-10-12 21:41:07 -04:00
Rangi 42ba9bbbe1 Require rgbds 0.6.0 2022-10-02 21:52:02 -04:00
Idain c9a8d2f5cf Replace hardcoded wMonType constants (#1011) 2022-09-28 19:52:27 -05:00
Rangi 5ae0bfb414 $f -> BATTLEACTION_FORFEIT
(thanks, Vulcandth)
2022-09-23 23:11:07 -04:00
Rangi bdb6ae85e0 Rename the object_struct field labels and constants (#105) 2022-09-12 09:15:49 -04:00
vulcandth 535e97723a Rename macros/wram.asm to macros/ram.asm (#104) 2022-09-11 01:05:06 -04:00
Rangi 0bccfa1cd1 Use for loops to generate box pointer tables 2022-09-10 13:58:48 -04:00
vulcandth 6f4209268b Use RS Group offset constants for slot_reel
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-05 12:20:03 +02:00
vulcandth 9c9744ea78 Document surfing on top of NPCs 2022-08-31 18:25:26 -05:00
vulcandth 7da3a68695 Add Bug comment for fishing/surfing on NPCs 2022-08-31 00:47:05 -05:00
Fredrik Ljungdahl 14e32d9fd3 Replace numbers with constants in PlayHitSound 2022-08-24 12:19:04 +02:00
vulcandth 6de80c7795 Fix AI_Smart_Rage comment 2022-08-21 22:45:40 -05:00
Rangi 659e083376 Move non-Pokémon graphics out of gfx/icons 2022-08-17 17:45:28 -04:00
vulcandth 2dacdbf926 Bug Doc: Options menu fails to clear joypad state on initialization 2022-08-11 23:36:33 -05:00
Rangi 902445d353 Refer to "Rival", not "Silver" (#103)
See https://github.com/pret/pokecrystal/pull/983
2022-08-10 21:24:58 -04:00
Rangi d4362cad05 Fix some whitespace 2022-08-07 00:38:04 -04:00
Rangi 22ff80f0fb Assert that there are NUM_FRAMES textbox frames 2022-08-06 12:26:09 -04:00
Rangi 2d7f97e52f Define scene constants alongside scene_scripts (#101)
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
2022-07-29 17:43:12 -04:00
Colton G. Rushton 99fd84eba6 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#99) 2022-07-09 17:18:21 -04:00
vulcandth 4c95a9a708 Clean up bugs commented in the source code (#89)
Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-07-09 16:12:32 -05:00
Rangi 09672ef3d6 Split "gfx anims" into "pic anims" and "sprite anims" 2022-07-04 01:11:41 -04:00
vulcandth 1e1dbf842b VC ExchangeBytes Aliases
Co-Authored-By: aaaaaa123456789 <aaaaaa123456789@acidch.at>
2022-06-21 11:16:20 +02:00
Rangi a2ba900bf7 Rename search2.asm 2022-06-17 23:27:50 -04:00
vulcandth b81044d4b6 Document that farcall returns c in a for some code (#91) 2022-06-17 22:30:52 -04:00
vulcandth 6805c678ee Rename SLP to SLP_MASK (#84)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:55 -04:00
vulcandth 357a90f08f Remove redundant comments referencing labels (#85) 2022-06-06 17:34:51 -04:00
vulcandth 464c67ee73 RGBDS syntax updates (#78)
New MACRO and DEF syntax
2022-06-06 17:25:39 -04:00
vulcandth 2bab8a2946 Improved Virtual Console patch identifiers (#79) 2022-06-06 17:22:43 -04:00
vulcandth a88223d9b3 Correct Intro_UpdateTilemapAndBGMap values (#88) 2022-05-27 18:35:33 -04:00
Konrad Borowski 2b6134b436 Remove Heavy Ball never happens comment
It's not correct as Snorlax weights more than 409.6 kg.
2022-05-26 19:56:29 +00:00
vulcandth 1ee3020657 Add hSerialConnectionStatus vc_asserts (#77) 2022-04-17 12:35:38 -04:00
Rangi d0491ecb6e Use NUM_BATTLE_STATS instead of raw numbers 2022-04-08 17:11:05 -04:00