* Generate decomp.dev progress reports
- Wire up CI to generate decomp.dev progress reports (using the objdiff report format) and upload them as GHA artifacts, by using `mapfile_parser`.
- This also adds a `decomp.yaml` file, which is used by `mapfile_parser` to generate the objdiff reports.
- The `progress.py` script used to locally visualize the current progress has been updated to parse objdiff reports too.
- `mapfile_parser` 2.13.0 or above is now required.
- Delete the old `upload_frogress.py` script.
Once we have this we can create an af entry in [decomp.dev](https://decomp.dev/).
I'll talk with Encounter to migrate the old frogress progress into decomp.dev too
* Activate venv
* Changes the CI system from Jenkins to Github Actions (GHA) like we did for OoT and MM (#246)
I tried to adapt the original jenkinsfile as I could.
One major difference is loosing progress reporting to frogress. frogress is currently deprecated in favor of decomp.dev, and I would like we migrate to decomp.dev somewhat soon, so this should be a big problem.
The mapfiles will be uploaded as an GHA artifact to the Action workflow.
This specific approach to handle GHA for decomp projects was adapted from the one used by the GC/Wii community. It is documented here https://github.com/encounter/dtk-template/blob/main/docs/github_actions.md There's a writeup about this adaptation for N64 projects [here](https://github.com/AngheloAlf/drmario64/pull/19).
Also relevant implementations for OoT and MM:
- https://github.com/zeldaret/oot/pull/2742
- https://github.com/zeldaret/mm/pull/1885
* Round of fixes (#247)
* Round of fixes
* Set WARNINGS_CHECK environment variable in CI
* Update .github/workflows/ci.yml
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com>
---------
Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
* prepare unknown size
* move `.data` to the C side
* remove redundant headers
* aHG_actor_ct OK
* func_80A83770_jp OK (rename to `aHG_actor_dt`)
* aHG_actor_move OK
- fix `mCoBG_CheckResult` description and comments
- extend `MyRoomClip` and fix offsets in comments
* func_80A83780_jp OK
* func_80A83930_jp OK
* func_80A83994_jp OK
* func_80A83A00_jp OK
* func_80A8401C_jp OK
* func_80A8409C_jp OK (rename to `aHG_setup_action`)
* aHG_actor_draw OK
* func_80A83D4C_jp OK
* func_80A83A24_jp OK
* name HG models
* put static HG data into the functions
* func_80A837C4_jp OK
* add notes and clean up a bit
* apply a suggestion by @hensldm
* remove ASM pragmas
* extract assets
* Rename symbols
* First pass on struct Hanami_Npc1
* Actor funcs (ct, save, dt, init, draw) OK
* Add trailing member to struct_809AEFA4
* Update Clip_unk_040_unk_E4 typedef to ActorFunc signature in order to unify *_actor_draw signatures
* All talk functions and proc functions (minus aHM1_think_main_proc.s) OK
* mFI_GetPuleIdx (func_8008930C_jp) OK; rename symbols (m_field_info)
* aHM1_set_animation OK
* aHM1_actor_move OK; update *_actor_move function signature to ActorFunc across project
* aHM1_set_request_act, aHM1_check_moveRange OK
* aHM1_check_inBlock OK; fix style in aHM1_check_moveRange
* aHM1_turn, aHM1_walk, aHM1_set_spd_info OK
* aHM1_think_init_proc OK
* aHM1_revise_moveRange OK with fake (all functions matching)
* Remove extraneous prototypes
* Fix aHM1_think_main_proc signature
* Import data
* Fix aHM1_revise_moveRange signature
* Standardize actor accesses
* Improve define usage
* Name blockX and blockZ members in Actor struct
* Remove extraneous comments
* mFI_BkNum2WposXZ OK (m_field_info)
* Add defines to m_field_info
* Formatting pass
* Remove extraneous comments
* Fix unk_18 type in struct_809AEFA4
---------
Co-authored-by: emilybrooks <emilybrooksemilybrooks@gmail.com>
* Standard actor functions and aHM0_ct_data functions OK
* Add scaffolding to Hanami_Npc0 struct
* func_809DE830_jp OK
* func_809DE434, func_809DE4A0_jp, func_809DE5BC_jp, func_809DE6B4_jp, func_809DE6C8_jp, func_809DE6EC_jp OK
* func_809DE538_jp OK with warnings
* func_809DE538_jp OK
* func_809DE714_jp OK with warnings
* func_809DE7D0_jp OK
* func_809DE8D0 OK
* func_809DE56C_jp OK with warnings
* func_809DE800_jp OK
* func_809DE978_jp OK
* func_809DE948_jp OK
* func_809DE744_jp OK
* func_809DE5DC_jp progress (nonmatching)
* Remove fake symbol D_809DEB1C_jp.
* Prepare for data import
* func_809DE5DC_jp OK, update func_809DE6EC_jp (all functions matching)
* Import data (44 differing words)
* Fix struct_809AEFA4, ac_hanami_npc0 OK
* Rename symbols + initial style pass
* Unify aHM0_*_proc function signatures
* Resolve warnings in aHM0_merry
* Update NPC actor functions + corresponding clip functions to use ActorFunc signature
* Fix aHM0_make_tumbler warning (none remain); minor cleanup
* Avoid format.py strangeness
* Fix typedef order
* prepare unknown size
* move `.data` to the C side
* aRAD_actor_ct OK
* func_80A76B2C_jp OK
* func_80A769E4_jp OK
* aRAD_actor_init OK
* func_80A76958_jp OK (rename to `aRAD_actor_dt`)
* func_80A76A30_jp OK
* func_80A76B4C_jp OK
* aRAD_actor_draw OK
* remove asm pragmas
* document `ac_radio` actions
* rename `func_80A769E4_jp` in accord with aKAG's
* rename `func_80A76B4C_jp` -> `aRAD_actor_move`
* use `StructureActor` as others do
* apply review suggestions
* seems to match too
Anghelo Carvajal